From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4837FC433E2 for ; Tue, 8 Sep 2020 08:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AE222177B for ; Tue, 8 Sep 2020 08:17:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729691AbgIHIRp (ORCPT ); Tue, 8 Sep 2020 04:17:45 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:20076 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729432AbgIHIRb (ORCPT ); Tue, 8 Sep 2020 04:17:31 -0400 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4BlygQ2VM3z9tyfZ; Tue, 8 Sep 2020 10:17:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 8E9ZAY1YbiyQ; Tue, 8 Sep 2020 10:17:22 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4BlygQ1YKJz9tyfY; Tue, 8 Sep 2020 10:17:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2B1BE8B7A1; Tue, 8 Sep 2020 10:17:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id k9FC2ZI-dL_g; Tue, 8 Sep 2020 10:17:23 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D4E3E8B768; Tue, 8 Sep 2020 10:17:20 +0200 (CEST) Subject: Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware To: Alexander Gordeev , Michael Ellerman Cc: Gerald Schaefer , Jason Gunthorpe , John Hubbard , Peter Zijlstra , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Richard Weinberger , linux-x86 , Russell King , Christian Borntraeger , Ingo Molnar , Catalin Marinas , Andrey Ryabinin , Heiko Carstens , Arnd Bergmann , Jeff Dike , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , linux-power , LKML , Andrew Morton , Linus Torvalds , Mike Rapoport References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> <31dfb3ed-a0cc-3024-d389-ab9bd19e881f@csgroup.eu> <20200908074638.GA19099@oc3871087118.ibm.com> From: Christophe Leroy Message-ID: <5d4f5546-afd0-0b8f-664d-700ae346b9ec@csgroup.eu> Date: Tue, 8 Sep 2020 10:16:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200908074638.GA19099@oc3871087118.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 08/09/2020 à 09:46, Alexander Gordeev a écrit : > On Tue, Sep 08, 2020 at 07:14:38AM +0200, Christophe Leroy wrote: >> You forgot arch/powerpc/mm/book3s64/subpage_prot.c it seems. > > Yes, and also two more sources :/ > arch/powerpc/mm/kasan/8xx.c > arch/powerpc/mm/kasan/kasan_init_32.c > > But these two are not quite obvious wrt pgd_addr_end() used > while traversing pmds. Could you please clarify a bit? > > > diff --git a/arch/powerpc/mm/kasan/8xx.c b/arch/powerpc/mm/kasan/8xx.c > index 2784224..89c5053 100644 > --- a/arch/powerpc/mm/kasan/8xx.c > +++ b/arch/powerpc/mm/kasan/8xx.c > @@ -15,8 +15,8 @@ > for (k_cur = k_start; k_cur != k_end; k_cur = k_next, pmd += 2, block += SZ_8M) { > pte_basic_t *new; > > - k_next = pgd_addr_end(k_cur, k_end); > - k_next = pgd_addr_end(k_next, k_end); > + k_next = pmd_addr_end(k_cur, k_end); > + k_next = pmd_addr_end(k_next, k_end); No, I don't think so. On powerpc32 we have only two levels, so pgd and pmd are more or less the same. But pmd_addr_end() as defined in include/asm-generic/pgtable-nopmd.h is a no-op, so I don't think it will work. It is likely that this function should iterate on pgd, then you get pmd = pmd_offset(pud_offset(p4d_offset(pgd))); > if ((void *)pmd_page_vaddr(*pmd) != kasan_early_shadow_pte) > continue; > > diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.c > index fb29404..3f7d6dc6 100644 > --- a/arch/powerpc/mm/kasan/kasan_init_32.c > +++ b/arch/powerpc/mm/kasan/kasan_init_32.c > @@ -38,7 +38,7 @@ int __init kasan_init_shadow_page_tables(unsigned long k_start, unsigned long k_ > for (k_cur = k_start; k_cur != k_end; k_cur = k_next, pmd++) { > pte_t *new; > > - k_next = pgd_addr_end(k_cur, k_end); > + k_next = pmd_addr_end(k_cur, k_end); Same here I get, iterate on pgd then get pmd = pmd_offset(pud_offset(p4d_offset(pgd))); > if ((void *)pmd_page_vaddr(*pmd) != kasan_early_shadow_pte) > continue; > > @@ -196,7 +196,7 @@ void __init kasan_early_init(void) > kasan_populate_pte(kasan_early_shadow_pte, PAGE_KERNEL); > > do { > - next = pgd_addr_end(addr, end); > + next = pmd_addr_end(addr, end); > pmd_populate_kernel(&init_mm, pmd, kasan_early_shadow_pte); > } while (pmd++, addr = next, addr != end); > > Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christophe Leroy Date: Tue, 08 Sep 2020 08:16:49 +0000 Subject: Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware Message-Id: <5d4f5546-afd0-0b8f-664d-700ae346b9ec@csgroup.eu> List-Id: References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> <31dfb3ed-a0cc-3024-d389-ab9bd19e881f@csgroup.eu> <20200908074638.GA19099@oc3871087118.ibm.com> In-Reply-To: <20200908074638.GA19099@oc3871087118.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Alexander Gordeev , Michael Ellerman Cc: Gerald Schaefer , Jason Gunthorpe , John Hubbard , Peter Zijlstra , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Richard Weinberger , linux-x86 , Russell King , Christian Borntraeger , Ingo Molnar , Catalin Marinas , Andrey Ryabinin , Heiko Carstens , Arnd Bergmann , Jeff Dike , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , linux-power , LKML , Andrew Morton , Linus Torvalds , Mike Rapoport Le 08/09/2020 à 09:46, Alexander Gordeev a écrit : > On Tue, Sep 08, 2020 at 07:14:38AM +0200, Christophe Leroy wrote: >> You forgot arch/powerpc/mm/book3s64/subpage_prot.c it seems. > > Yes, and also two more sources :/ > arch/powerpc/mm/kasan/8xx.c > arch/powerpc/mm/kasan/kasan_init_32.c > > But these two are not quite obvious wrt pgd_addr_end() used > while traversing pmds. Could you please clarify a bit? > > > diff --git a/arch/powerpc/mm/kasan/8xx.c b/arch/powerpc/mm/kasan/8xx.c > index 2784224..89c5053 100644 > --- a/arch/powerpc/mm/kasan/8xx.c > +++ b/arch/powerpc/mm/kasan/8xx.c > @@ -15,8 +15,8 @@ > for (k_cur = k_start; k_cur != k_end; k_cur = k_next, pmd += 2, block += SZ_8M) { > pte_basic_t *new; > > - k_next = pgd_addr_end(k_cur, k_end); > - k_next = pgd_addr_end(k_next, k_end); > + k_next = pmd_addr_end(k_cur, k_end); > + k_next = pmd_addr_end(k_next, k_end); No, I don't think so. On powerpc32 we have only two levels, so pgd and pmd are more or less the same. But pmd_addr_end() as defined in include/asm-generic/pgtable-nopmd.h is a no-op, so I don't think it will work. It is likely that this function should iterate on pgd, then you get pmd = pmd_offset(pud_offset(p4d_offset(pgd))); > if ((void *)pmd_page_vaddr(*pmd) != kasan_early_shadow_pte) > continue; > > diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.c > index fb29404..3f7d6dc6 100644 > --- a/arch/powerpc/mm/kasan/kasan_init_32.c > +++ b/arch/powerpc/mm/kasan/kasan_init_32.c > @@ -38,7 +38,7 @@ int __init kasan_init_shadow_page_tables(unsigned long k_start, unsigned long k_ > for (k_cur = k_start; k_cur != k_end; k_cur = k_next, pmd++) { > pte_t *new; > > - k_next = pgd_addr_end(k_cur, k_end); > + k_next = pmd_addr_end(k_cur, k_end); Same here I get, iterate on pgd then get pmd = pmd_offset(pud_offset(p4d_offset(pgd))); > if ((void *)pmd_page_vaddr(*pmd) != kasan_early_shadow_pte) > continue; > > @@ -196,7 +196,7 @@ void __init kasan_early_init(void) > kasan_populate_pte(kasan_early_shadow_pte, PAGE_KERNEL); > > do { > - next = pgd_addr_end(addr, end); > + next = pmd_addr_end(addr, end); > pmd_populate_kernel(&init_mm, pmd, kasan_early_shadow_pte); > } while (pmd++, addr = next, addr != end); > > Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F0CEC433E2 for ; Tue, 8 Sep 2020 08:32:42 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CE0E215A4 for ; Tue, 8 Sep 2020 08:32:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CE0E215A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Blz131YrpzDqQs for ; Tue, 8 Sep 2020 18:32:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Blygd45PqzDqKL for ; Tue, 8 Sep 2020 18:17:29 +1000 (AEST) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4BlygQ2VM3z9tyfZ; Tue, 8 Sep 2020 10:17:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 8E9ZAY1YbiyQ; Tue, 8 Sep 2020 10:17:22 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4BlygQ1YKJz9tyfY; Tue, 8 Sep 2020 10:17:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2B1BE8B7A1; Tue, 8 Sep 2020 10:17:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id k9FC2ZI-dL_g; Tue, 8 Sep 2020 10:17:23 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D4E3E8B768; Tue, 8 Sep 2020 10:17:20 +0200 (CEST) Subject: Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware To: Alexander Gordeev , Michael Ellerman References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> <31dfb3ed-a0cc-3024-d389-ab9bd19e881f@csgroup.eu> <20200908074638.GA19099@oc3871087118.ibm.com> From: Christophe Leroy Message-ID: <5d4f5546-afd0-0b8f-664d-700ae346b9ec@csgroup.eu> Date: Tue, 8 Sep 2020 10:16:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200908074638.GA19099@oc3871087118.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Christian Borntraeger , Richard Weinberger , linux-x86 , Russell King , Jason Gunthorpe , Ingo Molnar , Andrey Ryabinin , Gerald Schaefer , Jeff Dike , Arnd Bergmann , John Hubbard , Heiko Carstens , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , Linus Torvalds , LKML , Andrew Morton , linux-power , Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 08/09/2020 à 09:46, Alexander Gordeev a écrit : > On Tue, Sep 08, 2020 at 07:14:38AM +0200, Christophe Leroy wrote: >> You forgot arch/powerpc/mm/book3s64/subpage_prot.c it seems. > > Yes, and also two more sources :/ > arch/powerpc/mm/kasan/8xx.c > arch/powerpc/mm/kasan/kasan_init_32.c > > But these two are not quite obvious wrt pgd_addr_end() used > while traversing pmds. Could you please clarify a bit? > > > diff --git a/arch/powerpc/mm/kasan/8xx.c b/arch/powerpc/mm/kasan/8xx.c > index 2784224..89c5053 100644 > --- a/arch/powerpc/mm/kasan/8xx.c > +++ b/arch/powerpc/mm/kasan/8xx.c > @@ -15,8 +15,8 @@ > for (k_cur = k_start; k_cur != k_end; k_cur = k_next, pmd += 2, block += SZ_8M) { > pte_basic_t *new; > > - k_next = pgd_addr_end(k_cur, k_end); > - k_next = pgd_addr_end(k_next, k_end); > + k_next = pmd_addr_end(k_cur, k_end); > + k_next = pmd_addr_end(k_next, k_end); No, I don't think so. On powerpc32 we have only two levels, so pgd and pmd are more or less the same. But pmd_addr_end() as defined in include/asm-generic/pgtable-nopmd.h is a no-op, so I don't think it will work. It is likely that this function should iterate on pgd, then you get pmd = pmd_offset(pud_offset(p4d_offset(pgd))); > if ((void *)pmd_page_vaddr(*pmd) != kasan_early_shadow_pte) > continue; > > diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.c > index fb29404..3f7d6dc6 100644 > --- a/arch/powerpc/mm/kasan/kasan_init_32.c > +++ b/arch/powerpc/mm/kasan/kasan_init_32.c > @@ -38,7 +38,7 @@ int __init kasan_init_shadow_page_tables(unsigned long k_start, unsigned long k_ > for (k_cur = k_start; k_cur != k_end; k_cur = k_next, pmd++) { > pte_t *new; > > - k_next = pgd_addr_end(k_cur, k_end); > + k_next = pmd_addr_end(k_cur, k_end); Same here I get, iterate on pgd then get pmd = pmd_offset(pud_offset(p4d_offset(pgd))); > if ((void *)pmd_page_vaddr(*pmd) != kasan_early_shadow_pte) > continue; > > @@ -196,7 +196,7 @@ void __init kasan_early_init(void) > kasan_populate_pte(kasan_early_shadow_pte, PAGE_KERNEL); > > do { > - next = pgd_addr_end(addr, end); > + next = pmd_addr_end(addr, end); > pmd_populate_kernel(&init_mm, pmd, kasan_early_shadow_pte); > } while (pmd++, addr = next, addr != end); > > Christophe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 928E0C43461 for ; Tue, 8 Sep 2020 08:18:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 497A22177B for ; Tue, 8 Sep 2020 08:18:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gXPhOrEJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 497A22177B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=76XQRgo+z2HS9LxxDffxi9Y+i33vpJquA1dVmXZKkQU=; b=gXPhOrEJ+ngEZ7qLKI60VlPoX d2oiIi8WuwDzb+MJuS0yJ4r0lLnI/u3HQxCD5wqCEdkljaUb/VMIUupIZMB01PQiPPy8jlvg3cPYs Z3uUrOS+PRxqjvOzmeBqKLrwmvRC/DyPAo6eGL9XngNXh8OdxKi3aJakzWbz5FFkSooKv/0tQY9lw OCfLlmByKduYqpmUXqus+7YP3lGVXmbwX1QGOzMhWj1UACEXxXVk/+Pwnd5K5Tv1erHvY6+z/AqTF 3SueLVpdAm/MIOyCxQ6fOTDvQ4eBQr+ozR+rGaschNXrNjfOYUaTqJrOv7eIh1thIBePy2Xdrp+aP 8Z+5NEN+A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFYop-00038W-Qv; Tue, 08 Sep 2020 08:17:36 +0000 Received: from pegase1.c-s.fr ([93.17.236.30]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFYoi-00034F-9G; Tue, 08 Sep 2020 08:17:32 +0000 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4BlygQ2VM3z9tyfZ; Tue, 8 Sep 2020 10:17:22 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 8E9ZAY1YbiyQ; Tue, 8 Sep 2020 10:17:22 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4BlygQ1YKJz9tyfY; Tue, 8 Sep 2020 10:17:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2B1BE8B7A1; Tue, 8 Sep 2020 10:17:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id k9FC2ZI-dL_g; Tue, 8 Sep 2020 10:17:23 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D4E3E8B768; Tue, 8 Sep 2020 10:17:20 +0200 (CEST) Subject: Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware To: Alexander Gordeev , Michael Ellerman References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> <31dfb3ed-a0cc-3024-d389-ab9bd19e881f@csgroup.eu> <20200908074638.GA19099@oc3871087118.ibm.com> From: Christophe Leroy Message-ID: <5d4f5546-afd0-0b8f-664d-700ae346b9ec@csgroup.eu> Date: Tue, 8 Sep 2020 10:16:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200908074638.GA19099@oc3871087118.ibm.com> Content-Language: fr X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_041728_630534_83F1DE23 X-CRM114-Status: GOOD ( 19.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Christian Borntraeger , Richard Weinberger , linux-x86 , Russell King , Jason Gunthorpe , Ingo Molnar , Andrey Ryabinin , Gerald Schaefer , Jeff Dike , Arnd Bergmann , John Hubbard , Heiko Carstens , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , Linus Torvalds , LKML , Andrew Morton , linux-power , Mike Rapoport Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpMZSAwOC8wOS8yMDIwIMOgIDA5OjQ2LCBBbGV4YW5kZXIgR29yZGVldiBhIMOpY3JpdMKgOgo+ IE9uIFR1ZSwgU2VwIDA4LCAyMDIwIGF0IDA3OjE0OjM4QU0gKzAyMDAsIENocmlzdG9waGUgTGVy b3kgd3JvdGU6Cj4+IFlvdSBmb3Jnb3QgYXJjaC9wb3dlcnBjL21tL2Jvb2szczY0L3N1YnBhZ2Vf cHJvdC5jIGl0IHNlZW1zLgo+IAo+IFllcywgYW5kIGFsc28gdHdvIG1vcmUgc291cmNlcyA6Lwo+ IAlhcmNoL3Bvd2VycGMvbW0va2FzYW4vOHh4LmMKPiAJYXJjaC9wb3dlcnBjL21tL2thc2FuL2th c2FuX2luaXRfMzIuYwo+IAo+IEJ1dCB0aGVzZSB0d28gYXJlIG5vdCBxdWl0ZSBvYnZpb3VzIHdy dCBwZ2RfYWRkcl9lbmQoKSB1c2VkCj4gd2hpbGUgdHJhdmVyc2luZyBwbWRzLiBDb3VsZCB5b3Ug cGxlYXNlIGNsYXJpZnkgYSBiaXQ/Cj4gCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9t bS9rYXNhbi84eHguYyBiL2FyY2gvcG93ZXJwYy9tbS9rYXNhbi84eHguYwo+IGluZGV4IDI3ODQy MjQuLjg5YzUwNTMgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9wb3dlcnBjL21tL2thc2FuLzh4eC5jCj4g KysrIGIvYXJjaC9wb3dlcnBjL21tL2thc2FuLzh4eC5jCj4gQEAgLTE1LDggKzE1LDggQEAKPiAg IAlmb3IgKGtfY3VyID0ga19zdGFydDsga19jdXIgIT0ga19lbmQ7IGtfY3VyID0ga19uZXh0LCBw bWQgKz0gMiwgYmxvY2sgKz0gU1pfOE0pIHsKPiAgIAkJcHRlX2Jhc2ljX3QgKm5ldzsKPiAgIAo+ IC0JCWtfbmV4dCA9IHBnZF9hZGRyX2VuZChrX2N1ciwga19lbmQpOwo+IC0JCWtfbmV4dCA9IHBn ZF9hZGRyX2VuZChrX25leHQsIGtfZW5kKTsKPiArCQlrX25leHQgPSBwbWRfYWRkcl9lbmQoa19j dXIsIGtfZW5kKTsKPiArCQlrX25leHQgPSBwbWRfYWRkcl9lbmQoa19uZXh0LCBrX2VuZCk7CgpO bywgSSBkb24ndCB0aGluayBzby4KT24gcG93ZXJwYzMyIHdlIGhhdmUgb25seSB0d28gbGV2ZWxz LCBzbyBwZ2QgYW5kIHBtZCBhcmUgbW9yZSBvciBsZXNzIAp0aGUgc2FtZS4KQnV0IHBtZF9hZGRy X2VuZCgpIGFzIGRlZmluZWQgaW4gaW5jbHVkZS9hc20tZ2VuZXJpYy9wZ3RhYmxlLW5vcG1kLmgg aXMgCmEgbm8tb3AsIHNvIEkgZG9uJ3QgdGhpbmsgaXQgd2lsbCB3b3JrLgoKSXQgaXMgbGlrZWx5 IHRoYXQgdGhpcyBmdW5jdGlvbiBzaG91bGQgaXRlcmF0ZSBvbiBwZ2QsIHRoZW4geW91IGdldCBw bWQgCj0gcG1kX29mZnNldChwdWRfb2Zmc2V0KHA0ZF9vZmZzZXQocGdkKSkpOwoKPiAgIAkJaWYg KCh2b2lkICopcG1kX3BhZ2VfdmFkZHIoKnBtZCkgIT0ga2FzYW5fZWFybHlfc2hhZG93X3B0ZSkK PiAgIAkJCWNvbnRpbnVlOwo+ICAgCj4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9tbS9rYXNh bi9rYXNhbl9pbml0XzMyLmMgYi9hcmNoL3Bvd2VycGMvbW0va2FzYW4va2FzYW5faW5pdF8zMi5j Cj4gaW5kZXggZmIyOTQwNC4uM2Y3ZDZkYzYgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9wb3dlcnBjL21t L2thc2FuL2thc2FuX2luaXRfMzIuYwo+ICsrKyBiL2FyY2gvcG93ZXJwYy9tbS9rYXNhbi9rYXNh bl9pbml0XzMyLmMKPiBAQCAtMzgsNyArMzgsNyBAQCBpbnQgX19pbml0IGthc2FuX2luaXRfc2hh ZG93X3BhZ2VfdGFibGVzKHVuc2lnbmVkIGxvbmcga19zdGFydCwgdW5zaWduZWQgbG9uZyBrXwo+ ICAgCWZvciAoa19jdXIgPSBrX3N0YXJ0OyBrX2N1ciAhPSBrX2VuZDsga19jdXIgPSBrX25leHQs IHBtZCsrKSB7Cj4gICAJCXB0ZV90ICpuZXc7Cj4gICAKPiAtCQlrX25leHQgPSBwZ2RfYWRkcl9l bmQoa19jdXIsIGtfZW5kKTsKPiArCQlrX25leHQgPSBwbWRfYWRkcl9lbmQoa19jdXIsIGtfZW5k KTsKClNhbWUgaGVyZSBJIGdldCwgaXRlcmF0ZSBvbiBwZ2QgdGhlbiBnZXQgcG1kID0gCnBtZF9v ZmZzZXQocHVkX29mZnNldChwNGRfb2Zmc2V0KHBnZCkpKTsKCj4gICAJCWlmICgodm9pZCAqKXBt ZF9wYWdlX3ZhZGRyKCpwbWQpICE9IGthc2FuX2Vhcmx5X3NoYWRvd19wdGUpCj4gICAJCQljb250 aW51ZTsKPiAgIAo+IEBAIC0xOTYsNyArMTk2LDcgQEAgdm9pZCBfX2luaXQga2FzYW5fZWFybHlf aW5pdCh2b2lkKQo+ICAgCWthc2FuX3BvcHVsYXRlX3B0ZShrYXNhbl9lYXJseV9zaGFkb3dfcHRl LCBQQUdFX0tFUk5FTCk7Cj4gICAKPiAgIAlkbyB7Cj4gLQkJbmV4dCA9IHBnZF9hZGRyX2VuZChh ZGRyLCBlbmQpOwo+ICsJCW5leHQgPSBwbWRfYWRkcl9lbmQoYWRkciwgZW5kKTsKPiAgIAkJcG1k X3BvcHVsYXRlX2tlcm5lbCgmaW5pdF9tbSwgcG1kLCBrYXNhbl9lYXJseV9zaGFkb3dfcHRlKTsK PiAgIAl9IHdoaWxlIChwbWQrKywgYWRkciA9IG5leHQsIGFkZHIgIT0gZW5kKTsKPiAgIAo+IAoK Q2hyaXN0b3BoZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [RFC PATCH v2 2/3] mm: make pXd_addr_end() functions page-table entry aware References: <20200907180058.64880-1-gerald.schaefer@linux.ibm.com> <20200907180058.64880-3-gerald.schaefer@linux.ibm.com> <31dfb3ed-a0cc-3024-d389-ab9bd19e881f@csgroup.eu> <20200908074638.GA19099@oc3871087118.ibm.com> From: Christophe Leroy Message-ID: <5d4f5546-afd0-0b8f-664d-700ae346b9ec@csgroup.eu> Date: Tue, 8 Sep 2020 10:16:49 +0200 MIME-Version: 1.0 In-Reply-To: <20200908074638.GA19099@oc3871087118.ibm.com> Content-Language: fr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Alexander Gordeev , Michael Ellerman Cc: Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Vasily Gorbik , Christian Borntraeger , Richard Weinberger , linux-x86 , Russell King , Jason Gunthorpe , Ingo Molnar , Andrey Ryabinin , Gerald Schaefer , Jeff Dike , Arnd Bergmann , John Hubbard , Heiko Carstens , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , Linus Torvalds , LKML , Andrew Morton , linux-power , Mike Rapoport CgpMZSAwOC8wOS8yMDIwIMOgIDA5OjQ2LCBBbGV4YW5kZXIgR29yZGVldiBhIMOpY3JpdMKgOgo+ IE9uIFR1ZSwgU2VwIDA4LCAyMDIwIGF0IDA3OjE0OjM4QU0gKzAyMDAsIENocmlzdG9waGUgTGVy b3kgd3JvdGU6Cj4+IFlvdSBmb3Jnb3QgYXJjaC9wb3dlcnBjL21tL2Jvb2szczY0L3N1YnBhZ2Vf cHJvdC5jIGl0IHNlZW1zLgo+IAo+IFllcywgYW5kIGFsc28gdHdvIG1vcmUgc291cmNlcyA6Lwo+ IAlhcmNoL3Bvd2VycGMvbW0va2FzYW4vOHh4LmMKPiAJYXJjaC9wb3dlcnBjL21tL2thc2FuL2th c2FuX2luaXRfMzIuYwo+IAo+IEJ1dCB0aGVzZSB0d28gYXJlIG5vdCBxdWl0ZSBvYnZpb3VzIHdy dCBwZ2RfYWRkcl9lbmQoKSB1c2VkCj4gd2hpbGUgdHJhdmVyc2luZyBwbWRzLiBDb3VsZCB5b3Ug cGxlYXNlIGNsYXJpZnkgYSBiaXQ/Cj4gCj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9t bS9rYXNhbi84eHguYyBiL2FyY2gvcG93ZXJwYy9tbS9rYXNhbi84eHguYwo+IGluZGV4IDI3ODQy MjQuLjg5YzUwNTMgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9wb3dlcnBjL21tL2thc2FuLzh4eC5jCj4g KysrIGIvYXJjaC9wb3dlcnBjL21tL2thc2FuLzh4eC5jCj4gQEAgLTE1LDggKzE1LDggQEAKPiAg IAlmb3IgKGtfY3VyID0ga19zdGFydDsga19jdXIgIT0ga19lbmQ7IGtfY3VyID0ga19uZXh0LCBw bWQgKz0gMiwgYmxvY2sgKz0gU1pfOE0pIHsKPiAgIAkJcHRlX2Jhc2ljX3QgKm5ldzsKPiAgIAo+ IC0JCWtfbmV4dCA9IHBnZF9hZGRyX2VuZChrX2N1ciwga19lbmQpOwo+IC0JCWtfbmV4dCA9IHBn ZF9hZGRyX2VuZChrX25leHQsIGtfZW5kKTsKPiArCQlrX25leHQgPSBwbWRfYWRkcl9lbmQoa19j dXIsIGtfZW5kKTsKPiArCQlrX25leHQgPSBwbWRfYWRkcl9lbmQoa19uZXh0LCBrX2VuZCk7CgpO bywgSSBkb24ndCB0aGluayBzby4KT24gcG93ZXJwYzMyIHdlIGhhdmUgb25seSB0d28gbGV2ZWxz LCBzbyBwZ2QgYW5kIHBtZCBhcmUgbW9yZSBvciBsZXNzIAp0aGUgc2FtZS4KQnV0IHBtZF9hZGRy X2VuZCgpIGFzIGRlZmluZWQgaW4gaW5jbHVkZS9hc20tZ2VuZXJpYy9wZ3RhYmxlLW5vcG1kLmgg aXMgCmEgbm8tb3AsIHNvIEkgZG9uJ3QgdGhpbmsgaXQgd2lsbCB3b3JrLgoKSXQgaXMgbGlrZWx5 IHRoYXQgdGhpcyBmdW5jdGlvbiBzaG91bGQgaXRlcmF0ZSBvbiBwZ2QsIHRoZW4geW91IGdldCBw bWQgCj0gcG1kX29mZnNldChwdWRfb2Zmc2V0KHA0ZF9vZmZzZXQocGdkKSkpOwoKPiAgIAkJaWYg KCh2b2lkICopcG1kX3BhZ2VfdmFkZHIoKnBtZCkgIT0ga2FzYW5fZWFybHlfc2hhZG93X3B0ZSkK PiAgIAkJCWNvbnRpbnVlOwo+ICAgCj4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9tbS9rYXNh bi9rYXNhbl9pbml0XzMyLmMgYi9hcmNoL3Bvd2VycGMvbW0va2FzYW4va2FzYW5faW5pdF8zMi5j Cj4gaW5kZXggZmIyOTQwNC4uM2Y3ZDZkYzYgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9wb3dlcnBjL21t L2thc2FuL2thc2FuX2luaXRfMzIuYwo+ICsrKyBiL2FyY2gvcG93ZXJwYy9tbS9rYXNhbi9rYXNh bl9pbml0XzMyLmMKPiBAQCAtMzgsNyArMzgsNyBAQCBpbnQgX19pbml0IGthc2FuX2luaXRfc2hh ZG93X3BhZ2VfdGFibGVzKHVuc2lnbmVkIGxvbmcga19zdGFydCwgdW5zaWduZWQgbG9uZyBrXwo+ ICAgCWZvciAoa19jdXIgPSBrX3N0YXJ0OyBrX2N1ciAhPSBrX2VuZDsga19jdXIgPSBrX25leHQs IHBtZCsrKSB7Cj4gICAJCXB0ZV90ICpuZXc7Cj4gICAKPiAtCQlrX25leHQgPSBwZ2RfYWRkcl9l bmQoa19jdXIsIGtfZW5kKTsKPiArCQlrX25leHQgPSBwbWRfYWRkcl9lbmQoa19jdXIsIGtfZW5k KTsKClNhbWUgaGVyZSBJIGdldCwgaXRlcmF0ZSBvbiBwZ2QgdGhlbiBnZXQgcG1kID0gCnBtZF9v ZmZzZXQocHVkX29mZnNldChwNGRfb2Zmc2V0KHBnZCkpKTsKCj4gICAJCWlmICgodm9pZCAqKXBt ZF9wYWdlX3ZhZGRyKCpwbWQpICE9IGthc2FuX2Vhcmx5X3NoYWRvd19wdGUpCj4gICAJCQljb250 aW51ZTsKPiAgIAo+IEBAIC0xOTYsNyArMTk2LDcgQEAgdm9pZCBfX2luaXQga2FzYW5fZWFybHlf aW5pdCh2b2lkKQo+ICAgCWthc2FuX3BvcHVsYXRlX3B0ZShrYXNhbl9lYXJseV9zaGFkb3dfcHRl LCBQQUdFX0tFUk5FTCk7Cj4gICAKPiAgIAlkbyB7Cj4gLQkJbmV4dCA9IHBnZF9hZGRyX2VuZChh ZGRyLCBlbmQpOwo+ICsJCW5leHQgPSBwbWRfYWRkcl9lbmQoYWRkciwgZW5kKTsKPiAgIAkJcG1k X3BvcHVsYXRlX2tlcm5lbCgmaW5pdF9tbSwgcG1kLCBrYXNhbl9lYXJseV9zaGFkb3dfcHRlKTsK PiAgIAl9IHdoaWxlIChwbWQrKywgYWRkciA9IG5leHQsIGFkZHIgIT0gZW5kKTsKPiAgIAo+IAoK Q2hyaXN0b3BoZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtdW0gbWFpbGluZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11bQo=