From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 664E3C5ACC4 for ; Thu, 20 Feb 2020 03:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A68F21D56 for ; Thu, 20 Feb 2020 03:25:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727922AbgBTDZx (ORCPT ); Wed, 19 Feb 2020 22:25:53 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:34362 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727208AbgBTDZw (ORCPT ); Wed, 19 Feb 2020 22:25:52 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 51068A1533B41914DC60; Thu, 20 Feb 2020 11:25:49 +0800 (CST) Received: from [127.0.0.1] (10.173.222.27) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Thu, 20 Feb 2020 11:25:43 +0800 Subject: Re: [PATCH v4 06/20] irqchip/gic-v4.1: Add initial SGI configuration To: Marc Zyngier CC: , , , , Lorenzo Pieralisi , Jason Cooper , "Robert Richter" , Thomas Gleixner , "Eric Auger" , James Morse , "Julien Thierry" , Suzuki K Poulose References: <20200214145736.18550-1-maz@kernel.org> <20200214145736.18550-7-maz@kernel.org> <4a64bf17c015cb10e62d9c1a1ff64db5@kernel.org> From: Zenghui Yu Message-ID: <5d511c78-2339-2aea-8bfc-e13ed464af11@huawei.com> Date: Thu, 20 Feb 2020 11:25:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <4a64bf17c015cb10e62d9c1a1ff64db5@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.222.27] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, On 2020/2/18 17:46, Marc Zyngier wrote: > Hi Zenghui, > > On 2020-02-18 07:25, Zenghui Yu wrote: >> Hi Marc, > > [...] > >>>     static void its_sgi_irq_domain_deactivate(struct irq_domain *domain, >>>                         struct irq_data *d) >>>   { >>> -    /* Nothing to do */ >>> +    struct its_vpe *vpe = irq_data_get_irq_chip_data(d); >>> + >>> +    vpe->sgi_config[d->hwirq].enabled = false; >>> +    its_configure_sgi(d, true); >> >> The spec says, when C==1, VSGI clears the pending state of the vSGI, >> leaving the configuration unchanged.  So should we first clear the >> pending state and then disable vSGI (let E==0)? > > Right you are again. We need two commands, not just one (the pseudocode is > pretty explicit). With that change, Reviewed-by: Zenghui Yu Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B45AC7619D for ; Thu, 20 Feb 2020 03:26:02 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 2143F21D56 for ; Thu, 20 Feb 2020 03:26:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2143F21D56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8E06E4AE92; Wed, 19 Feb 2020 22:26:01 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fzshTtAOlESY; Wed, 19 Feb 2020 22:26:00 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 874804AEAB; Wed, 19 Feb 2020 22:26:00 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D1EFB4AE93 for ; Wed, 19 Feb 2020 22:25:59 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P8hjBfCzvOGf for ; Wed, 19 Feb 2020 22:25:58 -0500 (EST) Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 98BB44AE92 for ; Wed, 19 Feb 2020 22:25:58 -0500 (EST) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 51068A1533B41914DC60; Thu, 20 Feb 2020 11:25:49 +0800 (CST) Received: from [127.0.0.1] (10.173.222.27) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Thu, 20 Feb 2020 11:25:43 +0800 Subject: Re: [PATCH v4 06/20] irqchip/gic-v4.1: Add initial SGI configuration To: Marc Zyngier References: <20200214145736.18550-1-maz@kernel.org> <20200214145736.18550-7-maz@kernel.org> <4a64bf17c015cb10e62d9c1a1ff64db5@kernel.org> From: Zenghui Yu Message-ID: <5d511c78-2339-2aea-8bfc-e13ed464af11@huawei.com> Date: Thu, 20 Feb 2020 11:25:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <4a64bf17c015cb10e62d9c1a1ff64db5@kernel.org> Content-Language: en-US X-Originating-IP: [10.173.222.27] X-CFilter-Loop: Reflected Cc: Lorenzo Pieralisi , Jason Cooper , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Richter , Thomas Gleixner , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGkgTWFyYywKCk9uIDIwMjAvMi8xOCAxNzo0NiwgTWFyYyBaeW5naWVyIHdyb3RlOgo+IEhpIFpl bmdodWksCj4gCj4gT24gMjAyMC0wMi0xOCAwNzoyNSwgWmVuZ2h1aSBZdSB3cm90ZToKPj4gSGkg TWFyYywKPiAKPiBbLi4uXQo+IAo+Pj4gwqDCoMKgIHN0YXRpYyB2b2lkIGl0c19zZ2lfaXJxX2Rv bWFpbl9kZWFjdGl2YXRlKHN0cnVjdCBpcnFfZG9tYWluICpkb21haW4sCj4+PiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBpcnFfZGF0YSAqZCkK Pj4+IMKgIHsKPj4+IC3CoMKgwqAgLyogTm90aGluZyB0byBkbyAqLwo+Pj4gK8KgwqDCoCBzdHJ1 Y3QgaXRzX3ZwZSAqdnBlID0gaXJxX2RhdGFfZ2V0X2lycV9jaGlwX2RhdGEoZCk7Cj4+PiArCj4+ PiArwqDCoMKgIHZwZS0+c2dpX2NvbmZpZ1tkLT5od2lycV0uZW5hYmxlZCA9IGZhbHNlOwo+Pj4g K8KgwqDCoCBpdHNfY29uZmlndXJlX3NnaShkLCB0cnVlKTsKPj4KPj4gVGhlIHNwZWMgc2F5cywg d2hlbiBDPT0xLCBWU0dJIGNsZWFycyB0aGUgcGVuZGluZyBzdGF0ZSBvZiB0aGUgdlNHSSwKPj4g bGVhdmluZyB0aGUgY29uZmlndXJhdGlvbiB1bmNoYW5nZWQuwqAgU28gc2hvdWxkIHdlIGZpcnN0 IGNsZWFyIHRoZQo+PiBwZW5kaW5nIHN0YXRlIGFuZCB0aGVuIGRpc2FibGUgdlNHSSAobGV0IEU9 PTApPwo+IAo+IFJpZ2h0IHlvdSBhcmUgYWdhaW4uIFdlIG5lZWQgdHdvIGNvbW1hbmRzLCBub3Qg anVzdCBvbmUgKHRoZSBwc2V1ZG9jb2RlIGlzCj4gcHJldHR5IGV4cGxpY2l0KS4KCldpdGggdGhh dCBjaGFuZ2UsCgpSZXZpZXdlZC1ieTogWmVuZ2h1aSBZdSA8eXV6ZW5naHVpQGh1YXdlaS5jb20+ CgoKVGhhbmtzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwprdm1hcm0gbWFpbGluZyBsaXN0Cmt2bWFybUBsaXN0cy5jcy5jb2x1bWJpYS5lZHUKaHR0cHM6 Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvbWFpbG1hbi9saXN0aW5mby9rdm1hcm0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82BB1C5ACC4 for ; Thu, 20 Feb 2020 03:26:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5430C21D56 for ; Thu, 20 Feb 2020 03:26:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JjxYk4h9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5430C21D56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gz2vKkjteSJGGaueZvj7cSwwD3TDtpFaKp2AdwDzFbk=; b=JjxYk4h9OZ9gZh2UOcclxGK+D Qge0RIlohrH7Bcx48nEHlBeZkDTTgRdxwniMDb5AbKuov2S4969PIgalBOe2///I9dP2ZmlJJGxYV SFzQ4USGAHfDSS+cwnxBvSoJb8P64ykLXAVT+TQ4Cf9+z6TYe/8xyV7JOAMD4Yzrj8xsbsf/zUVIi GB+qFX1mpmYWqK3RTFk+5sZVxSuVvjvad7nwhqPz5l2Z8tTnq3L0dSCrE0cszM3HoA89Zz5g1VIFK uc1arFyp5gCz8zATvme0uI3hkd+rZjm0ANM9y1dwwKfWEhsfH2g8YBy04BoOgHR7NBm+PvanY/uRo YxCNVD26A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4cTN-0003H1-4a; Thu, 20 Feb 2020 03:25:57 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4cTI-0003Ga-HJ for linux-arm-kernel@lists.infradead.org; Thu, 20 Feb 2020 03:25:55 +0000 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 51068A1533B41914DC60; Thu, 20 Feb 2020 11:25:49 +0800 (CST) Received: from [127.0.0.1] (10.173.222.27) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Thu, 20 Feb 2020 11:25:43 +0800 Subject: Re: [PATCH v4 06/20] irqchip/gic-v4.1: Add initial SGI configuration To: Marc Zyngier References: <20200214145736.18550-1-maz@kernel.org> <20200214145736.18550-7-maz@kernel.org> <4a64bf17c015cb10e62d9c1a1ff64db5@kernel.org> From: Zenghui Yu Message-ID: <5d511c78-2339-2aea-8bfc-e13ed464af11@huawei.com> Date: Thu, 20 Feb 2020 11:25:41 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <4a64bf17c015cb10e62d9c1a1ff64db5@kernel.org> Content-Language: en-US X-Originating-IP: [10.173.222.27] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200219_192552_744965_A885700D X-CRM114-Status: GOOD ( 10.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Jason Cooper , kvm@vger.kernel.org, Suzuki K Poulose , linux-kernel@vger.kernel.org, Eric Auger , Robert Richter , James Morse , Julien Thierry , Thomas Gleixner , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWFyYywKCk9uIDIwMjAvMi8xOCAxNzo0NiwgTWFyYyBaeW5naWVyIHdyb3RlOgo+IEhpIFpl bmdodWksCj4gCj4gT24gMjAyMC0wMi0xOCAwNzoyNSwgWmVuZ2h1aSBZdSB3cm90ZToKPj4gSGkg TWFyYywKPiAKPiBbLi4uXQo+IAo+Pj4gwqDCoMKgIHN0YXRpYyB2b2lkIGl0c19zZ2lfaXJxX2Rv bWFpbl9kZWFjdGl2YXRlKHN0cnVjdCBpcnFfZG9tYWluICpkb21haW4sCj4+PiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHN0cnVjdCBpcnFfZGF0YSAqZCkK Pj4+IMKgIHsKPj4+IC3CoMKgwqAgLyogTm90aGluZyB0byBkbyAqLwo+Pj4gK8KgwqDCoCBzdHJ1 Y3QgaXRzX3ZwZSAqdnBlID0gaXJxX2RhdGFfZ2V0X2lycV9jaGlwX2RhdGEoZCk7Cj4+PiArCj4+ PiArwqDCoMKgIHZwZS0+c2dpX2NvbmZpZ1tkLT5od2lycV0uZW5hYmxlZCA9IGZhbHNlOwo+Pj4g K8KgwqDCoCBpdHNfY29uZmlndXJlX3NnaShkLCB0cnVlKTsKPj4KPj4gVGhlIHNwZWMgc2F5cywg d2hlbiBDPT0xLCBWU0dJIGNsZWFycyB0aGUgcGVuZGluZyBzdGF0ZSBvZiB0aGUgdlNHSSwKPj4g bGVhdmluZyB0aGUgY29uZmlndXJhdGlvbiB1bmNoYW5nZWQuwqAgU28gc2hvdWxkIHdlIGZpcnN0 IGNsZWFyIHRoZQo+PiBwZW5kaW5nIHN0YXRlIGFuZCB0aGVuIGRpc2FibGUgdlNHSSAobGV0IEU9 PTApPwo+IAo+IFJpZ2h0IHlvdSBhcmUgYWdhaW4uIFdlIG5lZWQgdHdvIGNvbW1hbmRzLCBub3Qg anVzdCBvbmUgKHRoZSBwc2V1ZG9jb2RlIGlzCj4gcHJldHR5IGV4cGxpY2l0KS4KCldpdGggdGhh dCBjaGFuZ2UsCgpSZXZpZXdlZC1ieTogWmVuZ2h1aSBZdSA8eXV6ZW5naHVpQGh1YXdlaS5jb20+ CgoKVGhhbmtzCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo=