All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trilok Soni <soni.trilok@gmail.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Kim Kyuwon <q1.kim@samsung.com>, Kim Kyuwon <chammoru@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-input@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] Input: add MAX7359 key switch controller driver, v2
Date: Tue, 14 Jul 2009 14:41:36 +0530	[thread overview]
Message-ID: <5d5443650907140211i4c6e4a49q9c055dc1e91071da@mail.gmail.com> (raw)
In-Reply-To: <002a01ca0462$8b750a90$a25f1fb0$%szyprowski@samsung.com>

Hi Marek,

On Tue, Jul 14, 2009 at 2:37 PM, Marek
Szyprowski<m.szyprowski@samsung.com> wrote:
> Hello,
>
> On Tuesday, July 14, 2009 10:25 AM, Dmitry Torokhov wrote:
>
>> On Tue, Jul 14, 2009 at 08:28:05AM +0200, Marek Szyprowski wrote:
>> > Hello,
>> > On Tuesday, July 14, 2009 5:10 AM, Kim Kyuwon wrote:
>> > > Dmitry Torokhov wrote:
>> > > > On Mon, Jul 13, 2009 at 02:22:10PM +0530, Trilok Soni wrote:
>> > > >> I don't see this driver picked up yet in your -next branch. We should
>> > > >> target this driver to be mainlined in next merge window. This is very
>> > > >> important driver for some of the embedded systems, including palm pre
>> > > >> :)
>> > > > I was wondering if somebody could test the patch below and if it still
>> > > > works then I will apply to the next branch. Thanks!
>> > > >
>> > >
>> > > Dear Marek,
>> > >
>> > > Because I don't have the NCP board(which includes the max7359 keypad)
>> > > now, I can't test this patch. Marek, could you please test this patch?
>> >
>> > I would like to, but I could not find the base version to which I can apply
>> > that patch. I've tried v2 version posted in '[PATCH] Input: add MAX7359 key
>> > switch controller driver, v2' mail from Sat 2009-05-09 04:10 with 2 patches
>> > posted in replies to that main, but the latest patch still fails to apply.
>> >
>> > Could someone send me a complete patch, so I can do a test?
>> >
>>
>> Sending everything as attachments, maybe that will help...
>
> Ok. I've did the tests.
>
> MAX7359 keypad driver works after your patch, but reports much more events than
> the previous version. In this test I pressed quickly the first button on the
> keypad.
>
> Old version:
> NCP:~# hexdump /dev/input/event0
> 0000000 0037 0000 e733 000b 0001 00e7 0001 0000
> 0000010 0037 0000 e748 000b 0000 0000 0000 0000
> 0000020 0037 0000 94e2 000d 0001 00e7 0000 0000
> 0000030 0037 0000 94f3 000d 0000 0000 0000 0000
>

Please use evtest instead. It will give better output atleast.

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni

  reply	other threads:[~2009-07-14  9:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-09  2:09 [PATCH] Input: add MAX7359 key switch controller driver, v2 Kim Kyuwon
2009-05-09 17:27 ` Trilok Soni
2009-05-09 20:01   ` Dmitry Torokhov
2009-05-11  1:51     ` Kim Kyuwon
2009-05-11  2:08       ` Dmitry Torokhov
2009-05-11  2:34   ` Kim Kyuwon
2009-05-11  2:34     ` Kim Kyuwon
2009-05-11  3:12     ` Dmitry Torokhov
2009-06-19 17:38       ` Trilok Soni
2009-07-13  8:52         ` Trilok Soni
2009-07-13  9:31           ` Dmitry Torokhov
2009-07-14  3:09             ` Kim Kyuwon
2009-07-14  6:28               ` Marek Szyprowski
2009-07-14  8:24                 ` Dmitry Torokhov
2009-07-14  8:53                   ` Trilok Soni
2009-07-14  9:07                   ` Marek Szyprowski
2009-07-14  9:11                     ` Trilok Soni [this message]
2009-07-14 10:18                       ` Marek Szyprowski
2009-07-14 10:23                         ` Trilok Soni
2009-07-14 10:23                           ` Trilok Soni
2009-07-15  7:15                           ` Marek Szyprowski
2009-07-15  7:15                             ` Marek Szyprowski
2009-09-16  8:57                             ` Dmitry Torokhov
2009-09-16  8:57                               ` Dmitry Torokhov
2009-09-18  8:14                               ` Joonyoung Shim
2009-09-18  8:14                                 ` Joonyoung Shim
2009-09-18 16:39                                 ` Dmitry Torokhov
2009-09-19  0:07                                   ` Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d5443650907140211i4c6e4a49q9c055dc1e91071da@mail.gmail.com \
    --to=soni.trilok@gmail.com \
    --cc=chammoru@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=q1.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.