Re: [PATCH 5/6] haptic: Samsung SoCs PWM controlled haptic support

From: Trilok Soni <soni.trilok@gmail.com>
To: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	Bill Gatliff <bgat@billgatliff.com>,
	ben-linux@fluff.org
Subject: Re: [PATCH 5/6] haptic: Samsung SoCs PWM controlled haptic support
Date: Thu, 8 Oct 2009 23:58:37 +0530	[thread overview]
Message-ID: <5d5443650910081128l58f45148m87735185a0094c31@mail.gmail.com> (raw)
In-Reply-To: <20091007061822.GA7602@july>

Adding Bill Gatliff.

Hi Kyungmin,

Most of the driver looks fine. I have only one generic comment, but
not for this driver:

- Someone should really work on getting PWM framework (may be the one
written by Bill Gatliff) into the kernel, because
  if we don't do this and if new PWM controller provides it's own APIs
then we can't leverage the chips using them, like the
  case here for ISA1000 and ISA1200. These chips are using the pwm
APIs exported by Samsung PWM controller, but it would
  be painful to integrate other PWM controller if that has slightly
little different API due to its nature.

  So, it would be better to get one generic PWM framework mainline in
the kernel.

> +static int __devexit samsung_pwm_haptic_remove(struct platform_device *pdev)
> +{
> +       struct samsung_pwm_haptic *haptic = platform_get_drvdata(pdev);
> +
> +       samsung_pwm_haptic_set(&haptic->cdev, HAPTIC_OFF);
> +       del_timer_sync(&haptic->timer);

cancel_work_sync ?

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni