From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <stefanos@xilinx.com>,
JBeulich@suse.com, andrew.cooper3@citrix.com
Subject: Re: [Xen-devel] [PATCH v3 1/5] xen: add a p2mt parameter to map_mmio_regions
Date: Wed, 10 Jul 2019 18:17:36 +0100 [thread overview]
Message-ID: <5d5749e2-883d-70f5-b953-7381d9207b0b@arm.com> (raw)
In-Reply-To: <20190618232019.26425-1-sstabellini@kernel.org>
Hi Stefano,
The Arm code looks good to me. One comment below.
On 6/19/19 12:20 AM, Stefano Stabellini wrote:
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index e28ea1c85a..d88df11e09 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -1310,31 +1310,18 @@ static inline int p2m_remove_mapping(struct domain *d,
> return rc;
> }
>
> -int map_regions_p2mt(struct domain *d,
> +int map_mmio_regions(struct domain *d,
> gfn_t gfn,
> unsigned long nr,
> mfn_t mfn,
> p2m_type_t p2mt)
> {
> + ASSERT( p2mt == p2m_mmio_direct_dev ||
> + p2mt == p2m_mmio_direct_nc ||
> + p2mt == p2m_mmio_direct_c );
Could you introduce p2m_is_mmio(...) in p2m.h?
> return p2m_insert_mapping(d, gfn, nr, mfn, p2mt);
> }
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-10 17:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 23:20 [Xen-devel] [PATCH v3 0/5] iomem memory policy Stefano Stabellini
2019-06-18 23:20 ` [Xen-devel] [PATCH v3 1/5] xen: add a p2mt parameter to map_mmio_regions Stefano Stabellini
2019-06-19 7:42 ` Jan Beulich
2019-08-06 23:05 ` Stefano Stabellini
2019-07-10 17:17 ` Julien Grall [this message]
2019-08-06 23:38 ` Stefano Stabellini
2019-08-07 10:35 ` Julien Grall
2019-06-18 23:20 ` [Xen-devel] [PATCH v3 2/5] xen: extend XEN_DOMCTL_memory_mapping to handle memory policy Stefano Stabellini
2019-06-19 7:48 ` Jan Beulich
2019-08-06 23:57 ` Stefano Stabellini
2019-07-10 17:39 ` Julien Grall
2019-08-06 23:42 ` Stefano Stabellini
2019-06-18 23:20 ` [Xen-devel] [PATCH v3 3/5] libxc: introduce xc_domain_mem_map_policy Stefano Stabellini
2019-06-18 23:20 ` [Xen-devel] [PATCH v3 4/5] libxl/xl: add memory policy option to iomem Stefano Stabellini
2019-07-10 19:02 ` Julien Grall
2019-06-18 23:20 ` [Xen-devel] [PATCH v3 5/5] xen/arm: clarify the support status of iomem configurations Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5749e2-883d-70f5-b953-7381d9207b0b@arm.com \
--to=julien.grall@arm.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=sstabellini@kernel.org \
--cc=stefanos@xilinx.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.