From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B5DC2D0C6 for ; Wed, 11 Dec 2019 21:19:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A50B221556 for ; Wed, 11 Dec 2019 21:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726708AbfLKVTY (ORCPT ); Wed, 11 Dec 2019 16:19:24 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:41164 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbfLKVTY (ORCPT ); Wed, 11 Dec 2019 16:19:24 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1if9OA-0055Xn-Mq; Wed, 11 Dec 2019 22:19:18 +0100 Message-ID: <5d82fa60fa8170c6a41e87650785ba008da11826.camel@sipsolutions.net> Subject: Re: iwlwifi warnings in 5.5-rc1 From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , Jens Axboe , Emmanuel Grumbach , Luca Coelho , "Jason A. Donenfeld" , Steve French Cc: "linux-wireless@vger.kernel.org" , Networking Date: Wed, 11 Dec 2019 22:19:17 +0100 In-Reply-To: <87d0cugbe5.fsf@toke.dk> References: <87o8wfeyx5.fsf@toke.dk> <87d0cugbe5.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2019-12-11 at 15:55 +0100, Toke Høiland-Jørgensen wrote: > Johannes Berg writes: > > > On Wed, 2019-12-11 at 15:09 +0100, Toke Høiland-Jørgensen wrote: > > > If we're doing this on a per-driver basis, let's make it a proper > > > NL80211_EXT_FEATURE and expose it to userspace; that way users can at > > > least discover if it's supported on their device. I can send a patch > > > adding that... > > > > Sure. Just didn't get to that yet, but if you want to send a patch > > that's very welcome. I have to run out now, will be back in the evening > > at most. > > Patch here (for those not following linux-wireless): > https://patchwork.kernel.org/project/linux-wireless/list/?series=215107 Thanks! Maybe I should roll that into a single patch so it's actually easier to apply as a bugfix while keeping ath10k on AQL for 5.5, otherwise it could be argued that the ath10k patch is a feature for -next ... > > > Maybe we should untangle this from airtime_flags completely, since if we > > > just use the flags people could conceivably end up disabling it by > > > mistake, couldn't they? > > > > Yes, that sounds like a good plan, now I was wondering why it's there > > anyway. > > Convenience, I think :) :) johannes