From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ABF9C433F5 for ; Fri, 30 Sep 2022 08:29:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230427AbiI3I3t (ORCPT ); Fri, 30 Sep 2022 04:29:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231177AbiI3I3o (ORCPT ); Fri, 30 Sep 2022 04:29:44 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D450A2E0; Fri, 30 Sep 2022 01:29:41 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id DBDDF66022BC; Fri, 30 Sep 2022 09:29:38 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664526579; bh=y6RFqj7OJORRXrnb91N0f5NRhH96ycPGBPqgs9CRszM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FZ9bIHSz/43QdUTsGvBEzHW6mnFUtEEz0KO/qxizXK9d5tF4HJItP32twNajrsf59 Q9/v9IyNIamQnKAvzOJU1gOMl4e3yDoPZSRBQ9INzaIqpFpPQRGvj3iGmAz+Nb5A6F Jds+2BOcDcOVyt8bPUGx48pg1tauP6enYCmCSOKmIq8SapvcsjHcSBxCZev2igycWh VJD/AdLG1vgd9gkIRyHzhLYJIVN8c+k4xcY6W2vBOotY09eO+ARBXAc5HyYY13bBYW DkhBdIz2ntt43qz3KzyCeNwU+DgWGzX0M9s0xEUDh1MAgLxX0Dtc21EM+rFBfxz8wf Hceb3VQhotWrg== Message-ID: <5d8af9a1-3afc-bd69-8f34-164284a452c2@collabora.com> Date: Fri, 30 Sep 2022 10:29:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 08/10] clk: mediatek: clk-mt8195-topckgen: Drop univplls from mfg mux parents To: =?UTF-8?B?TWFuZHlKSCBMaXUgKOWKieS6uuWDlik=?= , "matthias.bgg@gmail.com" Cc: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mturquette@baylibre.com" , "wenst@chromium.org" , "jose.exposito89@gmail.com" , "drinkcat@chromium.org" , "devicetree@vger.kernel.org" , "sboyd@kernel.org" , =?UTF-8?B?Q2h1bi1KaWUgQ2hlbiAo6Zmz5rWa5qGAKQ==?= , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?B?TWlsZXMgQ2hlbiAo6Zmz5rCR5qi6KQ==?= , =?UTF-8?B?V2VpeWkgTHUgKOWRguWogeWEgCk=?= , "linux-clk@vger.kernel.org" , =?UTF-8?B?UmV4LUJDIENoZW4gKOmZs+afj+i+sCk=?= , "krzysztof.kozlowski+dt@linaro.org" , "nfraprado@collabora.com" References: <20220927101128.44758-1-angelogioacchino.delregno@collabora.com> <20220927101128.44758-9-angelogioacchino.delregno@collabora.com> <79490e834466628a1b92e51f65aeb9e9ce82ddce.camel@mediatek.com> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <79490e834466628a1b92e51f65aeb9e9ce82ddce.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 30/09/22 07:59, MandyJH Liu (劉人僖) ha scritto: > On Tue, 2022-09-27 at 12:11 +0200, AngeloGioacchino Del Regno wrote: >> These PLLs are conflicting with GPU rates that can be generated by >> the GPU-dedicated MFGPLL and would require a special clock handler >> to be used, for very little and ignorable power consumption benefits. >> Also, we're in any case unable to set the rate of these PLLs to >> something else that is sensible for this task, so simply drop them: >> this will make the GPU to be clocked exclusively from MFGPLL for >> "fast" rates, while still achieving the right "safe" rate during >> PLL frequency locking. >> >> Signed-off-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> Reviewed-by: Chen-Yu Tsai >> --- >> drivers/clk/mediatek/clk-mt8195-topckgen.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/clk/mediatek/clk-mt8195-topckgen.c >> b/drivers/clk/mediatek/clk-mt8195-topckgen.c >> index 4dde23bece66..8cbab5ca2e58 100644 >> --- a/drivers/clk/mediatek/clk-mt8195-topckgen.c >> +++ b/drivers/clk/mediatek/clk-mt8195-topckgen.c >> @@ -298,11 +298,14 @@ static const char * const ipu_if_parents[] = { >> "mmpll_d4" >> }; >> >> +/* >> + * MFG can be also parented to "univpll_d6" and "univpll_d7": >> + * these have been removed from the parents list to let us >> + * achieve GPU DVFS without any special clock handlers. >> + */ >> static const char * const mfg_parents[] = { >> "clk26m", >> - "mainpll_d5_d2", >> - "univpll_d6", >> - "univpll_d7" >> + "mainpll_d5_d2" >> }; >> >> static const char * const camtg_parents[] = { > There might be a problem here. Since the univpll_d6 and univpll_d7 are > available parents in hardware design and they can be selected other > than kernel stage, like bootloader, the clk tree listed in clk_summary > cannot show the real parent-child relationship in such case. I agree about that, but the clock framework will change the parent to the "best parent" in that case... this was done to avoid writing complicated custom clock ops just for that one. This issue is present only on MT8195, so it can be safely solved this way, at least for now. Should this become a thing on another couple SoCs, it'll then make sense to write custom clock ops just for the MFG. Regards, Angelo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ACE01C433FE for ; Fri, 30 Sep 2022 08:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hV9Ps25fTHr3ZbeAEfaEu5x/f49+7HeP0gPLve4Fn04=; b=f7tIgEHaK8jVc6 /CJFehNA6CxI+8qUoZ4fW98TywwE4PUghg2TDK0GiY80jIbFRiVAieCdTTqNxfgxF0frWZBl75FSV 84UMRET8rYozHzs0ZeIu+Qj3AohJfiM07ELrs/lyxhlKIAxOZWG8KIdMpa8p5Z9Ilza3YDV7oFBid 7RSI50OelFGFTOogTiisJ0rx9oD2wFX85kzIH5ySsc0enjX/l5WkFnWuslw7fU1EUCAjW1uoO9iev 8uvMjxchPpj+2uh7YBez07MS3VZ9ZTvy/nTHRNev4tXcBLRUgRAJ7h/WUVNjMTDfsUkScVbWXFbwr saP0gGfDoQzJrhqLoLYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeBOz-0084FN-NV; Fri, 30 Sep 2022 08:29:45 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeBOw-0084Db-83; Fri, 30 Sep 2022 08:29:43 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id DBDDF66022BC; Fri, 30 Sep 2022 09:29:38 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664526579; bh=y6RFqj7OJORRXrnb91N0f5NRhH96ycPGBPqgs9CRszM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FZ9bIHSz/43QdUTsGvBEzHW6mnFUtEEz0KO/qxizXK9d5tF4HJItP32twNajrsf59 Q9/v9IyNIamQnKAvzOJU1gOMl4e3yDoPZSRBQ9INzaIqpFpPQRGvj3iGmAz+Nb5A6F Jds+2BOcDcOVyt8bPUGx48pg1tauP6enYCmCSOKmIq8SapvcsjHcSBxCZev2igycWh VJD/AdLG1vgd9gkIRyHzhLYJIVN8c+k4xcY6W2vBOotY09eO+ARBXAc5HyYY13bBYW DkhBdIz2ntt43qz3KzyCeNwU+DgWGzX0M9s0xEUDh1MAgLxX0Dtc21EM+rFBfxz8wf Hceb3VQhotWrg== Message-ID: <5d8af9a1-3afc-bd69-8f34-164284a452c2@collabora.com> Date: Fri, 30 Sep 2022 10:29:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v3 08/10] clk: mediatek: clk-mt8195-topckgen: Drop univplls from mfg mux parents To: =?UTF-8?B?TWFuZHlKSCBMaXUgKOWKieS6uuWDlik=?= , "matthias.bgg@gmail.com" Cc: "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mturquette@baylibre.com" , "wenst@chromium.org" , "jose.exposito89@gmail.com" , "drinkcat@chromium.org" , "devicetree@vger.kernel.org" , "sboyd@kernel.org" , =?UTF-8?B?Q2h1bi1KaWUgQ2hlbiAo6Zmz5rWa5qGAKQ==?= , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?B?TWlsZXMgQ2hlbiAo6Zmz5rCR5qi6KQ==?= , =?UTF-8?B?V2VpeWkgTHUgKOWRguWogeWEgCk=?= , "linux-clk@vger.kernel.org" , =?UTF-8?B?UmV4LUJDIENoZW4gKOmZs+afj+i+sCk=?= , "krzysztof.kozlowski+dt@linaro.org" , "nfraprado@collabora.com" References: <20220927101128.44758-1-angelogioacchino.delregno@collabora.com> <20220927101128.44758-9-angelogioacchino.delregno@collabora.com> <79490e834466628a1b92e51f65aeb9e9ce82ddce.camel@mediatek.com> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: <79490e834466628a1b92e51f65aeb9e9ce82ddce.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220930_012942_518157_36696A65 X-CRM114-Status: GOOD ( 22.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMzAvMDkvMjIgMDc6NTksIE1hbmR5SkggTGl1ICjlionkurrlg5YpIGhhIHNjcml0dG86Cj4g T24gVHVlLCAyMDIyLTA5LTI3IGF0IDEyOjExICswMjAwLCBBbmdlbG9HaW9hY2NoaW5vIERlbCBS ZWdubyB3cm90ZToKPj4gVGhlc2UgUExMcyBhcmUgY29uZmxpY3Rpbmcgd2l0aCBHUFUgcmF0ZXMg dGhhdCBjYW4gYmUgZ2VuZXJhdGVkIGJ5Cj4+IHRoZSBHUFUtZGVkaWNhdGVkIE1GR1BMTCBhbmQg d291bGQgcmVxdWlyZSBhIHNwZWNpYWwgY2xvY2sgaGFuZGxlcgo+PiB0byBiZSB1c2VkLCBmb3Ig dmVyeSBsaXR0bGUgYW5kIGlnbm9yYWJsZSBwb3dlciBjb25zdW1wdGlvbiBiZW5lZml0cy4KPj4g QWxzbywgd2UncmUgaW4gYW55IGNhc2UgdW5hYmxlIHRvIHNldCB0aGUgcmF0ZSBvZiB0aGVzZSBQ TExzIHRvCj4+IHNvbWV0aGluZyBlbHNlIHRoYXQgaXMgc2Vuc2libGUgZm9yIHRoaXMgdGFzaywg c28gc2ltcGx5IGRyb3AgdGhlbToKPj4gdGhpcyB3aWxsIG1ha2UgdGhlIEdQVSB0byBiZSBjbG9j a2VkIGV4Y2x1c2l2ZWx5IGZyb20gTUZHUExMIGZvcgo+PiAiZmFzdCIgcmF0ZXMsIHdoaWxlIHN0 aWxsIGFjaGlldmluZyB0aGUgcmlnaHQgInNhZmUiIHJhdGUgZHVyaW5nCj4+IFBMTCBmcmVxdWVu Y3kgbG9ja2luZy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVn bm8gPAo+PiBhbmdlbG9naW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxhYm9yYS5jb20+Cj4+IFJldmll d2VkLWJ5OiBDaGVuLVl1IFRzYWkgPHdlbnN0QGNocm9taXVtLm9yZz4KPj4gLS0tCj4+ICAgZHJp dmVycy9jbGsvbWVkaWF0ZWsvY2xrLW10ODE5NS10b3Bja2dlbi5jIHwgOSArKysrKystLS0KPj4g ICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+Pgo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvbWVkaWF0ZWsvY2xrLW10ODE5NS10b3Bja2dlbi5jCj4+ IGIvZHJpdmVycy9jbGsvbWVkaWF0ZWsvY2xrLW10ODE5NS10b3Bja2dlbi5jCj4+IGluZGV4IDRk ZGUyM2JlY2U2Ni4uOGNiYWI1Y2EyZTU4IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2Nsay9tZWRp YXRlay9jbGstbXQ4MTk1LXRvcGNrZ2VuLmMKPj4gKysrIGIvZHJpdmVycy9jbGsvbWVkaWF0ZWsv Y2xrLW10ODE5NS10b3Bja2dlbi5jCj4+IEBAIC0yOTgsMTEgKzI5OCwxNCBAQCBzdGF0aWMgY29u c3QgY2hhciAqIGNvbnN0IGlwdV9pZl9wYXJlbnRzW10gPSB7Cj4+ICAgCSJtbXBsbF9kNCIKPj4g ICB9Owo+PiAgIAo+PiArLyoKPj4gKyAqIE1GRyBjYW4gYmUgYWxzbyBwYXJlbnRlZCB0byAidW5p dnBsbF9kNiIgYW5kICJ1bml2cGxsX2Q3IjoKPj4gKyAqIHRoZXNlIGhhdmUgYmVlbiByZW1vdmVk IGZyb20gdGhlIHBhcmVudHMgbGlzdCB0byBsZXQgdXMKPj4gKyAqIGFjaGlldmUgR1BVIERWRlMg d2l0aG91dCBhbnkgc3BlY2lhbCBjbG9jayBoYW5kbGVycy4KPj4gKyAqLwo+PiAgIHN0YXRpYyBj b25zdCBjaGFyICogY29uc3QgbWZnX3BhcmVudHNbXSA9IHsKPj4gICAJImNsazI2bSIsCj4+IC0J Im1haW5wbGxfZDVfZDIiLAo+PiAtCSJ1bml2cGxsX2Q2IiwKPj4gLQkidW5pdnBsbF9kNyIKPj4g KwkibWFpbnBsbF9kNV9kMiIKPj4gICB9Owo+PiAgIAo+PiAgIHN0YXRpYyBjb25zdCBjaGFyICog Y29uc3QgY2FtdGdfcGFyZW50c1tdID0gewo+IFRoZXJlIG1pZ2h0IGJlIGEgcHJvYmxlbSBoZXJl LiBTaW5jZSB0aGUgdW5pdnBsbF9kNiBhbmQgdW5pdnBsbF9kNyBhcmUKPiBhdmFpbGFibGUgcGFy ZW50cyBpbiBoYXJkd2FyZSBkZXNpZ24gYW5kIHRoZXkgY2FuIGJlIHNlbGVjdGVkIG90aGVyCj4g dGhhbiBrZXJuZWwgc3RhZ2UsIGxpa2UgYm9vdGxvYWRlciwgdGhlIGNsayB0cmVlIGxpc3RlZCBp biBjbGtfc3VtbWFyeQo+IGNhbm5vdCBzaG93IHRoZSByZWFsIHBhcmVudC1jaGlsZCByZWxhdGlv bnNoaXAgaW4gc3VjaCBjYXNlLgoKSSBhZ3JlZSBhYm91dCB0aGF0LCBidXQgdGhlIGNsb2NrIGZy YW1ld29yayB3aWxsIGNoYW5nZSB0aGUgcGFyZW50IHRvCnRoZSAiYmVzdCBwYXJlbnQiIGluIHRo YXQgY2FzZS4uLiB0aGlzIHdhcyBkb25lIHRvIGF2b2lkIHdyaXRpbmcgY29tcGxpY2F0ZWQKY3Vz dG9tIGNsb2NrIG9wcyBqdXN0IGZvciB0aGF0IG9uZS4KClRoaXMgaXNzdWUgaXMgcHJlc2VudCBv bmx5IG9uIE1UODE5NSwgc28gaXQgY2FuIGJlIHNhZmVseSBzb2x2ZWQgdGhpcyB3YXksCmF0IGxl YXN0IGZvciBub3cuCgpTaG91bGQgdGhpcyBiZWNvbWUgYSB0aGluZyBvbiBhbm90aGVyIGNvdXBs ZSBTb0NzLCBpdCdsbCB0aGVuIG1ha2Ugc2Vuc2UKdG8gd3JpdGUgY3VzdG9tIGNsb2NrIG9wcyBq dXN0IGZvciB0aGUgTUZHLgoKUmVnYXJkcywKQW5nZWxvCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=