From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1178C4BA1E for ; Wed, 26 Feb 2020 17:50:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F9AC20801 for ; Wed, 26 Feb 2020 17:50:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="UOxglwbV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F9AC20801 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 74FBE1662; Wed, 26 Feb 2020 18:50:05 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 74FBE1662 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1582739455; bh=16IH0sQEo2VsQQ2AHajjh4BS+4kehGgBMlTMnFcdIwY=; h=Subject:From:To:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UOxglwbVWflf4MAWqQQSu1gQ8CB1JA+KXwOovDwnuIXvFEQe/M1Vugccq1PKN2FiN yJpf8VCU+OmfcCRePxfiRGjVzGOsXklUopEqnIgzeMnXpmRwy6dxtyRJCmvdutd1Yj i+stSfDKxvh89HSSgv75B5G0+e3vw8ZsWtuXWWng= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CD87EF8014D; Wed, 26 Feb 2020 18:50:04 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1D809F8014E; Wed, 26 Feb 2020 18:50:03 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CA803F800AD for ; Wed, 26 Feb 2020 18:49:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CA803F800AD X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 09:49:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,488,1574150400"; d="scan'208";a="230510128" Received: from walkernx-mobl.amr.corp.intel.com ([10.254.14.92]) by fmsmga007.fm.intel.com with ESMTP; 26 Feb 2020 09:49:55 -0800 Message-ID: <5d98cb39bfdc4fe806fa5ec249f02dfc03d994ee.camel@linux.intel.com> Subject: Re: [PATCH 4/8] ASoC: soc-pcm: add dpcm_fe_dai_clean() From: Ranjani Sridharan To: Kuninori Morimoto , Mark Brown Date: Wed, 26 Feb 2020 09:49:55 -0800 In-Reply-To: <878skp97in.wl-kuninori.morimoto.gx@renesas.com> References: <87eeuh97k4.wl-kuninori.morimoto.gx@renesas.com> <878skp97in.wl-kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: Linux-ALSA X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 2020-02-26 at 15:40 +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > dpcm_fe_dai_close() and error case of dpcm_fe_dai_open() > need to do same cleanup operation. > To avoid duplicate code, this patch adds dpcm_fe_dai_clean() > and use it. > > Signed-off-by: Kuninori Morimoto > --- > sound/soc/soc-pcm.c | 30 ++++++++++++++++-------------- > 1 file changed, 16 insertions(+), 14 deletions(-) > > diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c > index 3686dda097e2..d578dbdfa846 100644 > --- a/sound/soc/soc-pcm.c > +++ b/sound/soc/soc-pcm.c > @@ -2978,14 +2978,11 @@ int soc_dpcm_runtime_update(struct > snd_soc_card *card) > return ret; > } > > -static int dpcm_fe_dai_close(struct snd_pcm_substream *fe_substream) > +static void dpcm_fe_dai_clean(struct snd_pcm_substream > *fe_substream) The series looks good to me, Morimoto-san. But a minor suggestion if you're doing a v2 to address other comments. Could you please change the name of the function above to dpcm_fe_dai_cleanup() instead? Reviewed-by: Ranjani Sridharan Thanks, Ranjani