From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26B26C433F5 for ; Fri, 14 Jan 2022 03:06:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238982AbiANDGL (ORCPT ); Thu, 13 Jan 2022 22:06:11 -0500 Received: from mail-sz.amlogic.com ([211.162.65.117]:63627 "EHLO mail-sz.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238972AbiANDGK (ORCPT ); Thu, 13 Jan 2022 22:06:10 -0500 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 14 Jan 2022 11:06:08 +0800 Message-ID: <5d99ac02-a246-5bcc-2ecb-371b0d193537@amlogic.com> Date: Fri, 14 Jan 2022 11:06:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 3/4] clk: meson: add DT documentation for emmc clock controller Content-Language: en-US To: Stephen Boyd , Jerome Brunet , Kevin Hilman , Michael Turquette , Neil Armstrong , Rob Herring , CC: Martin Blumenstingl , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , References: <20220113115745.45826-1-liang.yang@amlogic.com> <20220113115745.45826-4-liang.yang@amlogic.com> <20220113212957.768FFC36AE3@smtp.kernel.org> From: Liang Yang In-Reply-To: <20220113212957.768FFC36AE3@smtp.kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, Thanks for your quick response. On 2022/1/14 5:29, Stephen Boyd wrote: > [ EXTERNAL EMAIL ] > > Quoting Liang Yang (2022-01-13 03:57:44) >> Document the MMC sub clock controller driver, the potential consumer >> of this driver is MMC or NAND. Also add four clock bindings IDs which >> provided by this driver. >> >> Signed-off-by: Liang Yang >> --- >> .../bindings/clock/amlogic,mmc-clkc.yaml | 64 +++++++++++++++++++ >> include/dt-bindings/clock/amlogic,mmc-clkc.h | 14 ++++ >> 2 files changed, 78 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >> create mode 100644 include/dt-bindings/clock/amlogic,mmc-clkc.h >> >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >> new file mode 100644 >> index 000000000000..a274c3d5fc2e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >> @@ -0,0 +1,64 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/amlogic,mmc-clkc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic MMC Sub Clock Controller Driver Device Tree Bindings >> + >> +maintainers: >> + - jianxin.pan@amlogic.com >> + - liang.yang@amlogic.com >> + >> +properties: >> + compatible: >> + enum: >> + - "amlogic,axg-mmc-clkc", "syscon" > > Why is it a syscon? The register documented by reg is shared with SD/eMMC controller port C, and it need to be ops on NFC driver. > > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C65D4C433F5 for ; Fri, 14 Jan 2022 03:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9X9pu8nFMYmFrbQBgK64hvGjV8qm7xTyNiieFVL3ibU=; b=pYcO4Shlk8Wz9m 1IufZ7UPkLk1tIkpeqKWpzdzhrvGDJUeHfQO6uPQRd4A8ts2CfQjoYIv42dnZiEppi42TPeHKvL4Q QeM6YRAgYmWF6ikbpqtHYDmaqYmnJCTpD47djx7+IkKhTNNMSglL+QgmtHUmPKFq0nP929lip1Bdq LryrXnsgg6nlIgW6LmxUjKF5XaYr1cOxK6dj4K18vPI2xtbZhJTGWKpEffZJj2s8Oki1jRaw9MtBm 7LM3iBI59eLst0YFK3Gf+D8idaVVDTHJLQoncm4E/hCqnSlo0M03rn/SUX0dxxJIMKJUup25Pg7Qf HHWBc9hu2qHT8+vbjMvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8Cv2-007Yls-R8; Fri, 14 Jan 2022 03:06:24 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8Cuq-007YkF-Bw; Fri, 14 Jan 2022 03:06:13 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 14 Jan 2022 11:06:08 +0800 Message-ID: <5d99ac02-a246-5bcc-2ecb-371b0d193537@amlogic.com> Date: Fri, 14 Jan 2022 11:06:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 3/4] clk: meson: add DT documentation for emmc clock controller Content-Language: en-US To: Stephen Boyd , Jerome Brunet , Kevin Hilman , Michael Turquette , Neil Armstrong , Rob Herring , CC: Martin Blumenstingl , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , References: <20220113115745.45826-1-liang.yang@amlogic.com> <20220113115745.45826-4-liang.yang@amlogic.com> <20220113212957.768FFC36AE3@smtp.kernel.org> From: Liang Yang In-Reply-To: <20220113212957.768FFC36AE3@smtp.kernel.org> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_190612_442330_461A2D09 X-CRM114-Status: UNSURE ( 8.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Stephen, Thanks for your quick response. On 2022/1/14 5:29, Stephen Boyd wrote: > [ EXTERNAL EMAIL ] > > Quoting Liang Yang (2022-01-13 03:57:44) >> Document the MMC sub clock controller driver, the potential consumer >> of this driver is MMC or NAND. Also add four clock bindings IDs which >> provided by this driver. >> >> Signed-off-by: Liang Yang >> --- >> .../bindings/clock/amlogic,mmc-clkc.yaml | 64 +++++++++++++++++++ >> include/dt-bindings/clock/amlogic,mmc-clkc.h | 14 ++++ >> 2 files changed, 78 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >> create mode 100644 include/dt-bindings/clock/amlogic,mmc-clkc.h >> >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >> new file mode 100644 >> index 000000000000..a274c3d5fc2e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >> @@ -0,0 +1,64 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/amlogic,mmc-clkc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic MMC Sub Clock Controller Driver Device Tree Bindings >> + >> +maintainers: >> + - jianxin.pan@amlogic.com >> + - liang.yang@amlogic.com >> + >> +properties: >> + compatible: >> + enum: >> + - "amlogic,axg-mmc-clkc", "syscon" > > Why is it a syscon? The register documented by reg is shared with SD/eMMC controller port C, and it need to be ops on NFC driver. > > . _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19B83C433EF for ; Fri, 14 Jan 2022 03:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ecVnO689o6xeXsb6AcCTpvdkfyXE0CxoWU0LmFSIe3g=; b=L44oCUihUV9/7b g8hNVu1LpU1CUwykx08C1ETdXe8ilmZgGVC2OlV7NtcPDWJnoMh6st1FrTf2t5Gc+JyO7wjYBCygu goDyBxkVAW8VkNtpc4eanjBeO2y6jzls7E250nKCJ9U7WVHvfBlF6ygNoVY2JT/ZeMcOJGR/XVXFk JB92yz0W8p7qQdZiQtO7iJ5yX9WYYd3x1nnMRsSwdArUiCzOOvbpoLtVsFRrGaoTlkKxREeqOmXv0 DKyByB4V8Eyu2o8coGveBBZmWRLYS258Qqi+LFMQdTOv16BTXsBZGzM5IQ7EXiF1MGpYo4OwD9p5e 1V/sxzRIS01/hWX7zpAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8Cuu-007YlC-Cv; Fri, 14 Jan 2022 03:06:16 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8Cuq-007YkF-Bw; Fri, 14 Jan 2022 03:06:13 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 14 Jan 2022 11:06:08 +0800 Message-ID: <5d99ac02-a246-5bcc-2ecb-371b0d193537@amlogic.com> Date: Fri, 14 Jan 2022 11:06:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 3/4] clk: meson: add DT documentation for emmc clock controller Content-Language: en-US To: Stephen Boyd , Jerome Brunet , Kevin Hilman , Michael Turquette , Neil Armstrong , Rob Herring , CC: Martin Blumenstingl , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , References: <20220113115745.45826-1-liang.yang@amlogic.com> <20220113115745.45826-4-liang.yang@amlogic.com> <20220113212957.768FFC36AE3@smtp.kernel.org> From: Liang Yang In-Reply-To: <20220113212957.768FFC36AE3@smtp.kernel.org> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_190612_442330_461A2D09 X-CRM114-Status: UNSURE ( 8.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stephen, Thanks for your quick response. On 2022/1/14 5:29, Stephen Boyd wrote: > [ EXTERNAL EMAIL ] > > Quoting Liang Yang (2022-01-13 03:57:44) >> Document the MMC sub clock controller driver, the potential consumer >> of this driver is MMC or NAND. Also add four clock bindings IDs which >> provided by this driver. >> >> Signed-off-by: Liang Yang >> --- >> .../bindings/clock/amlogic,mmc-clkc.yaml | 64 +++++++++++++++++++ >> include/dt-bindings/clock/amlogic,mmc-clkc.h | 14 ++++ >> 2 files changed, 78 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >> create mode 100644 include/dt-bindings/clock/amlogic,mmc-clkc.h >> >> diff --git a/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >> new file mode 100644 >> index 000000000000..a274c3d5fc2e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/clock/amlogic,mmc-clkc.yaml >> @@ -0,0 +1,64 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/clock/amlogic,mmc-clkc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic MMC Sub Clock Controller Driver Device Tree Bindings >> + >> +maintainers: >> + - jianxin.pan@amlogic.com >> + - liang.yang@amlogic.com >> + >> +properties: >> + compatible: >> + enum: >> + - "amlogic,axg-mmc-clkc", "syscon" > > Why is it a syscon? The register documented by reg is shared with SD/eMMC controller port C, and it need to be ops on NFC driver. > > . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel