From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8286C433F5 for ; Tue, 21 Dec 2021 14:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238633AbhLUOso (ORCPT ); Tue, 21 Dec 2021 09:48:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:45971 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235023AbhLUOsl (ORCPT ); Tue, 21 Dec 2021 09:48:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640098121; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Po1CD9ebNb27oFA4NxD8Jv9jBdePgnFKbWG3JPgxruU=; b=Iifd7q+rzho7xEjjiUrVhd1KuGz9uqWHUbZHuNw9p10CdCfARc05BNnuMPuIuUnQiCa8Hj mNfO9/DpiztVhsv/7WzJVPOykmCLEqJdLQOGL98sP5BD7KcAoRySvpM3matePObFfDDBW5 snVkCcMwzI2TA7bQB73hIOUt1Gt/ljE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-383-PymR-d4fMHugEDmI0qe0bw-1; Tue, 21 Dec 2021 09:48:40 -0500 X-MC-Unique: PymR-d4fMHugEDmI0qe0bw-1 Received: by mail-wm1-f70.google.com with SMTP id n31-20020a05600c501f00b00345b15f5e15so851619wmr.3 for ; Tue, 21 Dec 2021 06:48:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=Po1CD9ebNb27oFA4NxD8Jv9jBdePgnFKbWG3JPgxruU=; b=QwNzWZz+nga4eRYekSZ+kdTNO2Tb4aR4lcDok393gDTAh4uV8UQNGg1MBO3LqQHbAL VlvvDEtY6tTK3qapVf1ISBflSMXrf2qXDtWnxDrd48AmgHVCyzNqKL2SEYl2OfvToT6Z 18NkNj4b/dJweXw6KLNHvP1x8YPngnj8V+DdcwOpW3Q9cpYxsG12lupzzz8iwvPSWyvq FNzVVBxlPfvONZou8295uvKde0PVpEaCHIWabwR33rz4I6QxgDAUtj+XC7ElN7nmwZsI fhhSxbBnXjr4Lkl1BAZMxJmgl9BptbJE7cCKpHUmOp3YwIqbuOXCsFf9lDt+TiV/6RY+ OJOg== X-Gm-Message-State: AOAM530tfHI3xzuvtVZMMKuOAlEMRSVXRyL7kNtGZqEb32TaOcZiim0e SJS15Elyo8wt483Vs10aqPeP0CU6lLrqSQXN8Wp6RBvZ4Y3hD7CS1xO3tMFUlwCxt1fl0gz2GsL T/4WIWThSOdR5 X-Received: by 2002:adf:aa9a:: with SMTP id h26mr2867471wrc.437.1640098118243; Tue, 21 Dec 2021 06:48:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJwqpbyheZzEJO8vD1Cvx8JorX9wdzQV9iphsDeC1LYVbC3LBGcZc5m+cIVA4K0tl4CHjTdZqQ== X-Received: by 2002:adf:aa9a:: with SMTP id h26mr2867459wrc.437.1640098118095; Tue, 21 Dec 2021 06:48:38 -0800 (PST) Received: from ?IPv6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id l12sm1898081wmq.2.2021.12.21.06.48.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Dec 2021 06:48:37 -0800 (PST) Reply-To: eric.auger@redhat.com Subject: Re: [kvm-unit-tests PATCH] scripts/arch-run: Mark migration tests as SKIP if ncat is not available To: Thomas Huth , Paolo Bonzini , kvm@vger.kernel.org, Laurent Vivier , Andrew Jones Cc: kvm-ppc@vger.kernel.org References: <20211221092130.444225-1-thuth@redhat.com> From: Eric Auger Message-ID: <5da99523-9102-ae64-52e8-f081df5976bb@redhat.com> Date: Tue, 21 Dec 2021 15:48:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi, On 12/21/21 11:12 AM, Thomas Huth wrote: > On 21/12/2021 10.58, Paolo Bonzini wrote: >> On 12/21/21 10:21, Thomas Huth wrote: >>> Instead of failing the tests, we should rather skip them if ncat is >>> not available. >>> While we're at it, also mention ncat in the README.md file as a >>> requirement for the migration tests. >>> >>> Resolves: https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/issues/4 >>> Signed-off-by: Thomas Huth >> >> I would rather remove the migration tests.  There's really no reason >> for them, the KVM selftests in the Linux tree are much better: they >> can find migration bugs deterministically and they are really really >> easy to debug.  The only disadvantage is that they are harder to write. > > I disagree: We're testing migration with QEMU here - the KVM selftests > don't include QEMU, so we'd lose some test coverage here. > And at least the powerpc/sprs.c test helped to find some nasty bugs in > the past already. I do agree. The ITS migration tests were good reproducer for upstream bugs. Thanks Eric > >  Thomas > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Auger Date: Tue, 21 Dec 2021 14:48:36 +0000 Subject: Re: [kvm-unit-tests PATCH] scripts/arch-run: Mark migration tests as SKIP if ncat is not available Message-Id: <5da99523-9102-ae64-52e8-f081df5976bb@redhat.com> List-Id: References: <20211221092130.444225-1-thuth@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Thomas Huth , Paolo Bonzini , kvm@vger.kernel.org, Laurent Vivier , Andrew Jones Cc: kvm-ppc@vger.kernel.org Hi, On 12/21/21 11:12 AM, Thomas Huth wrote: > On 21/12/2021 10.58, Paolo Bonzini wrote: >> On 12/21/21 10:21, Thomas Huth wrote: >>> Instead of failing the tests, we should rather skip them if ncat is >>> not available. >>> While we're at it, also mention ncat in the README.md file as a >>> requirement for the migration tests. >>> >>> Resolves: https://gitlab.com/kvm-unit-tests/kvm-unit-tests/-/issues/4 >>> Signed-off-by: Thomas Huth >> >> I would rather remove the migration tests.  There's really no reason >> for them, the KVM selftests in the Linux tree are much better: they >> can find migration bugs deterministically and they are really really >> easy to debug.  The only disadvantage is that they are harder to write. > > I disagree: We're testing migration with QEMU here - the KVM selftests > don't include QEMU, so we'd lose some test coverage here. > And at least the powerpc/sprs.c test helped to find some nasty bugs in > the past already. I do agree. The ITS migration tests were good reproducer for upstream bugs. Thanks Eric > >  Thomas >