All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Ahern <dsahern@kernel.org>,
	davem@davemloft.net, netdev@vger.kernel.org
Cc: idosch@mellanox.com, David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions
Date: Sun, 28 Apr 2019 08:06:29 -0700	[thread overview]
Message-ID: <5db90ce0-d24a-4317-5d68-5169d496609a@gmail.com> (raw)
In-Reply-To: <20190428022734.21965-1-dsahern@kernel.org>



On 4/27/19 7:27 PM, David Ahern wrote:
> From: David Ahern <dsahern@gmail.com>
> 
> This series moves IPv4 pcpu cached routes from fib_nh to fib_nh_common
> to make the caches avaialable for IPv6 nexthops (fib6_nh) with IPv4
> routes. This allows a fib6_nh struct to be used with both IPv4 and
> and IPv6 routes.
> 
> In addition pcpu caches and exception entries for IPv6 routes are
> moved from fib6_info to fib6_nh since they are really a function of
> the device and gateway. During the move of each, functions are
> refactored such that the core logic is in new helpers that take
> a fib6_nh versus a fib6_info.
>

I would prefer we fix the existing bugs before moving the code around,
otherwise stable teams work is going to be tough.

We have dozens of syzbot reports involving all this stuff.


  parent reply	other threads:[~2019-04-28 15:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-28  2:27 [PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions David Ahern
2019-04-28  2:27 ` [PATCH v2 net-next 1/7] ipv4: Move cached routes to fib_nh_common David Ahern
2019-04-28  2:27 ` [PATCH v2 net-next 2/7] ipv4: Pass fib_nh_common to rt_cache_route David Ahern
2019-04-28  2:27 ` [PATCH v2 net-next 3/7] ipv4: Move exception bucket to nh_common David Ahern
2019-04-28  2:27 ` [PATCH v2 net-next 4/7] ipv6: Move pcpu cached routes to fib6_nh David Ahern
2019-04-28  2:27 ` [PATCH v2 net-next 5/7] ipv6: Refactor fib6_drop_pcpu_from David Ahern
2019-04-28  2:27 ` [PATCH v2 net-next 6/7] ipv6: Refactor exception functions David Ahern
2019-04-28  2:27 ` [PATCH v2 net-next 7/7] ipv6: Move exception bucket to fib6_nh David Ahern
2019-04-28 15:06 ` Eric Dumazet [this message]
2019-04-28 17:53   ` [PATCH v2 net-next 0/7] ipv4 ipv6: Move location of pcpu route cache and exceptions Alexei Starovoitov
2019-04-28 20:54     ` David Ahern
2019-04-28 20:41   ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5db90ce0-d24a-4317-5d68-5169d496609a@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=idosch@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.