From: Stephen Boyd <swboyd@chromium.org>
To: Andy Gross <agross@kernel.org>,
Kiran Gunda <kgunda@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
rnayak@codeaurora.org
Cc: Kiran Gunda <kgunda@codeaurora.org>
Subject: Re: [PATCH V1] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l
Date: Mon, 04 Nov 2019 09:52:10 -0800 [thread overview]
Message-ID: <5dc0654b.1c69fb81.5f215.8c24@mx.google.com> (raw)
In-Reply-To: <1572591543-15501-1-git-send-email-kgunda@codeaurora.org>
Quoting Kiran Gunda (2019-10-31 23:59:03)
> Add the compatibles and PMIC ids for pm6150 and pm6150l PMICs
> found on SC7180 based platforms.
>
> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
> ---
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 2 ++
> drivers/mfd/qcom-spmi-pmic.c | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> index 1437062..b5fc64e 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> @@ -32,6 +32,8 @@ Required properties:
> "qcom,pm8998",
> "qcom,pmi8998",
> "qcom,pm8005",
> + "qcom,pm6150",
> + "qcom,pm6150l",
Please sort on compatible string
> or generalized "qcom,spmi-pmic".
> - reg: Specifies the SPMI USID slave address for this device.
> For more information see:
> diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
> index e8fe705..d916aa8 100644
> --- a/drivers/mfd/qcom-spmi-pmic.c
> +++ b/drivers/mfd/qcom-spmi-pmic.c
> @@ -34,6 +34,8 @@
> #define PM8998_SUBTYPE 0x14
> #define PMI8998_SUBTYPE 0x15
> #define PM8005_SUBTYPE 0x18
> +#define PM6150L_SUBTYPE 0x27
> +#define PM6150_SUBTYPE 0x28
And on macro name here.
>
> static const struct of_device_id pmic_spmi_id_table[] = {
> { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE },
> @@ -53,6 +55,8 @@
> { .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE },
> { .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE },
> { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE },
> + { .compatible = "qcom,pm6150l", .data = (void *)PM6150L_SUBTYPE },
> + { .compatible = "qcom,pm6150", .data = (void *)PM6150_SUBTYPE },
And compatible here.
> { }
next prev parent reply other threads:[~2019-11-04 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 6:59 [PATCH V1] mfd: qcom-spmi-pmic: Add support for pm6150 and pm6150l Kiran Gunda
2019-11-04 17:52 ` Stephen Boyd [this message]
2019-11-05 5:14 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dc0654b.1c69fb81.5f215.8c24@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.