From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D6BC48BE5 for ; Tue, 15 Jun 2021 03:36:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B454613D9 for ; Tue, 15 Jun 2021 03:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbhFODi6 (ORCPT ); Mon, 14 Jun 2021 23:38:58 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:6500 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229609AbhFODi6 (ORCPT ); Mon, 14 Jun 2021 23:38:58 -0400 Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G3v7909DlzZhJF; Tue, 15 Jun 2021 11:33:57 +0800 (CST) Received: from dggema759-chm.china.huawei.com (10.1.198.201) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Tue, 15 Jun 2021 11:36:51 +0800 Received: from [10.174.178.31] (10.174.178.31) by dggema759-chm.china.huawei.com (10.1.198.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 15 Jun 2021 11:36:50 +0800 Subject: Re: [PATCH] generic/103: leave more space for f2fs To: Eryu Guan CC: , References: <20210611112211.1408767-1-sunke32@huawei.com> <20210611112211.1408767-2-sunke32@huawei.com> From: Sun Ke Message-ID: <5dc9bead-85e7-a748-b427-c9f48e1941c1@huawei.com> Date: Tue, 15 Jun 2021 11:36:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.31] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggema759-chm.china.huawei.com (10.1.198.201) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org ÔÚ 2021/6/13 22:44, Eryu Guan дµÀ: > On Fri, Jun 11, 2021 at 07:22:10PM +0800, Sun Ke wrote: >> It failed on f2fs: >> QA output created by 103 >> +fallocate: No space left on device >> Silence is golden. >> ... >> >> Try to leave ~512KB, but during the fallocate, f2fs will be filled. >> Provide error prompt: "fallocate: No space left on device". >> >> Leave more space for f2fs. > > And this also could be a bug in f2fs, that couldn't fallocate enough > space when free space is larger than request size. > > I think the whole patchset needs review from f2fs folks. > > Thanks, > Eryu I have cc linux-f2fs-devel@lists.sourceforge.net. Thanks, Sun Ke > >> >> Signed-off-by: Sun Ke >> --- >> I add some test code >> + df >> avail=`_get_available_space $SCRATCH_MNT` >> + echo "avail = ${avail}" >> filesizekb=$((avail / 1024 - 512)) >> + echo "filesizekb = ${filesizekb}" >> $XFS_IO_PROG -fc "falloc 0 ${filesizekb}k" $file >> + df >> } >> >> f2fs: >> QA output created by 103 >> +Filesystem 1K-blocks Used Available Use% Mounted on >> ... >> +/dev/sdb 12580864 553292 12027572 5% /mnt/scratch >> +avail = 12316233728 >> +filesizekb = 12027060 >> +fallocate: No space left on device >> +Filesystem 1K-blocks Used Available Use% Mounted on >> ... >> +/dev/sdb 12580864 12580864 0 100% /mnt/scratch >> Silence is golden. >> >> xfs: >> QA output created by 103 >> +Filesystem 1K-blocks Used Available Use% Mounted on >> ... >> +/dev/sdb 12572672 120828 12451844 1% /mnt/scratch >> +avail = 12750688256 >> +filesizekb = 12451332 >> +Filesystem 1K-blocks Used Available Use% Mounted on >> ... >> +/dev/sdb 12572672 12572160 512 100% /mnt/scratch >> Silence is golden. >> >> f2fs: >> QA output created by 103 >> +Filesystem 1K-blocks Used Available Use% Mounted on >> ... >> +/dev/sdb 12319880 41048 11633304 1% /mnt/scratch >> +avail = 11912503296 >> +filesizekb = 11632792 >> +Filesystem 1K-blocks Used Available Use% Mounted on >> ... >> +/dev/sdb 12319880 11673844 508 100% /mnt/scratch >> Silence is golden. >> >> after change (f2fs) >> QA output created by 103 >> Filesystem 1K-blocks Used Available Use% Mounted on >> ... >> /dev/sdb 12580864 12580396 468 100% /tmp/scratch >> Silence is golden. >> >> tests/generic/103 | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/tests/generic/103 b/tests/generic/103 >> index b22b0159623e..dfce3870781c 100755 >> --- a/tests/generic/103 >> +++ b/tests/generic/103 >> @@ -40,10 +40,18 @@ rm -f $seqres.full >> _consume_freesp() >> { >> file=$1 >> + leave=512 >> + >> + # Try to leave ~512KB, but during the fallocate, f2fs will be filled. >> + # Provide error prompt: "fallocate: No space left on device". Leave >> + # more space for f2fs. >> + if [ $FSTYP == "f2fs" ]; then >> + leave=12288 >> + fi >> >> # consume nearly all available space (leave ~512kB) >> avail=`_get_available_space $SCRATCH_MNT` >> - filesizekb=$((avail / 1024 - 512)) >> + filesizekb=$((avail / 1024 - $leave)) >> $XFS_IO_PROG -fc "falloc 0 ${filesizekb}k" $file >> } >> >> -- >> 2.25.4 > . >