From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EF1EECAAD3 for ; Wed, 31 Aug 2022 07:35:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=aT+Bhe93MziLpk/IEL5hADzCfdoYBUcG7wS5CcRa4EU=; b=NBlzQFrxnqyidJLKBox7TuFr5y Kmru3GB7OdeRAnkxKb+AXiH7tQVyzHHnizp0zlPLHN2gyXu7Sk5M0fFEP1duYVllZWWr78P02LvKR vadh6I8GeCFpC3ZXwNV27moS902Zx9vcO/RtoeXDGT8Y+m9T8EUv2AVLk/fmHeAqsOiipd+Cu1Y/D 5/K6Y7TEJyPZ9FyCremoNPU6yH9uhyZz68S1u1Dwcg9LUtBThBv1YgbwQLtt60VtsBSa4RBniiTNL grAKsWVc8WExtB9lRMANmRsjAbM8J9rvPw1tjRbuGlLhOF0EmWONb5pEeRJ+1nMLFks5h+OofL4Cu 0b5Iboaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTIEP-004c5p-Sa; Wed, 31 Aug 2022 07:33:50 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTIEM-004c3k-9U for linux-arm-kernel@lists.infradead.org; Wed, 31 Aug 2022 07:33:47 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id 5EFAA580703 for ; Wed, 31 Aug 2022 03:33:45 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute3.internal (MEProxy); Wed, 31 Aug 2022 03:33:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1661931225; x=1661934825; bh=1aenuxa+Hq QYGXxzO4SjnMcGBTiII3Nc36j45LlXuHk=; b=lHOKYmRGVC7Njohzd5Ggk4S/P+ 6n3/TvgcPvgXYZ1kt2POIlxLK711vLpgW3ncWxoxyiSmfkRGLxDGhClYJ59Gg4jh 6NKffsZbwTvGQ9fYF/YVMDQAfaBl1IBuIlhLViA4qorRz7XBd5diKy0jHMpItG6O dgsca3ljwTedYA2Y8FByo8rxFvytgwEyl4Ee6/8BTlhMgemPguZvR2MP1kzH7Gm4 8BKGWVv8QZAX+dKPbYabh72Ku/mzW1lMT8yDu5AzeVKi6dAsIfjrGYwyVVhOC7Af D448x41oG3AfTte5aouPd/h2l8F6Idrsa6NYHnBVegX/LgcosCu6fbOISBzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= i56a14606.fm1; t=1661931225; x=1661934825; bh=1aenuxa+HqQYGXxzO4 SjnMcGBTiII3Nc36j45LlXuHk=; b=hPZuM2wbSzom+zET0xC0FFgssGuiQ5gbxG 1xqcsPY8+E7BRAN3Fgz7LJXv5UZyfgE/mlpx0PkgW+On8m8PgeCpc0Gqe8eFG59O qHcM9lvYa4v0i6rFCgcUzNSWDIe1E2/+gzJR1iKRHzfE2Z3WlpFb8qSTc68EvZnc mF1VogPr3VDRb1lxfpG5YRKnv+UJl2jOYuEAg0fRbaVSJOtJxurzRT6NwBrkcO1W tK2ZW5zJ5WnJe/apCuYgrkTdbvMLZ8lMSu+y9jEnFi5af91/KNLlpvX/evoeovNF KliIK5jhBtmG7qfZL7oRL/bT29FW/o5XP6ihsAtH8WFhYZCFl8Ug== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekgedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgesth dtredtreertdenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnuges rghrnhgusgdruggvqeenucggtffrrghtthgvrhhnpeffgeffuddtvdehffefleethfejje egvdelffejieegueetledvtedtudelgfdugfenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 18DF7B60083; Wed, 31 Aug 2022 03:33:44 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-841-g7899e99a45-fm-20220811.002-g7899e99a Mime-Version: 1.0 Message-Id: <5dcb2ab0-9aa1-44cb-9f13-0fb7d10357b3@www.fastmail.com> In-Reply-To: References: <20220830195520.1668785-1-bvanassche@acm.org> Date: Wed, 31 Aug 2022 09:33:24 +0200 From: "Arnd Bergmann" To: linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: riscpc: Unbreak the build X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220831_003346_420647_1A6B8752 X-CRM114-Status: GOOD ( 23.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 30, 2022, at 11:27 PM, Russell King (Oracle) wrote: > On Tue, Aug 30, 2022 at 01:55:50PM -0700, Bart Van Assche wrote: >> > > >> > > In file included from ./include/linux/io.h:13, >> > > from ./arch/arm/mach-rpc/include/mach/uncompress.h:9, >> >> A bisect led to the following: >> >> Fixes: 0361c7e504b1 ("ARM: ep93xx: multiplatform support") >> >> Please let me know if you want me to repost this patch with the Fixes tag >> included. > > That is indeed the cause, and I'd say that the patch to fix it is > incorrect. > > misc-ep93xx.h brings in EP93xx specific raw IO accessors into the > decompressor, but we've already had (and correctly had) linux/io.h > included. > > The problem is misc-ep93xx.h. Why is it defining these accessors? > That's a question for Arnd. The mach-ep93xx uncompress.h had these since the ep93xx got added in 2006, the idea was probably to avoid including linux/*.h headers in the decompressor and it was copied from arch-l7200, which was the first to do the same thing. Having the custom definition was probably never needed on ep93xx even if it was perhaps needed on one of the others that did the same thing. I agree that removing the #include from the rpc version is the wrong fix, but I can see a couple of others that all seem fine to me: - put the '#include "misc-ep93xx.h"' in an #ifdef as we do for the users - rename the custom __raw_writel etc to something with ep93xx prefix, or just open-code them - remove the custom functions and include linux/io.h unconditionally The last one is probably the cleanest, but also the most likely the cause regressions for another corner case. The other two remaining uncompress.h versions each just open-code the pointer dereference. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel