From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933139AbeCOXkG (ORCPT ); Thu, 15 Mar 2018 19:40:06 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:55292 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932673AbeCOXkF (ORCPT ); Thu, 15 Mar 2018 19:40:05 -0400 Subject: Re: [PATCH v3 04/14] KVM: s390: device attribute to set AP interpretive execution To: Pierre Morel , Halil Pasic , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com References: <1521051954-25715-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1521051954-25715-5-git-send-email-akrowiak@linux.vnet.ibm.com> <21bd029b-3500-3461-ce98-68ad3ae9b647@linux.vnet.ibm.com> <46a7e838-2be2-9587-6eb2-3bba95485609@linux.vnet.ibm.com> <5ed8017b-0168-9a50-234b-cfe9258eab72@linux.vnet.ibm.com> <17683324-f6e4-4328-54c1-1fce572faecd@linux.vnet.ibm.com> <8e10f1cb-3722-d231-2603-b7867420ac0a@linux.vnet.ibm.com> From: Tony Krowiak Date: Thu, 15 Mar 2018 19:39:41 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <8e10f1cb-3722-d231-2603-b7867420ac0a@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18031523-0012-0000-0000-000015E7DED1 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008681; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000254; SDB=6.01003610; UDB=6.00510773; IPR=6.00782936; MB=3.00020058; MTD=3.00000008; XFM=3.00000015; UTC=2018-03-15 23:39:48 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18031523-0013-0000-0000-000051E332CC Message-Id: <5dd1bcd3-5d17-37c1-1184-7f75a1fd32bc@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-15_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803150255 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/15/2018 01:56 PM, Pierre Morel wrote: > On 15/03/2018 18:21, Tony Krowiak wrote: >> On 03/15/2018 11:45 AM, Pierre Morel wrote: >>> On 15/03/2018 16:26, Tony Krowiak wrote: >>>> On 03/15/2018 09:00 AM, Pierre Morel wrote: >>>>> On 14/03/2018 22:57, Halil Pasic wrote: >>>>>> >>>>>> On 03/14/2018 07:25 PM, Tony Krowiak wrote: >>>>>>> The VFIO AP device model exploits interpretive execution of AP >>>>>>> instructions (APIE) to provide guests passthrough access to AP >>>>>>> devices. This patch introduces a new device attribute in the >>>>>>> KVM_S390_VM_CRYPTO device attribute group to set APIE from >>>>>>> the VFIO AP device defined on the guest. >>>>>>> >>>>>>> Signed-off-by: Tony Krowiak >>>>>>> --- >>>>>> [..] >>>>>> >>>>>>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c >>>>>>> index a60c45b..bc46b67 100644 >>>>>>> --- a/arch/s390/kvm/kvm-s390.c >>>>>>> +++ b/arch/s390/kvm/kvm-s390.c >>>>>>> @@ -815,6 +815,19 @@ static int kvm_s390_vm_set_crypto(struct >>>>>>> kvm *kvm, struct kvm_device_attr *attr) >>>>>>> sizeof(kvm->arch.crypto.crycb->dea_wrapping_key_mask)); >>>>>>> VM_EVENT(kvm, 3, "%s", "DISABLE: DEA keywrapping >>>>>>> support"); >>>>>>> break; >>>>>>> + case KVM_S390_VM_CRYPTO_INTERPRET_AP: >>>>>>> + if (attr->addr) { >>>>>>> + if (!test_kvm_cpu_feat(kvm, KVM_S390_VM_CPU_FEAT_AP)) >>>>>> Unlock mutex before returning? >>>>>> >>>>>> Maybe flip conditions (don't allow manipulating apie if feature >>>>>> not there). >>>>>> Clearing the anyways clear apie if feature not there ain't too >>>>>> bad, but >>>>>> rejecting the operation appears nicer to me. >>>>>> >>>>>>> + return -EOPNOTSUPP; >>>>>>> + kvm->arch.crypto.apie = 1; >>>>>>> + VM_EVENT(kvm, 3, "%s", >>>>>>> + "ENABLE: AP interpretive execution"); >>>>>>> + } else { >>>>>>> + kvm->arch.crypto.apie = 0; >>>>>>> + VM_EVENT(kvm, 3, "%s", >>>>>>> + "DISABLE: AP interpretive execution"); >>>>>>> + } >>>>>>> + break; >>>>>>> default: >>>>>>> mutex_unlock(&kvm->lock); >>>>>>> return -ENXIO; >>>>>> I wonder how the loop after this switch works for >>>>>> KVM_S390_VM_CRYPTO_INTERPRET_AP: >>>>>> >>>>>> kvm_for_each_vcpu(i, vcpu, kvm) { >>>>>> kvm_s390_vcpu_crypto_setup(vcpu); >>>>>> exit_sie(vcpu); >>>>>> } >>>>>> >>>>>> From not doing something like for KVM_S390_VM_CRYPTO_INTERPRET_AP >>>>>> >>>>>> if (kvm->created_vcpus) { >>>>>> mutex_unlock(&kvm->lock); >>>>>> return -EBUSY; >>>>>> and from the aforementioned loop I guess ECA.28 can be changed >>>>>> for a running guest. >>>>>> >>>>>> If there are running vcpus when KVM_S390_VM_CRYPTO_INTERPRET_AP is >>>>>> changed (set) these will be taken out of SIE by exit_sie(). Then >>>>>> for the >>>>>> corresponding threads the control probably goes to QEMU (the >>>>>> emulator in >>>>>> the userspace). And it puts that vcpu back into the SIE, and then >>>>>> that >>>>>> cpu starts acting according to the new ECA.28 value. While other >>>>>> vcpus >>>>>> may still work with the old value of ECA.28. >>>>>> >>>>>> I'm not saying what I describe above is necessarily something >>>>>> broken. >>>>>> But I would like to have it explained, why is it OK -- provided I >>>>>> did not >>>>>> make any errors in my reasoning (assumptions included). >>>>>> >>>>>> Can you help me understand this code? >>>>>> >>>>>> Regards, >>>>>> Halil >>>>>> >>>>>> [..] >>>>>> >>>>> >>>>> I have the same concerns as Halil. >>>>> >>>>> We do not need to change the virtulization type >>>>> (hardware/software) on the fly for the current use case. >>>>> >>>>> Couldn't we delay this until we have one and in between only make >>>>> the vCPU hotplug clean? >>>>> >>>>> We only need to let the door open for the day we have such a use >>>>> case. >>>> Are you suggesting this code be removed? If so, then where and >>>> under what conditions would >>>> you suggest setting ECA.28 given you objected to setting it based >>>> on whether the >>>> AP feature is installed? >>> >>> I would only call kvm_s390_vcpu_crypto_setup() from inside >>> kvm_arch_vcpu_init() >>> as it is already. >> It is not called from kvm_arch_vcpu_init(), it is called from >> kvm_arch_vcpu_setup(). > > hum, sorry for this. > However, the idea pertains, not to call this function from inside an > ioctl changing crypto parameters, but only during vcpu creation. Unfortunately, the ioctl does not get called until after the vcpus are created (see my comments below) > > > >> Also, >> this loop was already here, I did not put it in. Assuming whomever >> put it there did so >> for a reason, it is not my place to remove it. According to a trace I >> ran, the calls to this >> function occur after the vcpus are created. Consequently, the >> kvm_s390_vcpu_crypto_setup() >> function would not be called without the loop and neither the key >> wrapping support nor the >> ECA_APIE would be configured in the vcpu's SIE descriptor. >> >> If you have a better idea for where/how to set this flag, I'm all >> ears. It would be nice if it could be set before the vcpus are >> created, but I haven't >> found a good candidate. I suspect that the loop was put in to make >> sure that all vcpus >> get updated regardless of whether they are running or not, but I >> don't know what happens >> after a vcpu is kicked out of SIE. I suspect, as Halil surmised, that >> QEMU >> restores the vcpus to SIE. This would seemingly cause the >> kvm_arch_vcpu_setup() to get >> called at which time the ECA_APIE value as well as the key wrapping >> values will get set. >> If somebody has knowledge of the flow here, please feel free to pitch >> in. >>> >>> >>> >>>>> >>>>> >>>>> Pierre >>>>> >>>>> >>>>> >>>> >>> >> >