From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 3/6] drm/i915: Pass crtc_state to ips toggle functions Date: Thu, 9 Nov 2017 18:56:36 +0100 Message-ID: <5dd42608-8c3c-c208-f47d-d5a605e8f432@linux.intel.com> References: <20171109162458.50681-1-maarten.lankhorst@linux.intel.com> <20171109162458.50681-3-maarten.lankhorst@linux.intel.com> <20171109170957.GV10981@intel.com> <20171109175106.GY10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id CAB9C6E0A5 for ; Thu, 9 Nov 2017 17:56:40 +0000 (UTC) In-Reply-To: <20171109175106.GY10981@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDktMTEtMTcgb20gMTg6NTEgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gVGh1LCBO b3YgMDksIDIwMTcgYXQgMDY6MzE6MDJQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IE9wIDA5LTExLTE3IG9tIDE4OjA5IHNjaHJlZWYgVmlsbGUgU3lyasOkbMOkOgo+Pj4gT24g VGh1LCBOb3YgMDksIDIwMTcgYXQgMDU6MjQ6NTVQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qg d3JvdGU6Cj4+Pj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFu a2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4+PiAtLS0KPj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfY29sb3IuYyAgIHwgIDQgKystLQo+Pj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgfCAyNCArKysrKysrKysrKysrLS0tLS0tLS0tLS0KPj4+PiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgICAgIHwgIDYgKysrLS0tCj4+Pj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICA0ICsrLS0KPj4+PiAgNCBmaWxlcyBjaGFu Z2VkLCAyMCBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKPj4+Pgo+Pj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfY29sb3IuYwo+Pj4+IGluZGV4IGI4MzE1YmNhODUyYi4uYzYzNzNmZWJmNjE3 IDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPj4+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4+Pj4gQEAgLTM3MCw3 ICszNzAsNyBAQCBzdGF0aWMgdm9pZCBoYXN3ZWxsX2xvYWRfbHV0cyhzdHJ1Y3QgZHJtX2NydGNf c3RhdGUgKmNydGNfc3RhdGUpCj4+Pj4gIAkgKi8KPj4+PiAgCWlmIChJU19IQVNXRUxMKGRldl9w cml2KSAmJiBpbnRlbF9jcnRjX3N0YXRlLT5pcHNfZW5hYmxlZCAmJgo+Pj4+ICAJICAgIChpbnRl bF9jcnRjX3N0YXRlLT5nYW1tYV9tb2RlID09IEdBTU1BX01PREVfTU9ERV9TUExJVCkpIHsKPj4+ PiAtCQloc3dfZGlzYWJsZV9pcHMoaW50ZWxfY3J0Yyk7Cj4+Pj4gKwkJaHN3X2Rpc2FibGVfaXBz KGludGVsX2NydGMsIGludGVsX2NydGNfc3RhdGUpOwo+Pj4gSSB3b3VsZCBzdWdnZXN0IHNpbXBs aWZ5aW5nIG1vcmUgYW5kIHBhc3Npbmcgb25seSB0aGUgc3RhdGUuCj4+PiBUaGUgY2FsbGVlIGNh biBhbHdheXMgZGlnIG91dCB0aGUgY3J0YyBpZiBpdCBuZWVkcyBpdC4KPj4+Cj4+Pj4gIAkJcmVl bmFibGVfaXBzID0gdHJ1ZTsKPj4+PiAgCX0KPj4+PiAgCj4+Pj4gQEAgLTM4MCw3ICszODAsNyBA QCBzdGF0aWMgdm9pZCBoYXN3ZWxsX2xvYWRfbHV0cyhzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNy dGNfc3RhdGUpCj4+Pj4gIAlpOXh4X2xvYWRfbHV0cyhjcnRjX3N0YXRlKTsKPj4+PiAgCj4+Pj4g IAlpZiAocmVlbmFibGVfaXBzKQo+Pj4+IC0JCWhzd19lbmFibGVfaXBzKGludGVsX2NydGMpOwo+ Pj4+ICsJCWhzd19lbmFibGVfaXBzKGludGVsX2NydGMsIGludGVsX2NydGNfc3RhdGUpOwo+Pj4+ ICB9Cj4+Pj4gIAo+Pj4+ICBzdGF0aWMgdm9pZCBiZHdfbG9hZF9kZWdhbW1hX2x1dChzdHJ1Y3Qg ZHJtX2NydGNfc3RhdGUgKnN0YXRlKQo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPj4+PiBpbmRleCBmNTkzM2IwNzE5YzkuLjEzYjM3MmU0ZjA2ZSAxMDA2NDQKPj4+PiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4+PiBAQCAtNDgzMiwxMiArNDgzMiwxMiBA QCBzdGF0aWMgdm9pZCBpcm9ubGFrZV9wZml0X2VuYWJsZShzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0 YykKPj4+PiAgCX0KPj4+PiAgfQo+Pj4+ICAKPj4+PiAtdm9pZCBoc3dfZW5hYmxlX2lwcyhzdHJ1 Y3QgaW50ZWxfY3J0YyAqY3J0YykKPj4+PiArdm9pZCBoc3dfZW5hYmxlX2lwcyhzdHJ1Y3QgaW50 ZWxfY3J0YyAqY3J0YywgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUp Cj4+Pj4gIHsKPj4+PiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsK Pj4+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsK Pj4+PiAgCj4+Pj4gLQlpZiAoIWNydGMtPmNvbmZpZy0+aXBzX2VuYWJsZWQpCj4+Pj4gKwlpZiAo IWNydGNfc3RhdGUtPmlwc19lbmFibGVkKQo+Pj4+ICAJCXJldHVybjsKPj4+PiAgCj4+Pj4gIAkv Kgo+Pj4+IEBAIC00ODcxLDEyICs0ODcxLDEyIEBAIHZvaWQgaHN3X2VuYWJsZV9pcHMoc3RydWN0 IGludGVsX2NydGMgKmNydGMpCj4+Pj4gIAl9Cj4+Pj4gIH0KPj4+PiAgCj4+Pj4gLXZvaWQgaHN3 X2Rpc2FibGVfaXBzKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+Pj4+ICt2b2lkIGhzd19kaXNh YmxlX2lwcyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywgY29uc3Qgc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUpCj4+Pj4gIHsKPj4+PiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYg PSBjcnRjLT5iYXNlLmRldjsKPj4+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoZGV2KTsKPj4+PiAgCj4+Pj4gLQlpZiAoIWNydGMtPmNvbmZpZy0+aXBzX2Vu YWJsZWQpCj4+Pj4gKwlpZiAoIWNydGNfc3RhdGUtPmlwc19lbmFibGVkKQo+Pj4+ICAJCXJldHVy bjsKPj4+PiAgCj4+Pj4gIAlhc3NlcnRfcGxhbmVfZW5hYmxlZChkZXZfcHJpdiwgY3J0Yy0+cGxh bmUpOwo+Pj4gSG1tLiBDb25mdXNpZWQuIE9oIHJpZ2h0LCBteSBwbGFuZSBhc3NlcnQgY2xlYW51 cCBkaWRuJ3QgbWFuYWdlIHRvIGdvIGluIHlldCA6UAo+Pj4KPj4+PiBAQCAtNDkyNCw3ICs0OTI0 LDggQEAgc3RhdGljIHZvaWQgaW50ZWxfY3J0Y19kcG1zX292ZXJsYXlfZGlzYWJsZShzdHJ1Y3Qg aW50ZWxfY3J0YyAqaW50ZWxfY3J0YykKPj4+PiAgICogY29tcGxldGVseSBoaWRlIHRoZSBwcmlt YXJ5IHBsYW5lLgo+Pj4+ICAgKi8KPj4+PiAgc3RhdGljIHZvaWQKPj4+PiAtaW50ZWxfcG9zdF9l bmFibGVfcHJpbWFyeShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4+Pj4gK2ludGVsX3Bvc3RfZW5h YmxlX3ByaW1hcnkoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+Pj4+ICsJCQkgIGNvbnN0IHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPj4+PiAgewo+Pj4+ICAJc3RydWN0 IGRybV9kZXZpY2UgKmRldiA9IGNydGMtPmRldjsKPj4+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPj4+PiBAQCAtNDkzNyw3ICs0OTM4LDcgQEAg aW50ZWxfcG9zdF9lbmFibGVfcHJpbWFyeShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4+Pj4gIAkg KiB3aGVuIGdvaW5nIGZyb20gcHJpbWFyeSBvbmx5IHRvIHNwcml0ZSBvbmx5IGFuZCB2aWNlCj4+ Pj4gIAkgKiB2ZXJzYS4KPj4+PiAgCSAqLwo+Pj4+IC0JaHN3X2VuYWJsZV9pcHMoaW50ZWxfY3J0 Yyk7Cj4+Pj4gKwloc3dfZW5hYmxlX2lwcyhpbnRlbF9jcnRjLCBuZXdfY3J0Y19zdGF0ZSk7Cj4+ Pj4gIAo+Pj4+ICAJLyoKPj4+PiAgCSAqIEdlbjIgcmVwb3J0cyBwaXBlIHVuZGVycnVucyB3aGVu ZXZlciBhbGwgcGxhbmVzIGFyZSBkaXNhYmxlZC4KPj4+PiBAQCAtNDk1Niw3ICs0OTU3LDggQEAg aW50ZWxfcG9zdF9lbmFibGVfcHJpbWFyeShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4+Pj4gIAo+ Pj4+ICAvKiBGSVhNRSBtb3ZlIGFsbCB0aGlzIHRvIHByZV9wbGFuZV91cGRhdGUoKSB3aXRoIHBy b3BlciBzdGF0ZSB0cmFja2luZyAqLwo+Pj4+ICBzdGF0aWMgdm9pZAo+Pj4+IC1pbnRlbF9wcmVf ZGlzYWJsZV9wcmltYXJ5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPj4+PiAraW50ZWxfcHJlX2Rp c2FibGVfcHJpbWFyeShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4+Pj4gKwkJCSAgY29uc3Qgc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlKQo+Pj4+ICB7Cj4+Pj4gIAlzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+Pj4+ICAJc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+Pj4+IEBAIC00OTc4LDcgKzQ5ODAsNyBA QCBpbnRlbF9wcmVfZGlzYWJsZV9wcmltYXJ5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPj4+PiAg CSAqIHdoZW4gZ29pbmcgZnJvbSBwcmltYXJ5IG9ubHkgdG8gc3ByaXRlIG9ubHkgYW5kIHZpY2UK Pj4+PiAgCSAqIHZlcnNhLgo+Pj4+ICAJICovCj4+Pj4gLQloc3dfZGlzYWJsZV9pcHMoaW50ZWxf Y3J0Yyk7Cj4+Pj4gKwloc3dfZGlzYWJsZV9pcHMoaW50ZWxfY3J0Yywgb2xkX2NydGNfc3RhdGUp Owo+Pj4+ICB9Cj4+Pj4gIAo+Pj4+ICAvKiBGSVhNRSBnZXQgcmlkIG9mIHRoaXMgYW5kIHVzZSBw cmVfcGxhbmVfdXBkYXRlICovCj4+Pj4gQEAgLTQ5OTAsNyArNDk5Miw3IEBAIGludGVsX3ByZV9k aXNhYmxlX3ByaW1hcnlfbm9hdG9taWMoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+Pj4+ICAJc3Ry dWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+Pj4+ICAJ aW50IHBpcGUgPSBpbnRlbF9jcnRjLT5waXBlOwo+Pj4+ICAKPj4+PiAtCWludGVsX3ByZV9kaXNh YmxlX3ByaW1hcnkoY3J0Yyk7Cj4+Pj4gKwlpbnRlbF9wcmVfZGlzYWJsZV9wcmltYXJ5KGNydGMs IHRvX2ludGVsX2NydGNfc3RhdGUoY3J0Yy0+c3RhdGUpKTsKPj4+PiAgCj4+Pj4gIAkvKgo+Pj4+ ICAJICogVmJsYW5rIHRpbWUgdXBkYXRlcyBmcm9tIHRoZSBzaGFkb3cgdG8gbGl2ZSBwbGFuZSBj b250cm9sIHJlZ2lzdGVyCj4+Pj4gQEAgLTUwMzQsNyArNTAzNiw3IEBAIHN0YXRpYyB2b2lkIGlu dGVsX3Bvc3RfcGxhbmVfdXBkYXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19z dGF0ZSkKPj4+PiAgCQlpZiAocHJpbWFyeV9zdGF0ZS0+YmFzZS52aXNpYmxlICYmCj4+Pj4gIAkJ ICAgIChuZWVkc19tb2Rlc2V0KCZwaXBlX2NvbmZpZy0+YmFzZSkgfHwKPj4+PiAgCQkgICAgICFv bGRfcHJpbWFyeV9zdGF0ZS0+YmFzZS52aXNpYmxlKSkKPj4+PiAtCQkJaW50ZWxfcG9zdF9lbmFi bGVfcHJpbWFyeSgmY3J0Yy0+YmFzZSk7Cj4+Pj4gKwkJCWludGVsX3Bvc3RfZW5hYmxlX3ByaW1h cnkoJmNydGMtPmJhc2UsIHBpcGVfY29uZmlnKTsKPj4+PiAgCX0KPj4+PiAgfQo+Pj4+ICAKPj4+ PiBAQCAtNTA2Myw3ICs1MDY1LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfcHJlX3BsYW5lX3VwZGF0 ZShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUsCj4+Pj4gIAo+Pj4+ICAJ CWlmIChvbGRfcHJpbWFyeV9zdGF0ZS0+YmFzZS52aXNpYmxlICYmCj4+Pj4gIAkJICAgIChtb2Rl c2V0IHx8ICFwcmltYXJ5X3N0YXRlLT5iYXNlLnZpc2libGUpKQo+Pj4+IC0JCQlpbnRlbF9wcmVf ZGlzYWJsZV9wcmltYXJ5KCZjcnRjLT5iYXNlKTsKPj4+PiArCQkJaW50ZWxfcHJlX2Rpc2FibGVf cHJpbWFyeSgmY3J0Yy0+YmFzZSwgb2xkX2NydGNfc3RhdGUpOwo+Pj4+ICAJfQo+Pj4+ICAKPj4+ PiAgCS8qCj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4+Pj4gaW5kZXggY2RkZDk2YjI0ODc4 Li44MmMzM2Q5Y2Q0NjYgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHAuYwo+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPj4+PiBA QCAtMzk0Nyw3ICszOTQ3LDcgQEAgc3RhdGljIGludCBpbnRlbF9kcF9zaW5rX2NyY19zdG9wKHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4+Pj4gIAl9Cj4+Pj4gIAo+Pj4+ICAgb3V0Ogo+Pj4+ IC0JaHN3X2VuYWJsZV9pcHMoaW50ZWxfY3J0Yyk7Cj4+Pj4gKwloc3dfZW5hYmxlX2lwcyhpbnRl bF9jcnRjLCB0b19pbnRlbF9jcnRjX3N0YXRlKGludGVsX2NydGMtPmJhc2Uuc3RhdGUpKTsKPj4+ IGNydGMtPmNvbmZpZyB3b3VsZCBzZWVtIGxpa2UgdGhlIHNsaWdodGx5IG1vcmUgY29ycmVjdCB0 aGluZyB0byBwYXNzCj4+PiBoZXJlLiBJdCdzIGFsc28gZWFzaWVyIHRvIGdyZXAgZm9yIHdoZW4g c29tZW9uZSBzZXRzIG91dCB0byBmaXggdGhpcwo+Pj4gbWVzcyBwcm9wZXJseS4KPj4gQ29uc2lk ZXJlZCBpdCwgYnV0IG91ciBjcnRjLT5jb25maWcgdXNhZ2UgaXMgYSBtZXNzLiBJJ2QgcmF0aGVy IGdldCByaWQgb2YgdGhlIGludGVsX2RwX3NpbmtfY3JjIGNvZGUgdGJoLiA6Lwo+IEknZCByYXRo ZXIgbm90IHNwcmVhZCBtb3JlIC0+c3RhdGUgdXNlcyB3aGVuIEkganVzdCByZWNlbnRseQo+IG1h bmFnZWQgdG8gY2xlYW4gb3V0IG1hbnkgb2YgdGhlbS4gV2Ugc3RpbGwgaGF2ZSBzb21lIGxlZnQg Zm9yCj4gc3VyZSwgYnV0IGFkZGluZyBtb3JlIHNlZW1zIGxpa2UgZ29pbmcgYmFja3dhcmRzLgo+ Ck1heWJlIGV4cG9ydCBoc3dfcGlwZV9BX2NyY193YSA/CgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK