All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] exfat, exfat-utils: fix the installation path of the helper, utilities
Date: Tue, 24 Sep 2019 14:14:49 +0200	[thread overview]
Message-ID: <5dd8e5a1-9ce6-2eeb-6f88-e5f698efa22a@mind.be> (raw)
In-Reply-To: <9dbde6f8-aa14-0b64-3fba-5126f23ad56a@grandegger.com>



On 24/09/2019 14:13, Wolfgang Grandegger wrote:
> Hallo Carlos,
> 
> Am 24.09.19 um 14:00 schrieb Carlos Santos:
>> On Tue, Sep 24, 2019 at 4:56 AM Wolfgang Grandegger <wg@grandegger.com> wrote:
>>>
>>> "mount" from the "util-linux" package does expect the helper utilities
>>> in "/sbin" and not "/usr/sbin".
>>>
>>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
>>> ---
>>>
>>> Changes since v1:
>>>   Use "--prefix=/" to get programs properly installed
>>>
>>>  package/exfat-utils/exfat-utils.mk | 2 ++
>>>  package/exfat/exfat.mk             | 2 ++
>>>  2 files changed, 4 insertions(+)
>>>
>>> diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
>>> index 62cd471..dd5036e 100644
>>> --- a/package/exfat-utils/exfat-utils.mk
>>> +++ b/package/exfat-utils/exfat-utils.mk
>>> @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
>>>  EXFAT_UTILS_LICENSE = GPL-3.0+
>>>  EXFAT_UTILS_LICENSE_FILES = COPYING
>>>
>>> +EXFAT_UTILS_CONF_OPTS += --prefix=/
>>> +
>>>  $(eval $(autotools-package))
>>> diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
>>> index b52b197..ce6859f 100644
>>> --- a/package/exfat/exfat.mk
>>> +++ b/package/exfat/exfat.mk
>>> @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
>>>  EXFAT_LICENSE_FILES = COPYING
>>>  EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
>>>
>>> +EXFAT_CONF_OPTS += --prefix=/
>>> +
>>>  $(eval $(autotools-package))
>>> --
>>> 2.7.4
>>
>> Did you test on a clean build?
>>
>> With v1:
>>
>> $ rm -rf target/ build/exfat* && make exfat exfat-utils && find target
>> target/
>> target/sbin
>> target/sbin/mount.exfat-fuse
>> target/sbin/mount.exfat
>> target/sbin/dumpexfat
>> target/sbin/exfatfsck
>> target/sbin/fsck.exfat
>> target/sbin/exfatlabel
>> target/sbin/mkexfatfs
>> target/sbin/mkfs.exfat
>> target/usr
>> target/usr/share
>> target/usr/share/man
>> target/usr/share/man/man8
>> target/usr/share/man/man8/mount.exfat-fuse.8
>> target/usr/share/man/man8/dumpexfat.8
>> target/usr/share/man/man8/exfatfsck.8
>> target/usr/share/man/man8/exfatlabel.8
>>
>> With v2:
>>
>>  rm -rf target/ build/exfat* && make exfat exfat-utils && find target
>> target
>> target/usr
>> target/usr/sbin
>> target/usr/sbin/mount.exfat-fuse
>> target/usr/sbin/mount.exfat
>> target/usr/sbin/dumpexfat
>> target/usr/sbin/exfatfsck
>> target/usr/sbin/fsck.exfat
>> target/usr/sbin/exfatlabel
>> target/usr/sbin/mkexfatfs
>> target/usr/sbin/mkfs.exfat
>> target/share
>> target/share/man
>> target/share/man/man8
>> target/share/man/man8/mount.exfat-fuse.8
>> target/share/man/man8/dumpexfat.8
>> target/share/man/man8/exfatfsck.8
>> target/share/man/man8/exfatlabel.8
>> target/share/man/man8/mkexfatfs.8
> 
> You are completely right! I obviously did something wrong, grrr. Sorry
> for confusion.

 My bad, I should have mentioned that we explicitly set --exec-prefix=/usr as
well, so you need to override that as well.

 Actually, you probably *only* want to override exec-prefix, since the man pages
should still go to usr/share/man.

 Regards,
 Arnout

      reply	other threads:[~2019-09-24 12:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24  7:56 [Buildroot] [PATCH v2] exfat, exfat-utils: fix the installation path of the helper, utilities Wolfgang Grandegger
2019-09-24 12:00 ` Carlos Santos
2019-09-24 12:13   ` Wolfgang Grandegger
2019-09-24 12:14     ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5dd8e5a1-9ce6-2eeb-6f88-e5f698efa22a@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.