On 11/21/2017 01:18 PM, Pankaj Bansal wrote:
>> Looks better now. Please add note to
>> "Documentation/devicetree/bindings/net/can/fsl-flexcan.txt" that we now
>> support endianess and state the default endianess.
>>
>> What about:
>>
>> On a "fsl,p1010-flexcan" device BE is default, on all other devices LE is.
>>
>> Please remove the existing "fsl,p1010-flexcan" from "arch/arm/boot/dts"
>> and add fsl,imx25-flexcan, fsl,imx35-flexcan and fsl,imx53-flexcan support to
>> the driver.
> 
> @Marc Kleine-Budde :
> Should we keep 
> .compatible = "fsl,imx25-flexcan", .data = &fsl_p1010_devtype_data,
> or 
> .compatible = "fsl,imx25-flexcan", .data = &fsl_imx25_devtype_data,
> 
> in flexcan.c ? right now imx25, imx35, imx53 use same dev_data as p1010.

Yes, keep it this way.

> So If any quirk is added to p1010, it's also applicable for other 3
> platforms.

Probably... I've never had a p1010 in my hands.

> Once we remove p1010 compatible from their device-tree, should we
> keep The dev_data as p1010 or make it separate too ?
Keep it until there is a change makes separating them necessary.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |