From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A8A0C43381 for ; Fri, 15 Mar 2019 09:00:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E12CC217F5 for ; Fri, 15 Mar 2019 09:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728544AbfCOJAO (ORCPT ); Fri, 15 Mar 2019 05:00:14 -0400 Received: from anchovy2.45ru.net.au ([203.30.46.146]:42758 "EHLO anchovy2.45ru.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726582AbfCOJAO (ORCPT ); Fri, 15 Mar 2019 05:00:14 -0400 X-Greylist: delayed 399 seconds by postgrey-1.27 at vger.kernel.org; Fri, 15 Mar 2019 05:00:13 EDT Received: (qmail 3875 invoked by uid 5089); 15 Mar 2019 08:53:32 -0000 Received: by simscan 1.2.0 ppid: 3085, pid: 3086, t: 34.8644s scanners: regex: 1.2.0 attach: 1.2.0 clamav: 0.88.3/m:40/d:1950 Received: from unknown (HELO ?192.168.0.122?) (preid@electromag.com.au@203.59.235.95) by anchovy3.45ru.net.au with ESMTPA; 15 Mar 2019 08:52:57 -0000 Subject: regression from: net: phy: marvell: Avoid unnecessary soft reset To: Florian Fainelli , netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , dongsheng.wang@hxt-semitech.com, cphealy@gmail.com, clemens.gruber@pqgruber.com, hkallweit1@gmail.com, nbd@nbd.name, harini.katakam@xilinx.com References: <20180925182846.30042-1-f.fainelli@gmail.com> <20180925182846.30042-3-f.fainelli@gmail.com> From: Phil Reid Message-ID: <5ddf46b1-1959-832d-c6a5-86d8f93dc409@electromag.com.au> Date: Fri, 15 Mar 2019 16:52:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20180925182846.30042-3-f.fainelli@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-AU Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org G'day All, I've just update from kernel 4.19 to 5.0 on a custom board that has a marvell dsa mv88e6085 and the phy on the mv88e6085 will only connect at 10Mb/s with the above mentioned patch applied. Bisecting the issue lead me to the following patch. d6ab93364734bd (net: phy: marvell: Avoid unnecessary soft reset) Revert the patch, and the associated build fix 4b1bd6976945417 (net: phy: marvell: Fix build.) restores connections to 1Gb/s. Anyone have any thoughts as to the correct fix? -- Regards Phil