From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84110C433FE for ; Mon, 7 Dec 2020 13:52:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E5E0233FA for ; Mon, 7 Dec 2020 13:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725960AbgLGNwL (ORCPT ); Mon, 7 Dec 2020 08:52:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:51958 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbgLGNwK (ORCPT ); Mon, 7 Dec 2020 08:52:10 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0353DAC90; Mon, 7 Dec 2020 13:51:29 +0000 (UTC) Subject: Re: [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-12-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <5ddfb821-8c2f-89df-99fe-298ac9d68d76@suse.de> Date: Mon, 7 Dec 2020 14:51:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201206190247.1861316-12-sam@ravnborg.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y" Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y Content-Type: multipart/mixed; boundary="lCVTJBEB2DqM0UFonqvKomR7vvbpzMa9l"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk Message-ID: <5ddfb821-8c2f-89df-99fe-298ac9d68d76@suse.de> Subject: Re: [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-12-sam@ravnborg.org> In-Reply-To: <20201206190247.1861316-12-sam@ravnborg.org> --lCVTJBEB2DqM0UFonqvKomR7vvbpzMa9l Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > screen_pitch was asssigned a value which was never used. > Drop it to fix the warning >=20 > Signed-off-by: Sam Ravnborg > Cc: Peter Jones > Cc: linux-fbdev@vger.kernel.org Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/efifb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c > index e57c00824965..b80ba3d2a9b8 100644 > --- a/drivers/video/fbdev/efifb.c > +++ b/drivers/video/fbdev/efifb.c > @@ -139,7 +139,7 @@ static bool efifb_bgrt_sanity_check(struct screen_i= nfo *si, u32 bmp_width) > =20 > static void efifb_show_boot_graphics(struct fb_info *info) > { > - u32 bmp_width, bmp_height, bmp_pitch, screen_pitch, dst_x, y, src_y; > + u32 bmp_width, bmp_height, bmp_pitch, dst_x, y, src_y; > struct screen_info *si =3D &screen_info; > struct bmp_file_header *file_header; > struct bmp_dib_header *dib_header; > @@ -193,7 +193,6 @@ static void efifb_show_boot_graphics(struct fb_info= *info) > bmp_width =3D dib_header->width; > bmp_height =3D abs(dib_header->height); > bmp_pitch =3D round_up(3 * bmp_width, 4); > - screen_pitch =3D si->lfb_linelength; > =20 > if ((file_header->bitmap_offset + bmp_pitch * bmp_height) > > bgrt_image_size) >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --lCVTJBEB2DqM0UFonqvKomR7vvbpzMa9l-- --UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/OM14FAwAAAAAACgkQlh/E3EQov+CP IQ/+L432K3gimY1wgKAfFPFLLqwBI8N1N4+Ftj71loVfWxFMiCrL4wkh8OJVRpjntNSz7NuuF7ix vRBDdhQz230JWE6U2+mwXQR2h43j0MNbYF1OqY/tyjPb2dmZz2vt9KkB4989+jCL67CCAxJBezxD kmWyHyFS2NK31vCK5HH1fyhPLDxdOlz7FQ0pnknyuMEojkTpNhPIX0qkVry4xfto+4cLgV9qrtCq icX/6HTHgeXKzlDKxgscab8PYrbC44gsoHTight/Ygor/cXj5IxGZNzmZeOJhyWYcfpN3AousRRm KWvqvzc2fbdgj88Wg7IUd7y9t+gP7yH5hzVf5wtrGB/cnd+4+sP53XmYMgOlh/mNx2zlT8s0VetE CJJFwyqRFDg06xhtlZlLsej1dId13la8yCPm5dZhFPKi/urKqDMuciOAZ1Ak7rWYyT27vwMglBG+ z3QoAi4w50q8ZUNZ3lP0GYN16A+lcHNze11yoY+20QERmicjNMsyKYWVJ7wtBkjeG04ID5nC12Yb sWWq/+R8nPU/FHs/Nzpb1L+way0thOKm+tCA16wonwYYF16qXGFcdGeK4KtI3LeBUwPB63I1DmSm bpZblj7oyFlsbGfqNvxYfxoAGFf6Y5zTysubIuoUsFRET/uRadnB/2FKwWy8bsqlM1XF6wxKA+Cm IIA= =QjfE -----END PGP SIGNATURE----- --UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DE5FC4361B for ; Mon, 7 Dec 2020 13:52:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2599A2343F for ; Mon, 7 Dec 2020 13:52:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2599A2343F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JY+oG2Du/lloLCh7Y0rarg5hgQXregXDEPUFnlGH5IM=; b=bW2ZlFt31LVbV+7S/TmrLJW+f QVYy5wr566XQck9FkLbYHXtZtVff/BedzVWg5g3S02ymLhtSMN81uyEF3xG7NEK4TwpmqjtcJ8aHD jA/VIjW0XcCB0guDy9RKkY1Jw3i+lncQrTo2pm+bKcVs2gWyM4axVIksfqT2EtA9R2nQzaa2MWEy4 v8rXZSGfSf0iFJe5IIjIA9D2yP0OxLa/eqccKwmiLaYB9ntgegXlCcTscQKA8LcvmMiovuobzoy/7 H0caiLl7iZHJwDY15k80wLmHvvZZfXDBEoxKiQQySF+4H4OQqYpnJlDtbmVfCSI1ic5YzbLtRUvuR 66bODG8BQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmGvN-0005aP-4x; Mon, 07 Dec 2020 13:51:33 +0000 Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmGvK-0005Z5-86 for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2020 13:51:31 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0353DAC90; Mon, 7 Dec 2020 13:51:29 +0000 (UTC) Subject: Re: [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-12-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <5ddfb821-8c2f-89df-99fe-298ac9d68d76@suse.de> Date: Mon, 7 Dec 2020 14:51:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201206190247.1861316-12-sam@ravnborg.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201207_085130_563046_7CC01C63 X-CRM114-Status: GOOD ( 23.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Kuninori Morimoto , Peter Zijlstra , Daniel Vetter , Gustavo A R Silva , Andrzej Hajda , Peter Jones , Geert Uytterhoeven , Michael Ellerman , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Thomas Winischhofer , linux-arm-kernel@lists.infradead.org, Qilong Zhang , Randy Dunlap , Douglas Anderson , Tony Prisk , Thierry Reding , Alexander Klimov , Colin Ian King , Andrew Morton , Mike Rapoport Content-Type: multipart/mixed; boundary="===============6186936572422000009==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6186936572422000009== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y Content-Type: multipart/mixed; boundary="lCVTJBEB2DqM0UFonqvKomR7vvbpzMa9l"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk Message-ID: <5ddfb821-8c2f-89df-99fe-298ac9d68d76@suse.de> Subject: Re: [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-12-sam@ravnborg.org> In-Reply-To: <20201206190247.1861316-12-sam@ravnborg.org> --lCVTJBEB2DqM0UFonqvKomR7vvbpzMa9l Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > screen_pitch was asssigned a value which was never used. > Drop it to fix the warning >=20 > Signed-off-by: Sam Ravnborg > Cc: Peter Jones > Cc: linux-fbdev@vger.kernel.org Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/efifb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c > index e57c00824965..b80ba3d2a9b8 100644 > --- a/drivers/video/fbdev/efifb.c > +++ b/drivers/video/fbdev/efifb.c > @@ -139,7 +139,7 @@ static bool efifb_bgrt_sanity_check(struct screen_i= nfo *si, u32 bmp_width) > =20 > static void efifb_show_boot_graphics(struct fb_info *info) > { > - u32 bmp_width, bmp_height, bmp_pitch, screen_pitch, dst_x, y, src_y; > + u32 bmp_width, bmp_height, bmp_pitch, dst_x, y, src_y; > struct screen_info *si =3D &screen_info; > struct bmp_file_header *file_header; > struct bmp_dib_header *dib_header; > @@ -193,7 +193,6 @@ static void efifb_show_boot_graphics(struct fb_info= *info) > bmp_width =3D dib_header->width; > bmp_height =3D abs(dib_header->height); > bmp_pitch =3D round_up(3 * bmp_width, 4); > - screen_pitch =3D si->lfb_linelength; > =20 > if ((file_header->bitmap_offset + bmp_pitch * bmp_height) > > bgrt_image_size) >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --lCVTJBEB2DqM0UFonqvKomR7vvbpzMa9l-- --UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/OM14FAwAAAAAACgkQlh/E3EQov+CP IQ/+L432K3gimY1wgKAfFPFLLqwBI8N1N4+Ftj71loVfWxFMiCrL4wkh8OJVRpjntNSz7NuuF7ix vRBDdhQz230JWE6U2+mwXQR2h43j0MNbYF1OqY/tyjPb2dmZz2vt9KkB4989+jCL67CCAxJBezxD kmWyHyFS2NK31vCK5HH1fyhPLDxdOlz7FQ0pnknyuMEojkTpNhPIX0qkVry4xfto+4cLgV9qrtCq icX/6HTHgeXKzlDKxgscab8PYrbC44gsoHTight/Ygor/cXj5IxGZNzmZeOJhyWYcfpN3AousRRm KWvqvzc2fbdgj88Wg7IUd7y9t+gP7yH5hzVf5wtrGB/cnd+4+sP53XmYMgOlh/mNx2zlT8s0VetE CJJFwyqRFDg06xhtlZlLsej1dId13la8yCPm5dZhFPKi/urKqDMuciOAZ1Ak7rWYyT27vwMglBG+ z3QoAi4w50q8ZUNZ3lP0GYN16A+lcHNze11yoY+20QERmicjNMsyKYWVJ7wtBkjeG04ID5nC12Yb sWWq/+R8nPU/FHs/Nzpb1L+way0thOKm+tCA16wonwYYF16qXGFcdGeK4KtI3LeBUwPB63I1DmSm bpZblj7oyFlsbGfqNvxYfxoAGFf6Y5zTysubIuoUsFRET/uRadnB/2FKwWy8bsqlM1XF6wxKA+Cm IIA= =QjfE -----END PGP SIGNATURE----- --UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y-- --===============6186936572422000009== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6186936572422000009==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D6ECC4361B for ; Mon, 7 Dec 2020 13:51:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5521B233ED for ; Mon, 7 Dec 2020 13:51:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5521B233ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DC1A89D8D; Mon, 7 Dec 2020 13:51:32 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FE2D89D8D for ; Mon, 7 Dec 2020 13:51:30 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0353DAC90; Mon, 7 Dec 2020 13:51:29 +0000 (UTC) Subject: Re: [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-12-sam@ravnborg.org> From: Thomas Zimmermann Message-ID: <5ddfb821-8c2f-89df-99fe-298ac9d68d76@suse.de> Date: Mon, 7 Dec 2020 14:51:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201206190247.1861316-12-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Kuninori Morimoto , Peter Zijlstra , Daniel Vetter , Gustavo A R Silva , Andrzej Hajda , Peter Jones , Geert Uytterhoeven , Michael Ellerman , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Thomas Winischhofer , linux-arm-kernel@lists.infradead.org, Qilong Zhang , Randy Dunlap , Douglas Anderson , Tony Prisk , Thierry Reding , Alexander Klimov , Colin Ian King , Andrew Morton , Mike Rapoport Content-Type: multipart/mixed; boundary="===============0816718754==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0816718754== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y Content-Type: multipart/mixed; boundary="lCVTJBEB2DqM0UFonqvKomR7vvbpzMa9l"; protected-headers="v1" From: Thomas Zimmermann To: Sam Ravnborg , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Lee Jones Cc: Alexander Klimov , Andrew Morton , Andrzej Hajda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Colin Ian King , Daniel Vetter , Douglas Anderson , Geert Uytterhoeven , Gustavo A R Silva , Kuninori Morimoto , linux-arm-kernel@lists.infradead.org, Michael Ellerman , Mike Rapoport , Peter Jones , Peter Zijlstra , Qilong Zhang , Randy Dunlap , Rich Felker , Thierry Reding , Thomas Winischhofer , Tony Prisk Message-ID: <5ddfb821-8c2f-89df-99fe-298ac9d68d76@suse.de> Subject: Re: [PATCH v3 11/13] video: fbdev: efifb: Fix set but not used warning for screen_pitch References: <20201206190247.1861316-1-sam@ravnborg.org> <20201206190247.1861316-12-sam@ravnborg.org> In-Reply-To: <20201206190247.1861316-12-sam@ravnborg.org> --lCVTJBEB2DqM0UFonqvKomR7vvbpzMa9l Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 06.12.20 um 20:02 schrieb Sam Ravnborg: > screen_pitch was asssigned a value which was never used. > Drop it to fix the warning >=20 > Signed-off-by: Sam Ravnborg > Cc: Peter Jones > Cc: linux-fbdev@vger.kernel.org Acked-by: Thomas Zimmermann > --- > drivers/video/fbdev/efifb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c > index e57c00824965..b80ba3d2a9b8 100644 > --- a/drivers/video/fbdev/efifb.c > +++ b/drivers/video/fbdev/efifb.c > @@ -139,7 +139,7 @@ static bool efifb_bgrt_sanity_check(struct screen_i= nfo *si, u32 bmp_width) > =20 > static void efifb_show_boot_graphics(struct fb_info *info) > { > - u32 bmp_width, bmp_height, bmp_pitch, screen_pitch, dst_x, y, src_y; > + u32 bmp_width, bmp_height, bmp_pitch, dst_x, y, src_y; > struct screen_info *si =3D &screen_info; > struct bmp_file_header *file_header; > struct bmp_dib_header *dib_header; > @@ -193,7 +193,6 @@ static void efifb_show_boot_graphics(struct fb_info= *info) > bmp_width =3D dib_header->width; > bmp_height =3D abs(dib_header->height); > bmp_pitch =3D round_up(3 * bmp_width, 4); > - screen_pitch =3D si->lfb_linelength; > =20 > if ((file_header->bitmap_offset + bmp_pitch * bmp_height) > > bgrt_image_size) >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --lCVTJBEB2DqM0UFonqvKomR7vvbpzMa9l-- --UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAl/OM14FAwAAAAAACgkQlh/E3EQov+CP IQ/+L432K3gimY1wgKAfFPFLLqwBI8N1N4+Ftj71loVfWxFMiCrL4wkh8OJVRpjntNSz7NuuF7ix vRBDdhQz230JWE6U2+mwXQR2h43j0MNbYF1OqY/tyjPb2dmZz2vt9KkB4989+jCL67CCAxJBezxD kmWyHyFS2NK31vCK5HH1fyhPLDxdOlz7FQ0pnknyuMEojkTpNhPIX0qkVry4xfto+4cLgV9qrtCq icX/6HTHgeXKzlDKxgscab8PYrbC44gsoHTight/Ygor/cXj5IxGZNzmZeOJhyWYcfpN3AousRRm KWvqvzc2fbdgj88Wg7IUd7y9t+gP7yH5hzVf5wtrGB/cnd+4+sP53XmYMgOlh/mNx2zlT8s0VetE CJJFwyqRFDg06xhtlZlLsej1dId13la8yCPm5dZhFPKi/urKqDMuciOAZ1Ak7rWYyT27vwMglBG+ z3QoAi4w50q8ZUNZ3lP0GYN16A+lcHNze11yoY+20QERmicjNMsyKYWVJ7wtBkjeG04ID5nC12Yb sWWq/+R8nPU/FHs/Nzpb1L+way0thOKm+tCA16wonwYYF16qXGFcdGeK4KtI3LeBUwPB63I1DmSm bpZblj7oyFlsbGfqNvxYfxoAGFf6Y5zTysubIuoUsFRET/uRadnB/2FKwWy8bsqlM1XF6wxKA+Cm IIA= =QjfE -----END PGP SIGNATURE----- --UUhWOiX6zSGxJwfPk2Dadgy2X7vakE37Y-- --===============0816718754== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0816718754==--