Re: [PATCH 2/2] drivers: edac: Add EDAC support for Kryo CPU caches

From: Stephen Boyd <swboyd@chromium.org>
To: Evan Green <evgreen@chromium.org>,
	Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
	<devicetree@vger.kernel.org>, Tony Luck <tony.luck@intel.com>,
	psodagud@codeaurora.org,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	tsoni@codeaurora.org, LKML <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Robert Richter <rrichter@marvell.com>,
	Andy Gross <agross@kernel.org>, Borislav Petkov <bp@alien8.de>,
	James Morse <james.morse@arm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	linux-edac@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers: edac: Add EDAC support for Kryo CPU caches
Date: Wed, 11 Dec 2019 14:33:33 -0800	[thread overview]
Message-ID: <5df16ebe.1c69fb81.6481f.a011@mx.google.com> (raw)
In-Reply-To: <CAE=gft5JvCegmrjkKuxYr9dgASPFCkgy97O1XGRyKDF6xT=BMA@mail.gmail.com>

Quoting Evan Green (2019-12-11 11:32:37)
> Hi Sai,
> 
> On Thu, Dec 5, 2019 at 1:53 AM Sai Prakash Ranjan
> <saiprakash.ranjan@codeaurora.org> wrote:
> > diff --git a/drivers/edac/qcom_kryo_edac.c b/drivers/edac/qcom_kryo_edac.c
> > new file mode 100644
> > index 000000000000..05b60ad3cb0e
> > --- /dev/null
> > +++ b/drivers/edac/qcom_kryo_edac.c
> > @@ -0,0 +1,679 @@
[...]
> > +static const struct error_record serror_record[] = {
> > +       { 0x1,  "Errors due to fault injection"         },
> > +       { 0x2,  "ECC error from internal data buffer"   },
> > +       { 0x6,  "ECC error on cache data RAM"           },
> > +       { 0x7,  "ECC error on cache tag or dirty RAM"   },
> > +       { 0x8,  "Parity error on TLB data RAM"          },
> > +       { 0x9,  "Parity error on TLB tag RAM"           },
> > +       { 0x12, "Error response for a cache copyback"   },
> > +       { 0x15, "Deferred error not supported"          },
> > +};
> > +
> > +static const struct error_type err_type[] = {
> > +       { edac_device_handle_ce, "Kryo L1 Corrected Error"      },
> > +       { edac_device_handle_ue, "Kryo L1 Uncorrected Error"    },
> > +       { edac_device_handle_ue, "Kryo L1 Deferred Error"       },
> > +       { edac_device_handle_ce, "Kryo L2 Corrected Error"      },
> > +       { edac_device_handle_ue, "Kryo L2 Uncorrected Error"    },
> > +       { edac_device_handle_ue, "Kryo L2 Deferred Error"       },
> > +       { edac_device_handle_ce, "L3 Corrected Error"           },
> > +       { edac_device_handle_ue, "L3 Uncorrected Error"         },
> > +       { edac_device_handle_ue, "L3 Deferred Error"            },
> > +};
> 
> A comment is warranted to indicate that err_type is indexed by the
> enum, as this would be easy to mess up in later changes.

Instead of a comment please use array indexing.

	[KRYO_L1_CE] = { edac_device_handle_ce, "Kryo L1..." },
	...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel