Re: [dpdk-dev] [EXT] [PATCH 0/8] Optimize qede use of rx/tx_entries

[Igor Russkikh <irusskikh@marvell.com>]

On 3/5/2021 2:13 PM, Balazs Nemeth wrote:
> External Email
> 
> ----------------------------------------------------------------------
> This patch set optimizes qede_{rx,tx}_entry and introduces
> rte_pktmbuf_free_bulk in qede_process_tx_compl. The overall performance
> improvement depends on the use-case; in a physical-virtual-physical test
> on a ThunderX2 99xx system with two SMT threads used in ovs,
> and two cores used in a vm, an improvement of around 2.55% is observed
> due to this patch set.
> 
> Balazs Nemeth (8):
>   net/qede: remove flags from qede_tx_entry and simplify to rte_mbuf
>   net/qede: avoid repeatedly calling ecore_chain_get_cons_idx
>   net/qede: assume txq->sw_tx_ring[idx] is never null in
>     qede_free_tx_pkt
>   net/qede: inline qede_free_tx_pkt to prepare for rte_pktmbuf_free_bulk
>   net/qede: use rte_pktmbuf_free_bulk instead of rte_pktmbuf_free
>   net/qede: prefetch txq->hw_cons_ptr
>   net/qede: prefetch next packet to free
>   net/qede: remove page_offset from struct qede_rx_entry and simplify
> 
>  drivers/net/qede/qede_rxtx.c | 148 +++++++++++++++++++----------------
>  drivers/net/qede/qede_rxtx.h |  21 +----
>  2 files changed, 81 insertions(+), 88 deletions(-)

Series reviewed, for the series

Acked-by: Igor Russkikh <irusskikh@marvell.com>

One checkpatch warn I see in patchwork output, probably worth fixing:

ERROR:POINTER_LOCATION: "(foo**)" should be "(foo **)"
#120: FILE: drivers/net/qede/qede_rxtx.c:56:
+	ret = rte_mempool_get_bulk(rxq->mb_pool, (void**)&rxq->sw_rx_ring[idx], count);

Thanks
  Igor