From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759876AbdAIHhm (ORCPT ); Mon, 9 Jan 2017 02:37:42 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:9383 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbdAIHhi (ORCPT ); Mon, 9 Jan 2017 02:37:38 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f5-f79d06d000004445-da-58733dbd389d Subject: Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board To: Inki Dae , Andi Shyti Cc: Hoegeun Kwon , robh@kernel.org, thierry.reding@gmail.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com, jh80.chung@samsung.com, Donghwa Lee , Hyungwon Hwang From: Andrzej Hajda Message-id: <5df95abe-0d5d-0c48-2840-5996260201de@samsung.com> Date: Mon, 09 Jan 2017 08:37:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 In-reply-to: <586F5728.1010800@samsung.com> Content-transfer-encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMKsWRmVeSWpSXmKPExsWy7djP87p7bYsjDE68FLboPXeSyWL7kWes Fte/PGe1mH/kHJB13s7iytf3bBbvl3exWSyd0cdqMen+BBaLG7/aWC36H79mtjh/fgO7xeVd c9gsZpzfx2Txf88Odoufu+axOAh47Jx1l91j06pONo/t3x6wetzvPs7k0bdlFaPH501yAWxR XDYpqTmZZalF+nYJXBlt2x+xFpwRrrg4+xprA+N1/i5GTg4JAROJ2e1n2CFsMYkL99azgdhC AksZJb79rOpi5AKyPzNKzH96lhGm4e3Ld6wQiWWMEpum7APr4BUQlPgx+R4LiM0soCnx4ssk FoiiZ0Dd/b1gK4QFoiRaf/Qxg9giAh4SO89eYgcpYhaYxCyx5UM/WBEbUPffzTehptpJLNuz BWw1i4CqxPmZ78CaRQUiJA4duw1mcwpoS3y6f4YNYrO8xMErz1kgTv3KLrF6WkwXIweQLSux 6QAzRNhFou3EA6gSYYlXx7dAvS8jcXlyN9jREgLdjBKf+k+wQzhTGCX+fZgB1W0tcfj4RVaI ZXwSk7ZNZ4ZYwCvR0SYEUeIhcazxPDS4HCWuvHjBBAmJVmaJe+sus01glJ+FFGKzkEJsFpIf FjAyr2IUSS0tzk1PLTbVK07MLS7NS9dLzs/dxAhMWqf/Hf+6g3HpMatDjAIcjEo8vBO8iiKE WBPLiitzDzFKcDArifAWWxdHCPGmJFZWpRblxxeV5qQWH2KU5mBREufds+BKuJBAemJJanZq akFqEUyWiYNTqoEx3lgjTYfjcdyD/iymlXK3n3X8Es5UTXrxad1SkTIGB9Nfex+6RJluEeha kpj6Ypl76voSXrM1y3fVd8sFhUd/bH70+bzigS+Xspbwh2822KpbWut0oc2lLuFDt5y2S7Xp k3O7s/uNXvTaL19/n2dvysrH2nN9d4jXb7Lh5X7Uv/fY3Bk5n2qUWIozEg21mIuKEwEQSceE VgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsVy+t/xq7pbbIsjDE7vEbPoPXeSyWL7kWes Fte/PGe1mH/kHJB13s7iytf3bBbvl3exWSyd0cdqMen+BBaLG7/aWC36H79mtjh/fgO7xeVd c9gsZpzfx2Txf88Odoufu+axOAh47Jx1l91j06pONo/t3x6wetzvPs7k0bdlFaPH501yAWxR bjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAOcA9W 0rdLcMto2/6IteCMcMXF2ddYGxiv83cxcnJICJhIvH35jhXCFpO4cG89G4gtJLCEUeLG32IQ m1dAUOLH5HssXYwcHMwC6hJTpuR2MXIBlTxjlGh7NhcsLiwQJfH2ehRIuYiAh8TOs5fYIWpa mSWWf5vGBOIwC0xglljx/TXYMjYBTYm/m2+yQSywk1i2ZwsjiM0ioCpxfuY7ZpChogIREg2H 00HCnALaEp/unwErZxaQlzh45TnLBEaBWUjOm4Vw3iwkVQsYmVcxiqSWFuem5xYb6RUn5haX 5qXrJefnbmIERu62Yz+37GDsehd8iFGAg1GJh3eCV1GEEGtiWXFl7iFGCQ5mJRHeYuviCCHe lMTKqtSi/Pii0pzU4kOMpkCnTmSWEk3OByaVvJJ4QxNDc0tDI2MLC3MjIyVx3qkfroQLCaQn lqRmp6YWpBbB9DFxcEo1MLZ0WLdE8Wj9la7N3/PqytbJk/l75s2N/zz9YN+y8x32MocuOImc KJFK0QpiEfn0Jn7/4gh5qzsPj56JXnsg7lm6fDLf6qO7zv5Z+Gz7vGly565eYTzdm+Yw7afR xt1xC/je5Po0mfx/Y6q5PmN7/MUjbi/ad4l98H74dz/LqUgrLo+rifO3yT9TYinOSDTUYi4q TgQA6cw34PICAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170109073732eucas1p2b7ce168c9ddd9e50afab4a98d81da886 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QW5kcnplaiBIYWpkYRtTUlBPTC1LZXJuZWwgKFRQKRtTYW1z?= =?UTF-8?B?dW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170105102012epcas1p4ddeb577ea84b5c2cdf7029666b2091c1 X-RootMTR: 20170105102012epcas1p4ddeb577ea84b5c2cdf7029666b2091c1 References: <1483611609-23522-1-git-send-email-hoegeun.kwon@samsung.com> <1483611609-23522-4-git-send-email-hoegeun.kwon@samsung.com> <20170106052239.5prkyj3v4x4qcc46@gangnam.samsung> <586F2BF3.8080400@samsung.com> <20170106081806.h4y7o57kjbibau6l@gangnam.samsung> <586F5728.1010800@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.01.2017 09:36, Inki Dae wrote: > > 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >> Hi Inki, >> >> Thanks for the reply, but... >> >>>>> +static const struct drm_display_mode default_mode = { >>>>> + .clock = 222372, >>>>> + .hdisplay = 1440, >>>>> + .hsync_start = 1440 + 1, >>>>> + .hsync_end = 1440 + 1 + 1, >>>>> + .htotal = 1440 + 1 + 1 + 1, >>>>> + .vdisplay = 2560, >>>>> + .vsync_start = 2560 + 1, >>>>> + .vsync_end = 2560 + 1 + 1, >>>>> + .vtotal = 2560 + 1 + 1 + 15, >>>>> + .vrefresh = 60, >>>>> + .flags = 0, >>>>> +}; >>>> how is this working with tm2e? Are these values valid for both >>>> the boards? >>> We don't need to consider tm2e board with two reasones, >>> 1. there is no tm2e board support in mainline >>> 2. the panel on tm2 would be a little bit different from one on tm2e >> ... this display in the Tizen Kernel is supported by both: >> tm2 [1] and tm2e [2]. The only differences are: > Why tm2e dts file is in mainline? Seems communication miss with Chanwoo. :( > >> TM2: >> clock-frequency = <14874444>; >> hactive = <1440>; >> >> TM2E: >> clock-frequency = <16523724>; >> hactive = <1600>; >> >> I don't know much about the differences you mention in point 2, >> but it's a pity to drop support only because we don't want to put >> in the dts the 'hactive', and 'clock-frequency' properties. > Anyway, tm2e board is already in mainline so Panel driver may need to identify what kinds of panel is probed to decide porch values. I think there are relevant registers in MCU of the Panel device to check version or similar thing. I think we can safely use different compatible string for tm2e - it uses different display IC controller - s6e3hf2, driver will provide timings based on it. As far as I examined available specs/docs there is no reliable register which can be used to safely distinguish it on runtime, but the docs I have are far from completeness. Regards Andrzej > > Thanks. > >> Andi >> >> [1] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts?h=tizen#n1284 >> [2] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts?h=tizen#n1270 >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> . >> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH v7 3/4] drm/panel: Add support for S6E3HA2 panel driver on TM2 board Date: Mon, 09 Jan 2017 08:37:25 +0100 Message-ID: <5df95abe-0d5d-0c48-2840-5996260201de@samsung.com> References: <1483611609-23522-1-git-send-email-hoegeun.kwon@samsung.com> <1483611609-23522-4-git-send-email-hoegeun.kwon@samsung.com> <20170106052239.5prkyj3v4x4qcc46@gangnam.samsung> <586F2BF3.8080400@samsung.com> <20170106081806.h4y7o57kjbibau6l@gangnam.samsung> <586F5728.1010800@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-reply-to: <586F5728.1010800-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Inki Dae , Andi Shyti Cc: Hoegeun Kwon , robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, jh80.chung-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, Donghwa Lee , Hyungwon Hwang List-Id: devicetree@vger.kernel.org On 06.01.2017 09:36, Inki Dae wrote: > > 2017년 01월 06일 17:18에 Andi Shyti 이(가) 쓴 글: >> Hi Inki, >> >> Thanks for the reply, but... >> >>>>> +static const struct drm_display_mode default_mode = { >>>>> + .clock = 222372, >>>>> + .hdisplay = 1440, >>>>> + .hsync_start = 1440 + 1, >>>>> + .hsync_end = 1440 + 1 + 1, >>>>> + .htotal = 1440 + 1 + 1 + 1, >>>>> + .vdisplay = 2560, >>>>> + .vsync_start = 2560 + 1, >>>>> + .vsync_end = 2560 + 1 + 1, >>>>> + .vtotal = 2560 + 1 + 1 + 15, >>>>> + .vrefresh = 60, >>>>> + .flags = 0, >>>>> +}; >>>> how is this working with tm2e? Are these values valid for both >>>> the boards? >>> We don't need to consider tm2e board with two reasones, >>> 1. there is no tm2e board support in mainline >>> 2. the panel on tm2 would be a little bit different from one on tm2e >> ... this display in the Tizen Kernel is supported by both: >> tm2 [1] and tm2e [2]. The only differences are: > Why tm2e dts file is in mainline? Seems communication miss with Chanwoo. :( > >> TM2: >> clock-frequency = <14874444>; >> hactive = <1440>; >> >> TM2E: >> clock-frequency = <16523724>; >> hactive = <1600>; >> >> I don't know much about the differences you mention in point 2, >> but it's a pity to drop support only because we don't want to put >> in the dts the 'hactive', and 'clock-frequency' properties. > Anyway, tm2e board is already in mainline so Panel driver may need to identify what kinds of panel is probed to decide porch values. I think there are relevant registers in MCU of the Panel device to check version or similar thing. I think we can safely use different compatible string for tm2e - it uses different display IC controller - s6e3hf2, driver will provide timings based on it. As far as I examined available specs/docs there is no reliable register which can be used to safely distinguish it on runtime, but the docs I have are far from completeness. Regards Andrzej > > Thanks. > >> Andi >> >> [1] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts?h=tizen#n1284 >> [2] https://git.tizen.org/cgit/platform/kernel/linux-exynos/tree/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts?h=tizen#n1270 >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> . >> > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html