From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Jens Axboe <axboe@kernel.dk>,
kernel-team@fb.com, Stefan Roesch <shr@fb.com>,
io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: viro@zeniv.linux.org.uk
Subject: Re: [PATCH v3 0/2] io-uring: Make statx api stable
Date: Thu, 24 Feb 2022 13:47:14 +0100 [thread overview]
Message-ID: <5e0084b9-0090-c2a6-ab64-58fd1887d95f@samsung.com> (raw)
In-Reply-To: <164555550976.110748.6933069169641927964.b4-ty@kernel.dk>
Hi,
On 22.02.2022 19:45, Jens Axboe wrote:
> On Tue, 15 Feb 2022 10:03:26 -0800, Stefan Roesch wrote:
>> One of the key architectual tenets of io-uring is to keep the
>> parameters for io-uring stable. After the call has been submitted,
>> its value can be changed. Unfortunaltely this is not the case for
>> the current statx implementation.
>>
>> Patches:
>> Patch 1: fs: replace const char* parameter in vfs_statx and do_statx with
>> struct filename
>> Create filename object outside of do_statx and vfs_statx, so io-uring
>> can create the filename object during the prepare phase
>>
>> [...]
> Applied, thanks!
>
> [1/2] fs: replace const char* parameter in vfs_statx and do_statx with struct filename
> commit: 30512d54fae354a2359a740b75a1451b68aa3807
> [2/2] io-uring: Copy path name during prepare stage for statx
> commit: 1e0561928e3ab5018615403a2a1293e1e44ee03e
Those 2 commits landed in todays Linux next-20220223. They affect
userspace in a way that breaks systemd opration:
...
Freeing unused kernel image (initmem) memory: 1024K
Run /sbin/init as init process
systemd[1]: System time before build time, advancing clock.
systemd[1]: Cannot be run in a chroot() environment.
systemd[1]: Freezing execution.
Reverting them on top of next-20220223 fixes the boot issue. Btw, those
patches are not bisectable. The code at
30512d54fae354a2359a740b75a1451b68aa3807 doesn't compile.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2022-02-24 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 18:03 [PATCH v3 0/2] io-uring: Make statx api stable Stefan Roesch
2022-02-15 18:03 ` [PATCH v3 1/2] fs: replace const char* parameter in vfs_statx and do_statx with struct filename Stefan Roesch
2022-02-15 18:03 ` [PATCH v3 2/2] io-uring: Copy path name during prepare stage for statx Stefan Roesch
2022-02-18 16:15 ` [PATCH v3 0/2] io-uring: Make statx api stable Jens Axboe
2022-02-22 18:45 ` Jens Axboe
2022-02-22 18:45 ` Jens Axboe
[not found] ` <CGME20220224124715eucas1p2a7d1b7f2a5131ef1dd5b8280c1d3749b@eucas1p2.samsung.com>
2022-02-24 12:47 ` Marek Szyprowski [this message]
2022-02-24 14:09 ` Jens Axboe
2022-02-25 1:27 ` Qian Cai
2022-02-26 1:22 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0084b9-0090-c2a6-ab64-58fd1887d95f@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=shr@fb.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.