From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Joerg Roedel <joro@8bytes.org>, Jim Mattson <jmattson@google.com>,
Wanpeng Li <wanpengli@tencent.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: mmu: Fix SPTE encoding of MMIO generation upper half
Date: Wed, 9 Dec 2020 10:08:47 +0100 [thread overview]
Message-ID: <5e1dc1cd-b175-86be-b33e-0456ecbd50e8@redhat.com> (raw)
In-Reply-To: <X8/sWzYUjuEYwCuf@google.com>
On 08/12/20 22:12, Sean Christopherson wrote:
>> #define MMIO_SPTE_GEN_MASK GENMASK_ULL(MMIO_SPTE_GEN_LOW_BITS + MMIO_SPTE_GEN_HIGH_BITS - 1, 0)
> What if we leave MMIO_SPTE_GEN_MASK as is, GENMASK_ULL(17, 0), and instead add a
> BUILD_BUG_ON() to assert that it matches the above logic? It's really easy to
> get lost when reading through the chain of defines, I find the explicit mask
> helps provide an anchor/reference for understand what's going on. It'll require
> an update if/when PT64_SECOND_AVAIL_BITS_SHIFT, but that's not necessarily a bad
> thing, e.g. the comment above this block will also be stale.
Sounds good.
Paolo
next prev parent reply other threads:[~2020-12-09 9:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 0:48 [PATCH] KVM: mmu: Fix SPTE encoding of MMIO generation upper half Maciej S. Szmigiero
2020-12-06 10:09 ` Paolo Bonzini
2020-12-06 15:53 ` Maciej S. Szmigiero
2020-12-08 21:12 ` Sean Christopherson
2020-12-09 9:08 ` Paolo Bonzini [this message]
2020-12-14 14:16 FAILED: patch "[PATCH] KVM: mmu: Fix SPTE encoding of MMIO generation upper half" failed to apply to 5.9-stable tree gregkh
2020-12-17 13:46 ` [PATCH] KVM: mmu: Fix SPTE encoding of MMIO generation upper half Maciej S. Szmigiero
2020-12-17 14:21 ` Paolo Bonzini
2020-12-14 14:16 FAILED: patch "[PATCH] KVM: mmu: Fix SPTE encoding of MMIO generation upper half" failed to apply to 5.4-stable tree gregkh
2020-12-17 13:46 ` [PATCH] KVM: mmu: Fix SPTE encoding of MMIO generation upper half Maciej S. Szmigiero
2020-12-17 14:21 ` Paolo Bonzini
2020-12-19 12:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e1dc1cd-b175-86be-b33e-0456ecbd50e8@redhat.com \
--to=pbonzini@redhat.com \
--cc=corbet@lwn.net \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=seanjc@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.