From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C2CC433DB for ; Sun, 14 Mar 2021 20:46:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7AD364E51 for ; Sun, 14 Mar 2021 20:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234119AbhCNUp5 (ORCPT ); Sun, 14 Mar 2021 16:45:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234224AbhCNUpf (ORCPT ); Sun, 14 Mar 2021 16:45:35 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A720AC061574 for ; Sun, 14 Mar 2021 13:45:34 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1lLXc3-00G7P7-U5; Sun, 14 Mar 2021 21:45:24 +0100 Message-ID: <5e1f64997ffca8267bde7955fe2eb214dfb9e891.camel@sipsolutions.net> Subject: Re: [RFC v8 13/20] um: lkl: integrate with irq infrastructure of UML From: Johannes Berg To: Hajime Tazaki , linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com Cc: tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com Date: Sun, 14 Mar 2021 21:45:23 +0100 In-Reply-To: <46935454bf02224fb325f0e74d60d0ed674a59f9.1611103406.git.thehajime@gmail.com> References: <46935454bf02224fb325f0e74d60d0ed674a59f9.1611103406.git.thehajime@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Wed, 2021-01-20 at 11:27 +0900, Hajime Tazaki wrote: >  static irqreturn_t um_timer(int irq, void *dev) >  { > +#ifndef CONFIG_UMMODE_LIB >   if (get_current()->mm != NULL) Why is the ifdef needed - get_current()->mm should always be NULL for LKL? Surely get_current() must still work? >   sigemptyset(&sig_mask); >   sigaddset(&sig_mask, sig); > - if (sigprocmask(SIG_UNBLOCK, &sig_mask, NULL) < 0) > - panic("sigprocmask failed - errno = %d\n", errno); > + if (pthread_sigmask(SIG_UNBLOCK, &sig_mask, NULL) < 0) > + panic("pthread_sigmask failed - errno = %d\n", errno); UML doesn't normally link with libpthread, and LKL doesn't actually appear to require it either (since it has its lkl_thread and all), so this seems wrong? johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lLXc7-00EWjE-CP for linux-um@lists.infradead.org; Sun, 14 Mar 2021 20:45:34 +0000 Message-ID: <5e1f64997ffca8267bde7955fe2eb214dfb9e891.camel@sipsolutions.net> Subject: Re: [RFC v8 13/20] um: lkl: integrate with irq infrastructure of UML From: Johannes Berg Date: Sun, 14 Mar 2021 21:45:23 +0100 In-Reply-To: <46935454bf02224fb325f0e74d60d0ed674a59f9.1611103406.git.thehajime@gmail.com> References: <46935454bf02224fb325f0e74d60d0ed674a59f9.1611103406.git.thehajime@gmail.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Hajime Tazaki , linux-um@lists.infradead.org, jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com Cc: tavi.purdila@gmail.com, linux-kernel-library@freelists.org, linux-arch@vger.kernel.org, retrage01@gmail.com T24gV2VkLCAyMDIxLTAxLTIwIGF0IDExOjI3ICswOTAwLCBIYWppbWUgVGF6YWtpIHdyb3RlOgo+ IMKgc3RhdGljIGlycXJldHVybl90IHVtX3RpbWVyKGludCBpcnEsIHZvaWQgKmRldikKPiDCoHsK PiArI2lmbmRlZiBDT05GSUdfVU1NT0RFX0xJQgo+IMKgCWlmIChnZXRfY3VycmVudCgpLT5tbSAh PSBOVUxMKQoKV2h5IGlzIHRoZSBpZmRlZiBuZWVkZWQgLSBnZXRfY3VycmVudCgpLT5tbSBzaG91 bGQgYWx3YXlzIGJlIE5VTEwgZm9yCkxLTD8gU3VyZWx5IGdldF9jdXJyZW50KCkgbXVzdCBzdGls bCB3b3JrPwoKPiDCoAlzaWdlbXB0eXNldCgmc2lnX21hc2spOwo+IMKgCXNpZ2FkZHNldCgmc2ln X21hc2ssIHNpZyk7Cj4gLQlpZiAoc2lncHJvY21hc2soU0lHX1VOQkxPQ0ssICZzaWdfbWFzaywg TlVMTCkgPCAwKQo+IC0JCXBhbmljKCJzaWdwcm9jbWFzayBmYWlsZWQgLSBlcnJubyA9ICVkXG4i LCBlcnJubyk7Cj4gKwlpZiAocHRocmVhZF9zaWdtYXNrKFNJR19VTkJMT0NLLCAmc2lnX21hc2ss IE5VTEwpIDwgMCkKPiArCQlwYW5pYygicHRocmVhZF9zaWdtYXNrIGZhaWxlZCAtIGVycm5vID0g JWRcbiIsIGVycm5vKTsKClVNTCBkb2Vzbid0IG5vcm1hbGx5IGxpbmsgd2l0aCBsaWJwdGhyZWFk LCBhbmQgTEtMIGRvZXNuJ3QgYWN0dWFsbHkKYXBwZWFyIHRvIHJlcXVpcmUgaXQgZWl0aGVyIChz aW5jZSBpdCBoYXMgaXRzIGxrbF90aHJlYWQgYW5kIGFsbCksIHNvCnRoaXMgc2VlbXMgd3Jvbmc/ Cgpqb2hhbm5lcwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LXVtIG1haWxpbmcgbGlzdApsaW51eC11bUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtdW0K