From: Jan Beulich <jbeulich@suse.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
Luca Fancellu <luca.fancellu@arm.com>
Cc: xen-devel@lists.xenproject.org, bertrand.marquis@arm.com,
wei.chen@arm.com, Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>, Julien Grall <julien@xen.org>,
Wei Liu <wl@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH 2/2] arm/efi: Use dom0less configuration when using EFI boot
Date: Thu, 16 Sep 2021 08:50:02 +0200 [thread overview]
Message-ID: <5e272a26-e1f7-a861-feb1-350293a9f809@suse.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2109151721210.21985@sstabellini-ThinkPad-T480s>
On 16.09.2021 03:16, Stefano Stabellini wrote:
> On Wed, 15 Sep 2021, Luca Fancellu wrote:
>> +static void __init handle_dom0less_domain_node(EFI_FILE_HANDLE dir_handle,
>> + int domain_node,
>> + int addr_cells,
>> + int size_cells)
>> +{
>> + /*
>> + * Check for nodes compatible with multiboot,{kernel,ramdisk,device-tree}
>> + * inside this node
>> + */
>> + for ( int module_node = fdt_first_subnode(fdt, domain_node);
>
> int module_node;
>
> for ( module_node = fdt_first_subnode(fdt, domain_node);
Not just here iirc from briefly looking over the patch as a whole
yesterday: Use of plain "int" would better be limited to cases where
values may also be negative. I don't suppose that's possible here as
well as in a number of other cases.
>> @@ -1285,14 +1286,21 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable)
>> efi_bs->FreePool(name.w);
>> }
>>
>> - if ( !name.s )
>> - blexit(L"No Dom0 kernel image specified.");
>> -
>> efi_arch_cfg_file_early(loaded_image, dir_handle, section.s);
>>
>> - option_str = split_string(name.s);
>> +#ifdef CONFIG_ARM
>> + /* dom0less feature is supported only on ARM */
>> + dom0less_found = check_dom0less_efi_boot(dir_handle);
>> +#endif
>
> Rather than an #ifdef here you can simply implement
> check_dom0less_efi_boot on x86 as a static inline returning always
> false.
Indeed, and the properly named (efi_arch_...()).
Jan
next prev parent reply other threads:[~2021-09-16 6:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 14:26 [PATCH 0/2] arm/efi: Add dom0less support to UEFI boot Luca Fancellu
2021-09-15 14:26 ` [PATCH 1/2] xen/efi: Restrict check for DT boot modules on EFI boot Luca Fancellu
2021-09-16 0:16 ` Stefano Stabellini
2021-09-16 6:45 ` Jan Beulich
2021-09-16 11:54 ` Luca Fancellu
2021-09-15 14:26 ` [PATCH 2/2] arm/efi: Use dom0less configuration when using " Luca Fancellu
2021-09-16 1:16 ` Stefano Stabellini
2021-09-16 6:50 ` Jan Beulich [this message]
2021-09-16 11:15 ` Luca Fancellu
2021-09-16 12:03 ` Luca Fancellu
2021-09-18 0:06 ` Stefano Stabellini
2021-09-16 8:46 ` Jan Beulich
2021-09-16 11:28 ` Luca Fancellu
2021-09-16 12:15 ` Jan Beulich
2021-09-16 15:07 ` Luca Fancellu
2021-09-16 15:10 ` Jan Beulich
2021-09-16 20:16 ` Stefano Stabellini
2021-09-17 6:44 ` Jan Beulich
2021-09-17 11:11 ` Luca Fancellu
2021-09-17 22:33 ` Stefano Stabellini
2021-09-21 9:38 ` Luca Fancellu
2021-09-21 21:34 ` Stefano Stabellini
2021-09-22 9:03 ` Luca Fancellu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e272a26-e1f7-a861-feb1-350293a9f809@suse.com \
--to=jbeulich@suse.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=julien@xen.org \
--cc=luca.fancellu@arm.com \
--cc=sstabellini@kernel.org \
--cc=wei.chen@arm.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.