All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhangfei <zhangfei.gao@linaro.org>
To: John Garry <john.garry@huawei.com>,
	jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: linuxarm@huawei.com, xuwei5@hisilicon.com,
	john.garry2@mail.dcu.ie, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org, hanjun.guo@linaro.org
Subject: Re: [PATCH 2/3] scsi: hisi_sas: lock sensitive regions when servicing CQ interrupt
Date: Wed, 4 Jan 2017 09:19:51 +0800	[thread overview]
Message-ID: <5e36ec8b-fc52-3f9c-4a34-9b3c8c2efa6e@linaro.org> (raw)
In-Reply-To: <1483446290-185084-3-git-send-email-john.garry@huawei.com>



On 2017年01月03日 20:24, John Garry wrote:
> There is a bug in the current driver in that certain hisi_hba
> and port structure elements which we access when servicing
> the CQ interrupt do not use thread-safe accesses; these include
> hisi_sas_port linked-list of active slots (hisi_sas_port.entry),
> bitmap of currently allocated IPTT (in hisi_hba.slot_index_tags),
> and completion queue read pointer.
>
> As a solution, lock these elements with the hisi_hba.lock.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> Reviewed-by: Xiang Chen <chenxiang66@hisilicon.com>
Reviewed-by: Zhangfei Gao <zhangfei.gao@linaro.org>

  reply	other threads:[~2017-01-04  1:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03 12:24 [PATCH 0/3] hisi_sas: some CQ processing fixes John Garry
2017-01-03 12:24 ` John Garry
2017-01-03 12:24 ` [PATCH 1/3] scsi: hisi_sas: service v2 hw CQ ISR with tasklet John Garry
2017-01-03 12:24   ` John Garry
2017-01-04  1:18   ` zhangfei
2017-01-03 12:24 ` [PATCH 2/3] scsi: hisi_sas: lock sensitive regions when servicing CQ interrupt John Garry
2017-01-03 12:24   ` John Garry
2017-01-04  1:19   ` zhangfei [this message]
2017-01-03 12:24 ` [PATCH 3/3] scsi: hisi_sas: lock sensitive region in hisi_sas_slot_abort() John Garry
2017-01-03 12:24   ` John Garry
2017-01-04  1:20   ` zhangfei
2017-01-04  2:14 ` [PATCH 0/3] hisi_sas: some CQ processing fixes Hanjun Guo
2017-01-05 23:22 ` Martin K. Petersen
2017-01-05 23:22   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e36ec8b-fc52-3f9c-4a34-9b3c8c2efa6e@linaro.org \
    --to=zhangfei.gao@linaro.org \
    --cc=hanjun.guo@linaro.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=john.garry2@mail.dcu.ie \
    --cc=john.garry@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    --cc=xuwei5@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.