From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA89C433ED for ; Sat, 15 May 2021 16:16:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC72361059 for ; Sat, 15 May 2021 16:16:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC72361059 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38100 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhwy4-0004LL-Qo for qemu-devel@archiver.kernel.org; Sat, 15 May 2021 12:16:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhwwS-00037X-Kv for qemu-devel@nongnu.org; Sat, 15 May 2021 12:15:04 -0400 Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]:43921) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhwwQ-0001cC-Up for qemu-devel@nongnu.org; Sat, 15 May 2021 12:15:04 -0400 Received: by mail-qt1-x829.google.com with SMTP id c10so1850343qtx.10 for ; Sat, 15 May 2021 09:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=70v79L9nH49yNdd9ahFj7djnVgJ382qZ9CjA+s2HK2E=; b=aWhDmzPOduzyzNBiwKa5KZfA3tqrk78Oz+49GFhx170xekCcCYFHqw1w7++TABLIaG tAHke5KL5PEHPFOdjDqXvHxwChe5Wefm+JcXWkaUGe55seQUjQ1adpz+kVuootnao9ed TmSsx1Ddb6HHF/amH20zvFeYz/H5MZcPiBSxIk9o+y4NhORLWlL/vfnWHUyPCwgUAHZJ R2LFkdtRGjDWX62F8OUHqUFQM789gw+AP8Bd5ItacTYEI2IYohgteZ/wS/0KU7xD2BA3 A25hDGaLtPhyi/lVRNihccSL/YW5HF9+YjjO8/g/fevPlk8/qP0NsTj4S+miV1ikcDCd oVpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=70v79L9nH49yNdd9ahFj7djnVgJ382qZ9CjA+s2HK2E=; b=XgCMsWh+Pl40jFJ1aZNT+c7e2hVpl2AvhMlwq20lW+0RPux0HG6k/OzLm2I4UsVjVl 1r4AG/kTRxTwb9fs0HEcrmiI2SEv541E/jHwPHctVmb9zSbCeEetIygfvIQKwjpq7eiG /5f2Mu9IOAItMrfuAr6jwgMqJwYDve97TeRRVrqQ5eBy8raWseqS8EBYAopZ84ym6LNe ALHve6xaC7K/edIfTymYFrhjH4F5uFtQ06YXSnldJWiNFHKVKktHDGPwqyC0aJ2bOcrv ASBbovNEcfeaZAlV/WVtcbiN8xBwlaIvb4GsniTCFmS8PXO+WIPwQ1rdN0SiZrtzi+A2 Nqng== X-Gm-Message-State: AOAM532W91D8mYTC9tW+LrTMZYj2t2UIYfPS89ww1k6uKfasS9pCNwGU IbTgXLWWZLAmSvwdq2AMiGpd2Q== X-Google-Smtp-Source: ABdhPJxlXMPidMwQx5nOO5dGXxj+mt7B4+fTO+KuTwkTRJrK/X7VbrRHaGW18ORih8+KDAVJM2YqhA== X-Received: by 2002:ac8:7ee8:: with SMTP id r8mr47530703qtc.56.1621095301457; Sat, 15 May 2021 09:15:01 -0700 (PDT) Received: from [192.168.183.51] (163.189-204-200.bestelclientes.com.mx. [189.204.200.163]) by smtp.gmail.com with ESMTPSA id c20sm7015920qtm.52.2021.05.15.09.15.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 May 2021 09:15:00 -0700 (PDT) Subject: Re: [PATCH v6 68/82] target/arm: Implement SVE2 FLOGB To: Peter Maydell References: <20210430202610.1136687-1-richard.henderson@linaro.org> <20210430202610.1136687-69-richard.henderson@linaro.org> From: Richard Henderson Message-ID: <5e4417b1-3a2b-809d-530c-65e8ba05591d@linaro.org> Date: Sat, 15 May 2021 11:14:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::829; envelope-from=richard.henderson@linaro.org; helo=mail-qt1-x829.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm , QEMU Developers , Stephen Long Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/13/21 9:18 AM, Peter Maydell wrote: >> +static int64_t do_float64_logb_as_int(float64 a, float_status *s) >> +{ >> + if (float64_is_normal(a)) { >> + return extract64(a, 52, 11) - 1023; >> + } else if (float64_is_infinity(a)) { >> + return INT64_MAX; >> + } else if (float64_is_any_nan(a) || float64_is_zero(a)) { >> + float_raise(float_flag_invalid, s); >> + return INT64_MIN; >> + } else { >> + /* denormal (see above) */ >> + return -1023 + 12 - clz64(extract64(a, 0, 52)); >> + } >> +} > > These don't look like they're handling denormal inputs quite right: > * should raise the input-denormal exception > * should flush-to-zero if that is enabled Yep, thanks. r~