From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8829C433F5 for ; Sat, 11 Dec 2021 12:25:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229690AbhLKMZr (ORCPT ); Sat, 11 Dec 2021 07:25:47 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:37279 "EHLO wout4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbhLKMZq (ORCPT ); Sat, 11 Dec 2021 07:25:46 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id A0FED3202113; Sat, 11 Dec 2021 07:25:45 -0500 (EST) Received: from imap47 ([10.202.2.97]) by compute3.internal (MEProxy); Sat, 11 Dec 2021 07:25:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=mime-version:message-id:in-reply-to:references:date:from:to :cc:subject:content-type; s=fm3; bh=OzRlwblfRtifXV8144XMgBQKpWaQ Rjph72PC94YxvGk=; b=WGg59/Kv9iRA7pHUuj+ok9EcUhO+gRRYXStN/ZSZtpPY 2OxNUuTumqvu6U4LeCg4aAUZgSBpSkd5jWFfzkkNd5ueZ/0dcP8ajKJOItJ2/sR/ kb61dzU+xVDlUgOAY4tPx1R54ylJ5+cG3gqx1GTt8KrVNjU934p7hVF1R8EZSP1+ i7aES3BV5PlZmQN3VDbvbrLgnhn7HcPYIMjGpnx/ayWDApV5nACpgOnQ/QXDVYSy Ut1i9A9KSwpxvgbxVlVQyBtwXXeCL+cJZoRHlv6udBaflV/bGyJf1VU7sJeggb+y yNS0D7LzPvJ2rirw7RZMnHB3HJWkPyediIanERvLqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=OzRlwb lfRtifXV8144XMgBQKpWaQRjph72PC94YxvGk=; b=O8fUqk4mIX1SLnZ5kQLxW4 V/TzJWPrejHlZTld7V6LxOpD1SlSmVIOEmxVvJvTVQ6bRkEaLgIQzFU5YRQpvQHX gCN4+Kg+40wAvYeSKJvBGfj8C3bgAmaLJ2Cn+8PFqJlZZD4VJKcAf/JkKZLwDCke XmLaMfzrCF2KlenYSt3PMMmZeuPwdA9OI0yZ91AnJ03nsqWYKGztsCYxBmdP4jnI BlpeUuL80iQduTPOaPOl66C//VMbSTjH2BrhELRFvD4i75jAsg4fWVifgv63fjgr pELpkD0dxnZ0sHOuutx8C5hVfbpZAo/bEOOcGduA6LAKAfuIkKz41UYSGsMtF9sw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrkeeggdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfufhvvghn ucfrvghtvghrfdcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrfgrth htvghrnhepgfeigeeiffeuhfettdejgfetjeetfeelfefgfefgvddvtdfghfffudehvdef keffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh hvvghnsehsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 80D8F274050D; Sat, 11 Dec 2021 07:25:44 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4514-g2bdc19e04f-fm-20211209.002-g2bdc19e0 Mime-Version: 1.0 Message-Id: <5e465c3c-a12f-4131-87dd-adb7ec8ed5b5@www.fastmail.com> In-Reply-To: <20211209044501.67028-4-marcan@marcan.st> References: <20211209044501.67028-1-marcan@marcan.st> <20211209044501.67028-4-marcan@marcan.st> Date: Sat, 11 Dec 2021 13:24:45 +0100 From: "Sven Peter" To: "Hector Martin" , "Rob Herring" Cc: "Mark Kettenis" , "Alyssa Rosenzweig" , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: apple: t8103: Add apple,min-ps to DCP PMGR nodes Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Dec 9, 2021, at 05:45, Hector Martin wrote: > This is required for DCP to boot successfully; it seems if power gating > is allowed, they do not wake up properly. > > Signed-off-by: Hector Martin Reviewed-by: Sven Peter > --- > arch/arm64/boot/dts/apple/t8103-pmgr.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi > b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi > index 1310be74df1d..fc51bc872468 100644 > --- a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi > +++ b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi > @@ -665,6 +665,7 @@ ps_dispext_cpu0: power-controller@378 { > #reset-cells = <0>; > label = "dispext_cpu0"; > power-domains = <&ps_dispext_fe>; > + apple,min-state = <4>; > }; > > ps_jpg: power-controller@3c0 { > @@ -1005,6 +1006,7 @@ ps_disp0_cpu0: power-controller@10018 { > label = "disp0_cpu0"; > power-domains = <&ps_disp0_fe>; > apple,always-on; /* TODO: figure out if we can enable PM here */ > + apple,min-state = <4>; > }; > }; > > -- > 2.33.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 850A3C433F5 for ; Sat, 11 Dec 2021 12:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fIg6sBwJNFICfemgr7yMZOkD5agtetR4MbBY+FQE/Z8=; b=pRwX0x2NSHixLA FA0oGLPlgg+NZ9yuzIF0L5xAXEw2k9+ICRNGuSFAg4igbL91/eDLaJ8k9atT8CuyxeDtmQUCt0HA6 ojtjpzrQoZPQAHb+K6DPvl5rqNuetdGdA+/wMimnhtJfmwo/k9lYRN4qSYabpi8m12hfyDdEqndsH jYY9zAOOqe5PKwlzg+M0+FgsseWFv+oSQMc+XmM5r86E8He2/lmzC7/i7eUBMnHecZb4e4dCd2EKp sQHswy63VsPR8HFZo8ocjaLDNah66uLmmoorxrK5Y0VhnFuU/Zbwv7CTjMPby/KitIY35q4u1YXld n3u6pIlXxpEOiECt+RdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mw1Rq-004zHT-85; Sat, 11 Dec 2021 12:25:54 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mw1Rn-004zH2-81 for linux-arm-kernel@lists.infradead.org; Sat, 11 Dec 2021 12:25:52 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id A0FED3202113; Sat, 11 Dec 2021 07:25:45 -0500 (EST) Received: from imap47 ([10.202.2.97]) by compute3.internal (MEProxy); Sat, 11 Dec 2021 07:25:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=mime-version:message-id:in-reply-to:references:date:from:to :cc:subject:content-type; s=fm3; bh=OzRlwblfRtifXV8144XMgBQKpWaQ Rjph72PC94YxvGk=; b=WGg59/Kv9iRA7pHUuj+ok9EcUhO+gRRYXStN/ZSZtpPY 2OxNUuTumqvu6U4LeCg4aAUZgSBpSkd5jWFfzkkNd5ueZ/0dcP8ajKJOItJ2/sR/ kb61dzU+xVDlUgOAY4tPx1R54ylJ5+cG3gqx1GTt8KrVNjU934p7hVF1R8EZSP1+ i7aES3BV5PlZmQN3VDbvbrLgnhn7HcPYIMjGpnx/ayWDApV5nACpgOnQ/QXDVYSy Ut1i9A9KSwpxvgbxVlVQyBtwXXeCL+cJZoRHlv6udBaflV/bGyJf1VU7sJeggb+y yNS0D7LzPvJ2rirw7RZMnHB3HJWkPyediIanERvLqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=OzRlwb lfRtifXV8144XMgBQKpWaQRjph72PC94YxvGk=; b=O8fUqk4mIX1SLnZ5kQLxW4 V/TzJWPrejHlZTld7V6LxOpD1SlSmVIOEmxVvJvTVQ6bRkEaLgIQzFU5YRQpvQHX gCN4+Kg+40wAvYeSKJvBGfj8C3bgAmaLJ2Cn+8PFqJlZZD4VJKcAf/JkKZLwDCke XmLaMfzrCF2KlenYSt3PMMmZeuPwdA9OI0yZ91AnJ03nsqWYKGztsCYxBmdP4jnI BlpeUuL80iQduTPOaPOl66C//VMbSTjH2BrhELRFvD4i75jAsg4fWVifgv63fjgr pELpkD0dxnZ0sHOuutx8C5hVfbpZAo/bEOOcGduA6LAKAfuIkKz41UYSGsMtF9sw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrkeeggdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfufhvvghn ucfrvghtvghrfdcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrfgrth htvghrnhepgfeigeeiffeuhfettdejgfetjeetfeelfefgfefgvddvtdfghfffudehvdef keffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh hvvghnsehsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 80D8F274050D; Sat, 11 Dec 2021 07:25:44 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-4514-g2bdc19e04f-fm-20211209.002-g2bdc19e0 Mime-Version: 1.0 Message-Id: <5e465c3c-a12f-4131-87dd-adb7ec8ed5b5@www.fastmail.com> In-Reply-To: <20211209044501.67028-4-marcan@marcan.st> References: <20211209044501.67028-1-marcan@marcan.st> <20211209044501.67028-4-marcan@marcan.st> Date: Sat, 11 Dec 2021 13:24:45 +0100 From: "Sven Peter" To: "Hector Martin" , "Rob Herring" Cc: "Mark Kettenis" , "Alyssa Rosenzweig" , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] arm64: dts: apple: t8103: Add apple, min-ps to DCP PMGR nodes X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211211_042551_345606_462502C9 X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 9, 2021, at 05:45, Hector Martin wrote: > This is required for DCP to boot successfully; it seems if power gating > is allowed, they do not wake up properly. > > Signed-off-by: Hector Martin Reviewed-by: Sven Peter > --- > arch/arm64/boot/dts/apple/t8103-pmgr.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi > b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi > index 1310be74df1d..fc51bc872468 100644 > --- a/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi > +++ b/arch/arm64/boot/dts/apple/t8103-pmgr.dtsi > @@ -665,6 +665,7 @@ ps_dispext_cpu0: power-controller@378 { > #reset-cells = <0>; > label = "dispext_cpu0"; > power-domains = <&ps_dispext_fe>; > + apple,min-state = <4>; > }; > > ps_jpg: power-controller@3c0 { > @@ -1005,6 +1006,7 @@ ps_disp0_cpu0: power-controller@10018 { > label = "disp0_cpu0"; > power-domains = <&ps_disp0_fe>; > apple,always-on; /* TODO: figure out if we can enable PM here */ > + apple,min-state = <4>; > }; > }; > > -- > 2.33.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel