All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: sven@svenschwermer.de
Cc: John Edward Broadbent <jebr@google.com>,
	Carson Labrado <clabrado@google.com>,
	Richard Purdie <richard.purdie@linuxfoundation.org>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [dunfell] [PATCH] externalsrc: git submodule--helper list unsupported
Date: Thu, 6 Oct 2022 11:30:34 +0200	[thread overview]
Message-ID: <5e4a9745-469e-3adf-3817-5a84620af2a9@bootlin.com> (raw)
In-Reply-To: <20221006092257.67313-1-sven@svenschwermer.de>

Hi Seven,

On 06.10.22 11:22, Sven via lists.openembedded.org wrote:
> From: John Edward Broadbent <jebr@google.com>
>
> Git has removed support for "git submodule--helper list".
> https://github.com/git/git/commit/31955475d1c283120d5d84247eb3fd55d9f5fdd9
>
> This change provides an alternate method for gathering the submodules
> information.
>
> Tested:
> Build recipes with and without submodules
>
> Signed-off-by: Carson Labrado <clabrado@google.com>
> Signed-off-by: John Edward Broadbent <jebr@google.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> (cherry picked from commit 6d9364e5f3535954f65cbbc694ee7933ac1d664f)
> ---
>
> Notes:
>      With git 2.38.0 externalsrc does not work anymore. I hope, we can
>      backport this fix to stable branches as well.
>
>   meta/classes/externalsrc.bbclass | 19 ++++++++++---------
>   1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/meta/classes/externalsrc.bbclass b/meta/classes/externalsrc.bbclass
> index 0e0a3ae89c..291fcf5653 100644
> --- a/meta/classes/externalsrc.bbclass
> +++ b/meta/classes/externalsrc.bbclass


Thanks for the patch, but it doesn't apply.
I guess you should re-apply to the openembedded-core repository first, 
which has different paths.

Thanks again
Michael.

-- 

Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2022-10-06  9:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-06  9:22 [dunfell] [PATCH] externalsrc: git submodule--helper list unsupported Sven Schwermer
2022-10-06  9:30 ` Michael Opdenacker [this message]
     [not found] ` <171B70EA61BB4E6A.13650@lists.openembedded.org>
2022-10-06  9:31   ` [OE-core] " Michael Opdenacker
2022-10-06  9:35   ` Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e4a9745-469e-3adf-3817-5a84620af2a9@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=clabrado@google.com \
    --cc=jebr@google.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=sven@svenschwermer.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.