From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EFF1C43381 for ; Thu, 21 Feb 2019 14:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6037E207E0 for ; Thu, 21 Feb 2019 14:57:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RKfSyvbl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728063AbfBUO5i (ORCPT ); Thu, 21 Feb 2019 09:57:38 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40995 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725832AbfBUO5h (ORCPT ); Thu, 21 Feb 2019 09:57:37 -0500 Received: by mail-pg1-f196.google.com with SMTP id m1so13795607pgq.8 for ; Thu, 21 Feb 2019 06:57:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HWloQsMjvFMuoYj5nuPDvw3PtW2HVil6MntYbs6SimA=; b=RKfSyvblnkFByz47or5RKVo5pjJtHlN5OXpqyc5fw+TrUKiFluCKnOQZByH3xFWm4J PNrJcv47Iz4g6bChXre7GGDp4hxDm5hbBR7lsSRPqPa/xRixy7MUOh/oZeOFSRPacXT6 kvGonZdQl2VHZHKUxLNiyxwyl9BQ/IJV3PCc1XWdG6kJloaWjjydWo2FH+0YW1PoHxan BCEjeH7EH/SQMEFlnVP10usBHTsWYLKiBA1z8TQQjRYHdbrckQgtDGSA2Apxp1lFSBAk /wZcx8tRgGCyUukaizY+bzhmDdyAirbk5Ev1JWmO8U9hwVbkkp+EcgQ8UcsJDMTgUsC2 yobg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HWloQsMjvFMuoYj5nuPDvw3PtW2HVil6MntYbs6SimA=; b=RuIwmcTsrP4G8IYrduFhXsar//BUm7CjYfS+FLAUwSgPRq9uVjyFDHUXQTUnmFEve2 dfZ3GqJnPAw5/4FJ0BgS5NDUiaMFVJ9jkAOleSR7nzHeDZm0D8n4jUZ0nC8/C9ClTDbZ lvxfTA/n6OtIpxxDoaDirQe1ul+WeqnM1rcw1XolY3ayoK7ojkamPKVIoyqNbMbHCfcM ZTmOnwDtoRnxeAQM59olLCIXTh0vbvUW/D0kBnMs8ACigXuIwwyunKxIjWPj/bpcPbd+ 9SijYsFvbpzgRTvDWaVZohYOAe7c6hNIJ6yJeZNYv3aJXnCACOa8ejChoAXeWINx8fIO J4JQ== X-Gm-Message-State: AHQUAuaSzLXiZ6yb4Hy/C+iD0+G9LUsVpVhjVGHxAXtOcvvL6xPZI0Pg HgTFnfIKJ7FVIza3wRjDBmw= X-Google-Smtp-Source: AHgI3IZcBZ7TOSublmvJ6vFOKN22D9N5cOgJjShyyvMAR3YMVsVnooCztF5HskvQDtWCCaQx4VPO2A== X-Received: by 2002:a63:234c:: with SMTP id u12mr30925492pgm.282.1550761057006; Thu, 21 Feb 2019 06:57:37 -0800 (PST) Received: from [172.27.227.247] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id b68sm41857055pfc.128.2019.02.21.06.57.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Feb 2019 06:57:35 -0800 (PST) Subject: Re: [PATCH net v2 2/2] ipv6: route: enforce RCU protection in ip6_route_check_nh_onlink() To: Paolo Abeni , netdev@vger.kernel.org Cc: "David S. Miller" References: <0bf24707358ef15ab42b44037da4dc46e3e63acb.1550684182.git.pabeni@redhat.com> From: David Ahern Message-ID: <5e4b7c58-befe-6a9c-8dc9-e573ce3861f3@gmail.com> Date: Thu, 21 Feb 2019 09:57:34 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <0bf24707358ef15ab42b44037da4dc46e3e63acb.1550684182.git.pabeni@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/21/19 5:19 AM, Paolo Abeni wrote: > We need a RCU critical section around rt6_info->from deference, and > proper annotation. > > Fixes: 4ed591c8ab44 ("net/ipv6: Allow onlink routes to have a device mismatch if it is the default route") > Signed-off-by: Paolo Abeni > --- > net/ipv6/route.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: David Ahern Thanks for the fixing.