From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Jens Axboe <axboe@fb.com>
Cc: Mike Christie <mchristi@redhat.com>, Chris Mason <clm@fb.com>,
Josef Bacik <jbacik@fb.com>, Mike Snitzer <snitzer@redhat.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Damien Le Moal <Damien.LeMoal@hgst.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
device-mapper development <dm-devel@redhat.com>
Subject: [PATCH 1/3] block: Document that bio_op() uses the data type of bio.bi_opf
Date: Wed, 14 Sep 2016 10:44:12 +0200 [thread overview]
Message-ID: <5e51ae40-994c-1f83-0575-6505662fb138@sandisk.com> (raw)
In-Reply-To: <35e3cdd6-8983-6c84-cb4c-9a7be15aea55@sandisk.com>
Make it clear that the sizeof(unsigned int) expression in BIO_OP_SHIFT
refers to the bi_opf member of struct bio.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Mike Christie <mchristi@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Damien Le Moal <damien.lemoal@hgst.com>
---
include/linux/blk_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index 436f43f..1e1ef21 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -89,7 +89,7 @@ struct bio {
struct bio_vec bi_inline_vecs[0];
};
-#define BIO_OP_SHIFT (8 * sizeof(unsigned int) - REQ_OP_BITS)
+#define BIO_OP_SHIFT (8 * FIELD_SIZEOF(struct bio, bi_opf) - REQ_OP_BITS)
#define bio_op(bio) ((bio)->bi_opf >> BIO_OP_SHIFT)
#define bio_set_op_attrs(bio, op, op_flags) do { \
--
2.10.0
next prev parent reply other threads:[~2016-09-14 8:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 8:42 [PATCH 0/3] block: Improve bio_set_op_attrs() robustness Bart Van Assche
2016-09-14 8:42 ` Bart Van Assche
2016-09-14 8:44 ` Bart Van Assche [this message]
2016-09-14 8:52 ` [PATCH 1/3] block: Document that bio_op() uses the data type of bio.bi_opf Johannes Thumshirn
2016-09-14 8:52 ` Johannes Thumshirn
2016-09-14 9:56 ` Christoph Hellwig
2016-09-14 8:45 ` [PATCH 2/3] block, dm-crypt, btrfs: Introduce bio_flags() Bart Van Assche
2016-09-14 8:53 ` Johannes Thumshirn
2016-09-14 8:53 ` Johannes Thumshirn
2016-09-14 9:58 ` Christoph Hellwig
2016-09-14 9:59 ` Christoph Hellwig
2016-09-14 8:46 ` [PATCH 3/3] block: Improve bio_set_op_attrs() robustness Bart Van Assche
2016-09-14 8:55 ` Johannes Thumshirn
2016-09-14 8:55 ` Johannes Thumshirn
2016-09-14 9:59 ` Christoph Hellwig
2016-09-14 14:48 ` [PATCH 0/3] " Jens Axboe
2016-09-14 14:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e51ae40-994c-1f83-0575-6505662fb138@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=Damien.LeMoal@hgst.com \
--cc=axboe@fb.com \
--cc=clm@fb.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.