From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D779C282CE for ; Mon, 3 Jun 2019 14:32:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2180A27A83 for ; Mon, 3 Jun 2019 14:32:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728991AbfFCOcC (ORCPT ); Mon, 3 Jun 2019 10:32:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29891 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728975AbfFCOcB (ORCPT ); Mon, 3 Jun 2019 10:32:01 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6064A369C4 for ; Mon, 3 Jun 2019 14:32:01 +0000 (UTC) Received: from madhat.boston.devel.redhat.com (ovpn-116-46.phx2.redhat.com [10.3.116.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 87FEC60856; Mon, 3 Jun 2019 14:31:57 +0000 (UTC) Subject: Re: [PATCH v2] mountstats: add per-op error counts for mountstats command To: Dave Wysochanski , linux-nfs@vger.kernel.org References: <20190523201351.12232-4-dwysocha@redhat.com> <20190523203344.12487-1-dwysocha@redhat.com> From: Steve Dickson Message-ID: <5e717cc4-f24a-0f83-452f-39167f8e48e3@RedHat.com> Date: Mon, 3 Jun 2019 10:31:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190523203344.12487-1-dwysocha@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 03 Jun 2019 14:32:01 +0000 (UTC) Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 5/23/19 4:33 PM, Dave Wysochanski wrote: > Display the count of ops completing with error status (status < 0) > on kernels that support it. > > Signed-off-by: Dave Wysochanski > --- > tools/mountstats/mountstats.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Committed... steved. > > diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py > index c7fb8bb1..2f525f4b 100755 > --- a/tools/mountstats/mountstats.py > +++ b/tools/mountstats/mountstats.py > @@ -475,7 +475,9 @@ class DeviceData: > retrans = stats[2] - count > if retrans != 0: > print('\t%d retrans (%d%%)' % (retrans, ((retrans * 100) / count)), end=' ') > - print('\t%d major timeouts' % stats[3]) > + print('\t%d major timeouts' % stats[3], end='') > + if len(stats) >= 10 and stats[9] != 0: > + print('\t%d errors (%d%%)' % (stats[9], ((stats[9] * 100) / count))) > else: > print('') > print('\tavg bytes sent per op: %d\tavg bytes received per op: %d' % \ >