All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: Meelis Roos <mroos@linux.ee>,
	Thomas Gleixner <tglx@linutronix.de>,
	David Woodhouse <dwmw@amazon.co.uk>
Cc: LKML <linux-kernel@vger.kernel.org>, yamada.masahiro@socionext.com
Subject: Re: Compiling with old gcc breaks when CONFIG_RETPOLINE is off
Date: Tue, 4 Dec 2018 21:57:22 +0800	[thread overview]
Message-ID: <5e7dfdc9-8680-91f6-4d7e-aa14fbb6def8@oracle.com> (raw)
In-Reply-To: <6eeee8da-82ac-f527-9278-7ebcc8756ea1@linux.ee>

Since commit '315bab4e972d kbuild: fix endless syncconfig in case arch 
Makefile sets CROSS_COMPILE',

arch/$(SRCARCH)/Makefile is moved ahead of include/config/%.conf 
synchonization in root Makefile.

So all the CONFIG_* option used in arch/$(SRCARCH)/Makefile may have 
stale value if they were just updated in .config.

This looks like an issue. I'm not familiar with kbuild. Ccing Yamada for 
help.


Thanks

Zhenzhong

On 2018/12/4 17:58, Meelis Roos wrote:
> Just tried 4.20-rc5 on an old K6-2 PC with gcc 5.3.1, got an error 
> about non-retpoline compiler,
> turned CONFIG_RETPOLINE off and retried.
>
> To my surprise, compilation still breaks with
> arch/x86/Makefile:224: *** You are building kernel with non-retpoline 
> compiler, please update your compiler..  Stop.
>
> As I read the Makefile, it should error only when CONFIG_RETPOLINE is 
> enabled, but it still breaks.
>
> $ grep -r CONFIG_RETPOLINE .config
> # CONFIG_RETPOLINE is not set
>
> $ grep -r CONFIG_RETPOLINE include/
> include/generated/autoconf.h:#define CONFIG_RETPOLINE 1
> include/config/auto.conf:CONFIG_RETPOLINE=y
>
> So the headers have not been updated yet, maybe?
>

  reply	other threads:[~2018-12-04 14:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04  9:58 Compiling with old gcc breaks when CONFIG_RETPOLINE is off Meelis Roos
2018-12-04 13:57 ` Zhenzhong Duan [this message]
2018-12-05  1:30 ` Zhenzhong Duan
2018-12-05  3:00   ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e7dfdc9-8680-91f6-4d7e-aa14fbb6def8@oracle.com \
    --to=zhenzhong.duan@oracle.com \
    --cc=dwmw@amazon.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=tglx@linutronix.de \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.