From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yaodong Li Subject: Re: [PATCH v9 6/7] drm/i915/guc: Check the locking status of GuC WOPCM registers Date: Sat, 10 Feb 2018 16:36:23 -0800 Message-ID: <5e7e708e-3a64-2779-6c59-7ec3d24ff86b@intel.com> References: <1518131035-24108-1-git-send-email-yaodong.li@intel.com> <1518131035-24108-6-git-send-email-yaodong.li@intel.com> <151817323518.4964.3002962792973105876@jlahtine-desk.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4539D89ABA for ; Sun, 11 Feb 2018 00:37:57 +0000 (UTC) In-Reply-To: <151817323518.4964.3002962792973105876@jlahtine-desk.ger.corp.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwMi8wOS8yMDE4IDAyOjQ3IEFNLCBKb29uYXMgTGFodGluZW4gd3JvdGU6Cj4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y193b3BjbS5jCj4+ICtzdGF0aWMgaW5saW5l IGJvb2wgZ3VjX3dvcGNtX2xvY2tlZChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4+ICt7Cj4+ICsg ICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSBndWNfdG9faTkxNShndWMpOwo+ PiArICAgICAgIGJvb2wgc2l6ZV9yZWdfbG9ja2VkID0gX19yZWdfbG9ja2VkKGk5MTUsIEdVQ19X T1BDTV9TSVpFKTsKPj4gKyAgICAgICBib29sIG9mZnNldF9yZWdfbG9ja2VkID0gX19yZWdfbG9j a2VkKGk5MTUsIERNQV9HVUNfV09QQ01fT0ZGU0VUKTsKPj4gKwo+PiArICAgICAgIHJldHVybiBz aXplX3JlZ19sb2NrZWQgJiYgb2Zmc2V0X3JlZ19sb2NrZWQ7Cj4gSG1tLCBpc24ndCB0aGlzIHN1 cHBvc2VkIHRvIGJlIHx8IGluc3RlYWQsIGlmIGVpdGhlciBvZiB0aGUgcmVnaXN0ZXJzIGlzCj4g bG9ja2VkLCB3ZSBjYW4ndCByZWFsbHkgZG8gbXVjaD8KSXQgaXMgYW4gaXNzdWUhCgpUaGUgaW50 ZW50aW9uIHdhcyBsZXR0aW5nIGZvbGxvd2luZyBHRU1fQlVHX09OIHRvIGZhaWwgdGhlCiJvbmx5 IG9uZSByZWciIGxvY2tlZCBjYXNlLiBIb3dldmVyLCBhZnRlciBhZGRpbmcgdGhlIHZhbGlkYXRp b24Kb2YgdGhlIGFscmVhZHkgbG9ja2VkIHJlZyB2YWx1ZXMsIEkgdGhpbmsgd2UgbmVlZCB1cGRh dGUgdGhlIGxvZ2ljCmNvZGUgYSBsaXR0bGUgYml0ICh0byB1c2UgdGhlIGxvY2tlZCByZWcgaWYg aXQgY29udGFpbmVkIHRoZSB2YWxpZCB2YWx1ZSkuCgpBbHNvLCBJIHRoaW5rIGl0IG1ha2VzIHNl bnNlIHRvIGludHJvZHVjZSBzb21lIGhlbHBlcgpmdW5jdGlvbnMgYXMgeW91IG1lbnRpb25lZCBi ZWxvdyB0byBtYWtlIHRoaW5ncyBjbGVhcmVyLgpzbyBJIHdpbGwgcmV3b3JrIHRoaXMgcGFydCBv ZiBjb2RlIHRvIG1ha2UgaXQgY2xlYXJlciBhbmQgYWRkcmVzcwp0aGlzIGlzc3VlIGF0IHRoZSBz YW1lIHRpbWUuCgpUaGFua3MgJiBSZWdhcmRzLAotSmFja2llCj4+ICtzdGF0aWMgaW5saW5lIHZv aWQgZ3VjX3dvcGNtX2h3X3VwZGF0ZShzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4+ICt7Cj4+ICsg ICAgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUoZ3Vj KTsKPj4gKyAgICAgICB1MzIgb2Zmc2V0X3JlZ192YWw7Cj4+ICsKPj4gKyAgICAgICAvKiBHdUMg V09QQ00gcmVnaXN0ZXJzIHNob3VsZCBiZSB1bmxvY2tlZCBhdCB0aGlzIHBvaW50LiAqLwo+PiAr ICAgICAgIEdFTV9CVUdfT04oX19yZWdfbG9ja2VkKGRldl9wcml2LCBHVUNfV09QQ01fU0laRSkp Owo+PiArICAgICAgIEdFTV9CVUdfT04oX19yZWdfbG9ja2VkKGRldl9wcml2LCBETUFfR1VDX1dP UENNX09GRlNFVCkpOwo+PiArCj4+ICsgICAgICAgb2Zmc2V0X3JlZ192YWwgPSBndWMtPndvcGNt Lm9mZnNldDsKPj4gKyAgICAgICBpZiAoZ3VjLT53b3BjbS5uZWVkX2xvYWRfaHVjX2Z3KQo+ICJs b2FkX2h1Y19mdyIgd291bGQgcmVhZCBiZXR0ZXIgaGVyZS4KPgo+PiArICAgICAgICAgICAgICAg b2Zmc2V0X3JlZ192YWwgfD0gSFVDX0xPQURJTkdfQUdFTlRfR1VDOwo+PiArCj4+ICsgICAgICAg STkxNV9XUklURShHVUNfV09QQ01fU0laRSwgZ3VjLT53b3BjbS5zaXplKTsKPj4gKyAgICAgICBJ OTE1X1dSSVRFKERNQV9HVUNfV09QQ01fT0ZGU0VULCBvZmZzZXRfcmVnX3ZhbCk7Cj4+ICsKPj4g KyAgICAgICBHRU1fQlVHX09OKCFfX3JlZ19sb2NrZWQoZGV2X3ByaXYsIEdVQ19XT1BDTV9TSVpF KSk7Cj4+ICsgICAgICAgR0VNX0JVR19PTighX19yZWdfbG9ja2VkKGRldl9wcml2LCBETUFfR1VD X1dPUENNX09GRlNFVCkpOwo+IFRoaXMgY291bGQgdXNlIHN0YXRpYyBpbmxpbmUgd3JpdGVfbG9j a2FibGVfcmVnKCkgaGVscGVyIHdpdGggYSByZXR1cm4gdmFsdWUuCj4gSSB0aGluayB3ZSBuZWVk IHRvIHByb3BhZ2F0ZSB0aGUgZXJyb3IgYWxsIHRoZSB3YXkgdXAgdGhlIGNoYWluLCBhcyBpdCdz Cj4gbm90IGEgZHJpdmVyIHByb2dyYW1tZXIgZXJyb3IgaWYgdGhlc2UgcmVnaXN0ZXJzIGFyZSBs b2NrZWQsIGluc3RlYWQgaXQgaXMKPiBsaWtlbHkgdG8gYmUgYSBCSU9TIHByb2JsZW0uCj4KPiBJ biB0aGUgaGVscGVyIHdlIGNvdWxkIGFsc28gdGVzdCBpZiB0aGUgdmFsdWUgaXMgbG9ja2VkIGJ1 dCBoYXBwZW5zIHRvCj4gbWF0Y2ggd2hhdCB3ZSB3ZXJlIGludGVuZGluZyB0byB3cml0ZSwgdGhl biB3ZSBjb3VsZCBjYWxsIGl0IHN1Y2Nlc3MgYW5kCj4gbWF5YmUgZW1pdCBhbiBJTkZPIG1lc3Nh Z2UuCj4KPj4gK30KPj4gKwo+PiArc3RhdGljIGlubGluZSBib29sIGd1Y193b3BjbV9yZWdzX3Zh bGlkKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPj4gK3sKPj4gKyAgICAgICBzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBndWNfdG9faTkxNShndWMpOwo+PiArICAgICAgIHUzMiBz aXplLCBvZmZzZXQ7Cj4+ICsgICAgICAgYm9vbCBndWNfbG9hZHNfaHVjOwo+PiArICAgICAgIHUz MiByZWdfdmFsOwo+PiArCj4+ICsgICAgICAgcmVnX3ZhbCA9IEk5MTVfUkVBRChHVUNfV09QQ01f U0laRSk7Cj4+ICsgICAgICAgLyogR3VDIFdPUENNIHNpemUgc2hvdWxkIGJlIGFsd2F5cyBtdWx0 aXBsZSBvZiA0SyBwYWdlcy4gKi8KPj4gKyAgICAgICBzaXplID0gcmVnX3ZhbCAmIFBBR0VfTUFT SzsKPj4gKwo+PiArICAgICAgIHJlZ192YWwgPSBJOTE1X1JFQUQoRE1BX0dVQ19XT1BDTV9PRkZT RVQpOwo+PiArICAgICAgIGd1Y19sb2Fkc19odWMgPSByZWdfdmFsICYgSFVDX0xPQURJTkdfQUdF TlRfR1VDOwo+PiArICAgICAgIG9mZnNldCA9IHJlZ192YWwgJiBHVUNfV09QQ01fT0ZGU0VUX01B U0s7Cj4+ICsKPj4gKyAgICAgICBpZiAoZ3VjLT53b3BjbS5uZWVkX2xvYWRfaHVjX2Z3ICYmICFn dWNfbG9hZHNfaHVjKQo+PiArICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+PiArCj4+ICsg ICAgICAgcmV0dXJuIChzaXplID09IGd1Yy0+d29wY20uc2l6ZSkgJiYgKG9mZnNldCA9PSBndWMt PndvcGNtLm9mZnNldCk7Cj4+ICt9Cj4gVGhpcyBzZWVtcyB0byBoYXZlIG11Y2ggb2Ygd2hhdCBJ IHdyb3RlIGFib3ZlIGFscmVhZHkuIEknZCBzdGlsbCBzcGxpdAo+IHRoZSBhY3R1YWwgd3JpdGVz IGluIGEgaGVscGVyIHRoYXQgd2lsbCByZXBvcnQgdGhlIHBlci1yZWdpc3RlciBhCj4gV0FSTiBh Ym91dCAibWlzbWF0Y2ggYmV0d2VlbiBsb2NrZWQgcmVnaXN0ZXIgdmFsdWUgYW5kIGNvbXB1dGVk IHZhbHVlIgo+IG9yIHNvLiBEdW1waW5nIGJvdGggdGhlIGNvbXB1dGVkIGFuIGFjdHVhbCByZWdp c3RlciB2YWx1ZS4KPgo+PiBAQCAtMTQ3LDYgKzIxMSw4IEBAIGludCBpbnRlbF9ndWNfd29wY21f aW5pdChzdHJ1Y3QgaW50ZWxfZ3VjX3dvcGNtICpndWNfd29wY20sIHUzMiBndWNfZndfc2l6ZSwK Pj4gICAgICAgICAgZ3VjLT53b3BjbS5vZmZzZXQgPSBvZmZzZXQ7Cj4+ICAgICAgICAgIGd1Yy0+ d29wY20uc2l6ZSA9IHNpemU7Cj4+ICAgICAgICAgIGd1Yy0+d29wY20udG9wID0gdG9wOwo+PiAr ICAgICAgIC8qIFVzZSBHdUMgdG8gbG9hZCBIdUMgZmlybXdhcmUgaWYgSHVDIGZpcm13YXJlIGlz IHByZXNlbnQuICovCj4gQ29tbWVudCBpcyBhZ2FpbiBtb3JlIG9uIHRoZSAid2hhdCIgc2lkZSwg c28gY2FuIGJlIGRyb3BwZWQuCj4KPj4gKyAgICAgICBndWMtPndvcGNtLm5lZWRfbG9hZF9odWNf ZncgPSBodWNfZndfc2l6ZSA/IDEgOiAwOwo+IAkuLi4gPSBodWNfZndfc2l6ZSA+IDA7Cj4KPiBX aWxsIGxpdGVyYWxseSByZWFkIGFzICJzZXQgZ3VjIGxvYWRfaHVjX2Z3IGlmIGh1Y19md19zaXpl IGlzCj4gZ3JlYXRlciB0aGFuIHplcm8uIgo+Cj4+ICtpbnQgaW50ZWxfZ3VjX3dvcGNtX2luaXRf aHcoc3RydWN0IGludGVsX2d1Y193b3BjbSAqZ3VjX3dvcGNtKQo+PiArewo+PiArICAgICAgIHN0 cnVjdCBpbnRlbF9ndWMgKmd1YyA9IGd1Y193b3BjbV90b19ndWMoZ3VjX3dvcGNtKTsKPj4gKyAg ICAgICBib29sIGxvY2tlZCA9IGd1Y193b3BjbV9sb2NrZWQoZ3VjKTsKPj4gKwo+PiArICAgICAg IEdFTV9CVUdfT04oIWd1Yy0+d29wY20udmFsaWQpOwo+PiArCj4+ICsgICAgICAgLyoKPj4gKyAg ICAgICAgKiBCdWcgaWYgZHJpdmVyIGhhc24ndCB1cGRhdGVkIHRoZSBIVyBSZWdpc3RlcnMgYW5k IEd1QyBXT1BDTSBoYXMgYmVlbgo+PiArICAgICAgICAqIGxvY2tlZC4gUmV0dXJuIGRpcmVjdGx5 IGlmIFdPUENNIHdhcyBsb2NrZWQgYW5kIHdlIGhhdmUgdXBkYXRlZAo+PiArICAgICAgICAqIHRo ZSByZWdpc3RlcnMuCj4+ICsgICAgICAgICovCj4+ICsgICAgICAgaWYgKGxvY2tlZCkgewo+PiAr ICAgICAgICAgICAgICAgaWYgKGd1Yy0+d29wY20uaHdfdXBkYXRlZCkKPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIDA7Cj4+ICsKPj4gKyAgICAgICAgICAgICAgIC8qCj4+ICsgICAg ICAgICAgICAgICAgKiBNYXJrIGFzIHVwZGF0ZWQgaWYgcmVnaXN0ZXJzIGNvbnRhaW5lZCBjb3Jy ZWN0IHZhbHVlcy4KPj4gKyAgICAgICAgICAgICAgICAqIFRoaXMgd2lsbCBoYXBwZW4gd2hpbGUg cmVsb2FkaW5nIHRoZSBkcml2ZXIgbW9kdWxlIHdpdGhvdXQKPj4gKyAgICAgICAgICAgICAgICAq IHJlYm9vdGluZyB0aGUgc3lzdGVtLgo+PiArICAgICAgICAgICAgICAgICovCj4+ICsgICAgICAg ICAgICAgICBpZiAoZ3VjX3dvcGNtX3JlZ3NfdmFsaWQoZ3VjKSkKPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgZ290byBvdXQ7Cj4+ICsKPj4gKyAgICAgICAgICAgICAgIC8qIFJlZ2lzdGVyIGxv Y2tlZCB3aXRob3V0IHZhbGlkIHZhbHVlcy4gQWJvcnQgSFcgaW5pdC4gKi8KPj4gKyAgICAgICAg ICAgICAgIHJldHVybiAtRUlOVkFMOwo+PiArICAgICAgIH0KPj4gKwo+PiArICAgICAgIC8qIEFs d2F5cyB1cGRhdGUgcmVnaXN0ZXJzIHdoZW4gR3VDIFdPUENNIGlzIG5vdCBsb2NrZWQuICovCj4+ ICsgICAgICAgZ3VjX3dvcGNtX2h3X3VwZGF0ZShndWMpOwo+IFRoaXMgZmxvdyB3aWxsIGJlY29t ZSBtb3JlIGNsZWFyIHdpdGggdGhlIGhlbHBlcnMsIGFuZCB3ZSB3aWxsIGdldCBhCj4gc3BsYXQg aW4gdGhlIGtlcm5lbCBtZXNzYWdlIHdpdGggbGVzcyBjb2RlIGFib3V0IHdoaWNoIHJlZ2lzdGVy IGFjdHVhbGx5Cj4gd2FzIGxvY2tlZCBhbmQgaG93IHRoZSB2YWx1ZSBtaXNtYXRjaGVkLgo+Cj4g SSdtIHVwIGZvciBkaXNjdXNzaW9uLCBidXQgdG8gbXkgZXllcyB0aGUgY29kZSBmbG93IHdvdWxk IGJlY29tZSBtb3JlIGNsZWFyIGlmCj4gd2Ugc3RhcnQgd2l0aCB0aGUgYXNzdW1wdGlvbiAid2Ug Y2FuIHdyaXRlIHRoZSByZWdpc3RlciB2YWx1ZXMgdG8gd2hhdCB3ZSBoYXZlCj4gY2FsY3VsYXRl ZCIsIGFuZCB0aGVuIG1ha2UgaXQgYW4gZXJyb3IgdGhhdCBpcyBwcm9wYWdhdGVkIGJhY2sgdXAg aWYgd2UgY2FuJ3QuCj4KPiBSZWdhcmRzLCBKb29uYXMKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=