All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
To: Jes Sorensen <jes.sorensen@gmail.com>, linux-raid@vger.kernel.org
Cc: Maksymilian Kunt <maksymilian.kunt@intel.com>
Subject: Re: [PATCH] IMSM: Correct --examine output for 4k disks
Date: Wed, 10 May 2017 10:43:14 +0200	[thread overview]
Message-ID: <5e8e5353-e42d-0ea0-1928-7d4608a884b8@intel.com> (raw)
In-Reply-To: <1aca3793-3786-00dc-910e-920a21a1108b@gmail.com>

On 05/09/2017 06:04 PM, Jes Sorensen wrote:
 > On 05/09/2017 08:03 AM, Mariusz Dabrowski wrote:
 >> From: Maksymilian Kunt <maksymilian.kunt@intel.com>
 >>
 >> "Array Size" and "Per Dev Size" are incorrect for disks with sector size
 >> different than 512B.
 >>
 >> Calculate "Array Size" and "Per Dev Size" based on sector size. Additionally
 >> print "Sector Size".
 >>
 >> Signed-off-by: Maksymilian Kunt <maksymilian.kunt@intel.com>
 >> Signed-off-by: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
 >> ---
 >>   super-intel.c | 7 +++++--
 >>   1 file changed, 5 insertions(+), 2 deletions(-)
 >
 > I am a little wary of this change as it changes the order of the output. Does
 > anyone have tools parsing this information which could break from this?
 >
 > Jes
 >

Hi Jes,

some time ago we have added "RWH Policy" field to --examine output and we 
haven't heard any complaints about that change.
Also it is better to parse output from --export option which is unchanged in 
this patch.

Thanks,
Mariusz




  reply	other threads:[~2017-05-10  8:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09 12:03 [PATCH] IMSM: Correct --examine output for 4k disks Mariusz Dabrowski
2017-05-09 16:04 ` Jes Sorensen
2017-05-10  8:43   ` Mariusz Dabrowski [this message]
2017-05-10 15:18     ` Jes Sorensen
2017-05-11 11:49       ` Mariusz Dabrowski
2017-05-11 15:44         ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e8e5353-e42d-0ea0-1928-7d4608a884b8@intel.com \
    --to=mariusz.dabrowski@intel.com \
    --cc=jes.sorensen@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=maksymilian.kunt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.