From mboxrd@z Thu Jan 1 00:00:00 1970 From: LinoSanfilippo@gmx.de (Lino Sanfilippo) Date: Wed, 19 Apr 2017 22:48:11 +0200 Subject: Patch Question In-Reply-To: References: <20170417235844.GA745@eros> <20170419001132.GA15282@eros> <20170419161334.GA32742@kroah.com> Message-ID: <5e8fa8f8-beb5-f7c6-d0ec-2eaafddf7a12@gmx.de> To: kernelnewbies@lists.kernelnewbies.org List-Id: kernelnewbies.lists.kernelnewbies.org On 19.04.2017 18:46, Perry Hooker wrote: > > Understood. I'm still open to the possibility that I've made a mistake > - I don't want to re-submit the patch if my analysis is incorrect. > > Maybe I didn't make it clear (my apologies if so) - what I'm really > looking for here is help confirming or refuting my work. If > re-submitting the patch is the best way to do this, then I can > certainly go that route. > Before you do this you should double check that the raised objections are indeed not justified. I have not looked too deep into the code but in function WILC_WFI_p2p_rx() the buffer is conditionally passed to cfg80211_rx_mgmt() which handles the passed data as being little endian. To me this is a strong indication that the data in the buffer is also little endian (which is what Dan pointed out and why the change you propose is not correct). Regards, Lino