All of lore.kernel.org
 help / color / mirror / Atom feed
From: <Justin.Lee1@Dell.com>
To: <amithash@fb.com>, <vijaykhemka@fb.com>, <sam@mendozajonas.com>,
	<joel@jms.id.au>
Cc: <linux-aspeed@lists.ozlabs.org>, <openbmc@lists.ozlabs.org>,
	<sdasari@fb.com>, <netdev@vger.kernel.org>
Subject: RE: [PATCH] net/ncsi: Add NCSI OEM command for FB Tiogapass
Date: Wed, 26 Sep 2018 20:39:38 +0000	[thread overview]
Message-ID: <5e9c8e3f8fd54845b15cd460efe9090d@AUSX13MPS306.AMER.DELL.COM> (raw)
In-Reply-To: <MWHPR15MB14861AED8F8AF652CE5E62B3B2150@MWHPR15MB1486.namprd15.prod.outlook.com>

> >  As I understand Justin's version adds a generic handler, using the NCSI
> >  Netlink interface to pass OEM commands and responses to and from
> >  userspace, which does the actual packet handling.
> Thanks for the direction Sam! Justin, if you don't mind, can you share the patches you have to add the support? This actually would solve a few other things we are trying to accomplish.


Basically, I add a new flag to indicate the request is coming from the Netlink interface to allow the command handler and response handler to react.
#define NCSI_REQ_FLAG_NETLINK_DRIVEN	2

The work flow is as below. 

Request:
User space application -> Netlink interface (msg) -> new Netlink handler - ncsi_send_cmd_nl() - ncsi_xmit_cmd()

Response:
Response received - ncsi_rcv_rsp() -> internal response handler - ncsi_rsp_handler_xxx() -> ncsi_send_netlink_rsp () -> Netlink interface (msg) -> user space application
Command timeout - ncsi_request_timeout() -> ncsi_send_netlink_timeout () -> Netlink interface (msg with zero data length) -> user space application

Error:
Detected error -> ncsi_send_netlink_err () -> Netlink interface (err msg) -> user space application

I will clean up some code and send out the patch. 

Thanks,
Justin

  reply	other threads:[~2018-09-27  2:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25  0:08 [PATCH] net/ncsi: Add NCSI OEM command for FB Tiogapass Vijay Khemka
2018-09-25  0:15 ` Vijay Khemka
2018-09-25  0:30 ` Joel Stanley
2018-09-25 18:16   ` Vijay Khemka
2018-09-26  4:33     ` Samuel Mendoza-Jonas
2018-09-26  4:33       ` Samuel Mendoza-Jonas
2018-09-26 17:07       ` Vijay Khemka
2018-09-26 18:07         ` Amithash Prasad
2018-09-26 20:39           ` Justin.Lee1 [this message]
2018-09-27  3:20             ` Joel Stanley
2018-09-27  3:20               ` Joel Stanley
2018-09-27 17:46               ` Justin.Lee1
2018-09-27  3:43 ` Samuel Mendoza-Jonas
2018-09-27  3:54   ` Samuel Mendoza-Jonas
2018-09-28 22:26   ` Vijay Khemka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e9c8e3f8fd54845b15cd460efe9090d@AUSX13MPS306.AMER.DELL.COM \
    --to=justin.lee1@dell.com \
    --cc=amithash@fb.com \
    --cc=joel@jms.id.au \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=sam@mendozajonas.com \
    --cc=sdasari@fb.com \
    --cc=vijaykhemka@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.