From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: netdev@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] nfc: st95hf: Make spi remove() callback return zero
Date: Wed, 20 Oct 2021 09:09:04 +0200 [thread overview]
Message-ID: <5eaa4875-3d7a-f1cd-578b-c1ea8db2bf19@canonical.com> (raw)
In-Reply-To: <20211020070526.4xsjqdi54iayen3l@pengutronix.de>
On 20/10/2021 09:05, Uwe Kleine-König wrote:
> Hello Krzysztof,
>
> On Wed, Oct 20, 2021 at 08:55:51AM +0200, Krzysztof Kozlowski wrote:
>> On 19/10/2021 22:49, Uwe Kleine-König wrote:
>>> If something goes wrong in the remove callback, returning an error code
>>> just results in an error message. The device still disappears.
>>>
>>> So don't skip disabling the regulator in st95hf_remove() if resetting
>>> the controller via spi fails. Also don't return an error code which just
>>> results in two error messages.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>> ---
>>> drivers/nfc/st95hf/core.c | 6 ++----
>>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>
> Given you're the listed maintainer for NFC, I wonder who will take this
> patch? I expected you to take this patch and not "only" give your
> Reviewed-by tag.
>
Yeah, it's not that obvious. Maybe I should write subsystem/maintainer
guide for NFC...
All NFC patches are taken by netdev folks (David and Jakub) via
patchwork. You did not CC them here, but you CC-ed the netdev, so let's
hope it is enough. You also skipped linux-nfc, so you might need a file:
$ cat .get_maintainer.conf
--s
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-10-20 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 20:49 [PATCH] nfc: st95hf: Make spi remove() callback return zero Uwe Kleine-König
2021-10-20 6:55 ` Krzysztof Kozlowski
2021-10-20 7:05 ` Uwe Kleine-König
2021-10-20 7:09 ` Krzysztof Kozlowski [this message]
2021-10-20 9:29 ` Uwe Kleine-König
2021-10-20 13:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eaa4875-3d7a-f1cd-578b-c1ea8db2bf19@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=kernel@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.