From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D49B2C433E0
	for <linux-devicetree@archiver.kernel.org>; Wed, 27 Jan 2021 10:24:58 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 8E6E92072C
	for <linux-devicetree@archiver.kernel.org>; Wed, 27 Jan 2021 10:24:58 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S313588AbhAZXBN (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Tue, 26 Jan 2021 18:01:13 -0500
Received: from gate2.alliedtelesis.co.nz ([202.36.163.20]:50072 "EHLO
        gate2.alliedtelesis.co.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729356AbhAZU05 (ORCPT
        <rfc822;devicetree@vger.kernel.org>); Tue, 26 Jan 2021 15:26:57 -0500
X-Greylist: delayed 64297 seconds by postgrey-1.27 at vger.kernel.org; Tue, 26 Jan 2021 15:26:56 EST
Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (Client did not present a certificate)
        by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 97068891AE;
        Wed, 27 Jan 2021 09:26:01 +1300 (NZDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz;
        s=mail181024; t=1611692761;
        bh=Uc+sbTNx0GLcEiykqP/dbDEH+LGhadiKUZ0d1aPtToM=;
        h=From:To:CC:Subject:Date:References:In-Reply-To;
        b=jCy0bxl5orihLgQ6KSyNpCosLXVQOSVSCq2OO85oxezDmLb8Uo9o05giTJ4TABR6T
         vk3WsCPrOwiLHqC51W8QrqQDbsQBBzKYOVYx1/QNFGFWGgZDNXxH496G0A6S751KQV
         Dcs22OgU8JshJOrdDf8LHIhS2+WjXq9sw/1vR+EOu1IHqg2EdmN/2cYP7qkdKHPjro
         sszkGn16jjB26XS0Aqxlmkx6awf0TqXJ/EbTtbBrOkiufc/lckILEx/TGAdi8y4oW0
         HZiYGqbmZH9KFwF87rVCR4/+KnLGI59TTrq9owBjkJ+PmGdgTE9rOfbsLd7hSYxIxn
         GLY6ycWI7XG2g==
Received: from svr-chch-ex1.atlnz.lc (Not Verified[10.32.16.77]) by mmarshal3.atlnz.lc with Trustwave SEG (v7,5,8,10121)
        id <B60107ada0001>; Wed, 27 Jan 2021 09:26:02 +1300
Received: from svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8::77) by
 svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8::77) with Microsoft SMTP Server
 (TLS) id 15.0.1497.2; Wed, 27 Jan 2021 09:26:01 +1300
Received: from svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8]) by
 svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8%12]) with mapi id
 15.00.1497.010; Wed, 27 Jan 2021 09:26:01 +1300
From:   Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To:     Rob Herring <robh@kernel.org>
CC:     Russell King <linux@armlinux.org.uk>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Qi Zheng <arch0.zheng@gmail.com>
Subject: Re: [PATCH] ARM: zImage: atags_to_fdt: Fix node names on added root
 nodes
Thread-Topic: [PATCH] ARM: zImage: atags_to_fdt: Fix node names on added root
 nodes
Thread-Index: AQHW84xwlZl6qBJpAEuzuF8M0I/jXKo4WucAgADCIACAAGJDgIAAApoA
Date:   Tue, 26 Jan 2021 20:26:00 +0000
Message-ID: <5eb47de6-16b0-7ee2-1c3f-4de73570e575@alliedtelesis.co.nz>
References: <20210126023905.1631161-1-robh@kernel.org>
 <329a3043-a85f-8177-c3ad-a9c07604a266@alliedtelesis.co.nz>
 <CAL_JsqLHrd40WqqMEZU0NqgVNLS2rw1u_SgR26dt3nw3mCsr3w@mail.gmail.com>
 <9ae5d166-1183-f1fc-b255-f4497d321d29@alliedtelesis.co.nz>
In-Reply-To: <9ae5d166-1183-f1fc-b255-f4497d321d29@alliedtelesis.co.nz>
Accept-Language: en-NZ, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.32.1.11]
Content-Type: text/plain; charset="utf-8"
Content-ID: <7E225722E51E1842A7E166AFEE665D68@atlnz.lc>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

DQpPbiAyNy8wMS8yMSA5OjE2IGFtLCBDaHJpcyBQYWNraGFtIHdyb3RlOg0KPiBIaSBSb2INCj4N
Cj4gT24gMjcvMDEvMjEgMzoyNSBhbSwgUm9iIEhlcnJpbmcgd3JvdGU6DQo+PiBPbiBNb24sIEph
biAyNSwgMjAyMSBhdCA4OjUwIFBNIENocmlzIFBhY2toYW0NCj4+IDxDaHJpcy5QYWNraGFtQGFs
bGllZHRlbGVzaXMuY28ubno+IHdyb3RlOg0KPj4+IEhpIFJvYiwNCj4+Pg0KPj4+IE9uIDI2LzAx
LzIxIDM6MzkgcG0sIFJvYiBIZXJyaW5nIHdyb3RlOg0KPj4+PiBDb21taXQgNzUzNmM3ZTAzZTc0
ICgib2YvZmR0OiBSZW1vdmUgcmVkdW5kYW50IGtiYXNlbmFtZSBmdW5jdGlvbg0KPj4+PiBjYWxs
IikgZXhwb3NlZCBhIGJ1ZyBjcmVhdGluZyBEVCBub2RlcyBpbiB0aGUgQVRBR1MgdG8gRFQgZml4
dXAgY29kZS4NCj4+Pj4gTm9uLWV4aXN0ZW50IG5vZGVzIHdvdWxkIG1pc3Rha2VuIGdldCBjcmVh
dGVkIHdpdGggYSBsZWFkaW5nICcvJy4gVGhlDQo+Pj4+IHByb2JsZW0gd2FzIGZkdF9wYXRoX29m
ZnNldCgpIHRha2VzIGEgZnVsbCBwYXRoIHdoaWxlIGNyZWF0aW5nIGEgbm9kZQ0KPj4+PiB3aXRo
IGZkdF9hZGRfc3Vibm9kZSgpIHRha2VzIGp1c3QgdGhlIGJhc2VuYW1lLg0KPj4+Pg0KPj4+PiBT
aW5jZSB0aGlzIHdlIG9ubHkgYWRkIHJvb3QgY2hpbGQgbm9kZXMsIHdlIGNhbiBqdXN0IHNraXAg
b3ZlciB0aGUgDQo+Pj4+ICcvJy4NCj4+Pj4NCj4+Pj4gRml4ZXM6IDc1MzZjN2UwM2U3NCAoIm9m
L2ZkdDogUmVtb3ZlIHJlZHVuZGFudCBrYmFzZW5hbWUgZnVuY3Rpb24gDQo+Pj4+IGNhbGwiKQ0K
Pj4+PiBSZXBvcnRlZC1ieTogQ2hyaXMgUGFja2hhbSA8Y2hyaXMucGFja2hhbUBhbGxpZWR0ZWxl
c2lzLmNvLm56Pg0KPj4+PiBDYzogUWkgWmhlbmcgPGFyY2gwLnpoZW5nQGdtYWlsLmNvbT4NCj4+
Pj4gQ2M6IFJ1c3NlbGwgS2luZyA8bGludXhAYXJtbGludXgub3JnLnVrPg0KPj4+PiBTaWduZWQt
b2ZmLWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPg0KPj4+IFRoYW5rcyBmb3IgdGhl
IHF1aWNrIHBhdGNoLiBJdCBkb2Vzbid0IHF1aXRlIHNlZW0gdG8gd29yayBhcyBteSBzeXN0ZW0N
Cj4+PiBjYW4ndCBmaW5kIGl0J3MgaW5pdHJkIChpdCBjYW4gd2l0aCBteSBvdGhlciBoYWNreSBw
YXRjaCkuIEl0IGRvZXMgc2VlbQ0KPj4+IHRvIGdldCB0aGUgY29tbWFuZCBsaW5lIGluZm8gYXMg
SSdtIGdldHRpbmcgcHJpbnRrIG91dHB1dC4NCj4+IFRoYXQgZG9lc24ndCBtYWtlIHNlbnNlLiBD
YW4geW91IGVuYWJsZSBkZWJ1ZyBpbiBkcml2ZXJzL29mL2ZkdC5jLg0KPiBJJ3ZlIGF0dGFjaGVk
IHR3byBjYXB0dXJlcyB3aXRoIERFQlVHIGVuYWJsZWQgaW4gZHJpdmVycy9vZi9mZHQuYy4gT25l
IA0KPiB3aXRoIHlvdXIgcGF0Y2ggYW5kIG9uZSB3aXRoIG1pbmUuIEkgbm90ZSB0aGF0IGluIHlv
dXIgb25lIHdlIGRvIA0KPiBhY3R1YWxseSBwaWNrIHVwIGluaXRyZF9zdGFydC9pbml0cmRfZW5k
IGJ1dCB0aGVuIGl0IGdldHMgZGlzYWJsZWQgZm9yIA0KPiBzb21lIHJlYXNvbiAocG9zc2libHkg
b3RoZXIgY2hhbmdlcyB3ZSBoYXZlIGluIG91ciBrZXJuZWwpLg0KDQpTdXJlIGVub3VnaCBJIHR1
cm5lZCBvZmYgb3VyICJzcGVjaWFsIiBjb2RlIGFuZCBpdCBhbGwgd29ya3MgYXMgDQpleHBlY3Rl
ZC4gSSdsbCByZXBseSBiYWNrIHRvIHRoZSBvcmlnaW5hbCBjaGFuZ2Ugd2l0aCBteSBUZXN0ZWQt
Ynk6Lg0KDQo=

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=3d55=G5=lists.infradead.org=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 6651FC433DB
	for <linux-arm-kernel@archiver.kernel.org>; Tue, 26 Jan 2021 20:28:34 +0000 (UTC)
Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 0665220770
	for <linux-arm-kernel@archiver.kernel.org>; Tue, 26 Jan 2021 20:28:33 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0665220770
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alliedtelesis.co.nz
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding:
	Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive:
	List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References:
	Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date:
	Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;
	 bh=a2z6bG9JlzdstE6U22Mg+IBn3A5Dnvy2ksMXrHS9ktc=; b=VHvHdcAiDFOzXpuIb2XgbXhwK
	c5T6dpuMCGZikSdaPM8o2pPCgtMy07TRuZJROLNxVK+xFBuMPTTy5gXNwyRyeoXY/f5SC0Fa9r2A0
	/FEq6O02LnVsag3BF/Myvnq9RClQbk0+TM3T8F4S6JYOz2u8y1XJ5WTE3aYmYF7dYK+f0ulEVfxtp
	b6rLuu7eYKlgEAYzFZKMmCiR9XpqgI53sgDFED5zBFqLDl5lWvdLEJabsM8FopEfxZnxS99fEGbsJ
	pb7FSlk7/fsTe42qQ7uznU+IUpPc2sMgVU3ZOSQ7C0oiLG0Ixevpd6tZohDfzfDh7a7gRjGD6TwA7
	skEaxA4EA==;
Received: from localhost ([::1] helo=merlin.infradead.org)
	by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux))
	id 1l4Uug-0008Pg-Mf; Tue, 26 Jan 2021 20:26:10 +0000
Received: from gate2.alliedtelesis.co.nz ([2001:df5:b000:5::4])
 by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux))
 id 1l4Uuc-0008OU-Tm
 for linux-arm-kernel@lists.infradead.org; Tue, 26 Jan 2021 20:26:08 +0000
Received: from mmarshal3.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id 93C4383646;
 Wed, 27 Jan 2021 09:26:01 +1300 (NZDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz;
 s=mail181024; t=1611692761;
 bh=Uc+sbTNx0GLcEiykqP/dbDEH+LGhadiKUZ0d1aPtToM=;
 h=From:To:CC:Subject:Date:References:In-Reply-To;
 b=jCy0bxl5orihLgQ6KSyNpCosLXVQOSVSCq2OO85oxezDmLb8Uo9o05giTJ4TABR6T
 vk3WsCPrOwiLHqC51W8QrqQDbsQBBzKYOVYx1/QNFGFWGgZDNXxH496G0A6S751KQV
 Dcs22OgU8JshJOrdDf8LHIhS2+WjXq9sw/1vR+EOu1IHqg2EdmN/2cYP7qkdKHPjro
 sszkGn16jjB26XS0Aqxlmkx6awf0TqXJ/EbTtbBrOkiufc/lckILEx/TGAdi8y4oW0
 HZiYGqbmZH9KFwF87rVCR4/+KnLGI59TTrq9owBjkJ+PmGdgTE9rOfbsLd7hSYxIxn
 GLY6ycWI7XG2g==
Received: from svr-chch-ex1.atlnz.lc (Not Verified[10.32.16.77]) by
 mmarshal3.atlnz.lc with Trustwave SEG (v7, 5, 8, 10121)
 id <B60107ada0000>; Wed, 27 Jan 2021 09:26:02 +1300
Received: from svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8::77) by
 svr-chch-ex1.atlnz.lc (2001:df5:b000:bc8::77) with Microsoft SMTP Server
 (TLS) id 15.0.1497.2; Wed, 27 Jan 2021 09:26:01 +1300
Received: from svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8]) by
 svr-chch-ex1.atlnz.lc ([fe80::409d:36f5:8899:92e8%12]) with mapi id
 15.00.1497.010; Wed, 27 Jan 2021 09:26:01 +1300
From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Rob Herring <robh@kernel.org>
Subject: Re: [PATCH] ARM: zImage: atags_to_fdt: Fix node names on added root
 nodes
Thread-Topic: [PATCH] ARM: zImage: atags_to_fdt: Fix node names on added root
 nodes
Thread-Index: AQHW84xwlZl6qBJpAEuzuF8M0I/jXKo4WucAgADCIACAAGJDgIAAApoA
Date: Tue, 26 Jan 2021 20:26:00 +0000
Message-ID: <5eb47de6-16b0-7ee2-1c3f-4de73570e575@alliedtelesis.co.nz>
References: <20210126023905.1631161-1-robh@kernel.org>
 <329a3043-a85f-8177-c3ad-a9c07604a266@alliedtelesis.co.nz>
 <CAL_JsqLHrd40WqqMEZU0NqgVNLS2rw1u_SgR26dt3nw3mCsr3w@mail.gmail.com>
 <9ae5d166-1183-f1fc-b255-f4497d321d29@alliedtelesis.co.nz>
In-Reply-To: <9ae5d166-1183-f1fc-b255-f4497d321d29@alliedtelesis.co.nz>
Accept-Language: en-NZ, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.32.1.11]
Content-ID: <7E225722E51E1842A7E166AFEE665D68@atlnz.lc>
MIME-Version: 1.0
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20210126_152607_977218_E7D84413 
X-CRM114-Status: GOOD (  31.33  )
X-BeenThere: linux-arm-kernel@lists.infradead.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <linux-arm-kernel.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, 
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
 Russell King <linux@armlinux.org.uk>,
 "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
 Qi Zheng <arch0.zheng@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org


On 27/01/21 9:16 am, Chris Packham wrote:
> Hi Rob
>
> On 27/01/21 3:25 am, Rob Herring wrote:
>> On Mon, Jan 25, 2021 at 8:50 PM Chris Packham
>> <Chris.Packham@alliedtelesis.co.nz> wrote:
>>> Hi Rob,
>>>
>>> On 26/01/21 3:39 pm, Rob Herring wrote:
>>>> Commit 7536c7e03e74 ("of/fdt: Remove redundant kbasename function
>>>> call") exposed a bug creating DT nodes in the ATAGS to DT fixup code.
>>>> Non-existent nodes would mistaken get created with a leading '/'. The
>>>> problem was fdt_path_offset() takes a full path while creating a node
>>>> with fdt_add_subnode() takes just the basename.
>>>>
>>>> Since this we only add root child nodes, we can just skip over the 
>>>> '/'.
>>>>
>>>> Fixes: 7536c7e03e74 ("of/fdt: Remove redundant kbasename function 
>>>> call")
>>>> Reported-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
>>>> Cc: Qi Zheng <arch0.zheng@gmail.com>
>>>> Cc: Russell King <linux@armlinux.org.uk>
>>>> Signed-off-by: Rob Herring <robh@kernel.org>
>>> Thanks for the quick patch. It doesn't quite seem to work as my system
>>> can't find it's initrd (it can with my other hacky patch). It does seem
>>> to get the command line info as I'm getting printk output.
>> That doesn't make sense. Can you enable debug in drivers/of/fdt.c.
> I've attached two captures with DEBUG enabled in drivers/of/fdt.c. One 
> with your patch and one with mine. I note that in your one we do 
> actually pick up initrd_start/initrd_end but then it gets disabled for 
> some reason (possibly other changes we have in our kernel).

Sure enough I turned off our "special" code and it all works as 
expected. I'll reply back to the original change with my Tested-by:.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel