From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Michał Krawczyk" <mk@semihalf.com>, "David Harton" <dharton@cisco.com>
Cc: Marcin Wojtas <mw@semihalf.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Chauskin, Igor" <igorch@amazon.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ena: fix releasing Tx ring mbufs
Date: Wed, 7 Apr 2021 09:15:38 +0100 [thread overview]
Message-ID: <5eb92c99-7564-b3f5-bc4b-8b35657b6d74@intel.com> (raw)
In-Reply-To: <CAJMMOfPKEQKJCUB6ZTpXciw2coUM9U+YEoMW-2DNz=U_sNuS_g@mail.gmail.com>
On 4/6/2021 6:25 AM, Michał Krawczyk wrote:
> wt., 6 kwi 2021 o 02:27 David Harton <dharton@cisco.com> napisał(a):
>>
>> When ena_tx_queue_release_bufs() frees the mbufs it does not clear
>> the mbuf pointers. So, when the device starts and stops multiple
>> times it can cause the application to receive duplicate mbufs for
>> two different packets. Fix the issue by clearing the mbuf pointer.
>>
>> Also, while tracking down the "double free" issue the ena calls to
>> allocate and free mbufs in bulk were migrated to the mbuf based APIs
>> so the common mbuf alloc/free routines are exercised.
>>
>> Fixes: 79405ee17585 ("net/ena: fix out of order completion")
>> Fixes: 1173fca25af9 ("ena: add polling-mode driver")
>>
>> Signed-off-by: David Harton <dharton@cisco.com>
> Acked-by: Michal Krawczyk <mk@semihalf.com>
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2021-04-07 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 0:27 [dpdk-dev] [PATCH] net/ena: fix releasing Tx ring mbufs David Harton
2021-04-06 5:25 ` Michał Krawczyk
2021-04-07 8:15 ` Ferruh Yigit [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-05 18:57 David Harton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eb92c99-7564-b3f5-bc4b-8b35657b6d74@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.