From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/5] Remove delay_iput parameter when running delalloc work
Date: Mon, 23 Apr 2018 12:31:17 +0300 [thread overview]
Message-ID: <5eb93fa2-727f-8e62-2ee4-dfb59f07888c@suse.com> (raw)
In-Reply-To: <b4e0bd43-ad9e-55f5-4e33-7845fdb89270@gmx.com>
On 23.04.2018 12:27, Qu Wenruo wrote:
>
>
> On 2018年04月23日 15:54, Nikolay Borisov wrote:
>> While trying to make sense of the lifecycle of delayed iputs it became apparent
>> that the delay_iput parameter of btrfs_start_delalloc_roots/
>> btrfs_start_delalloc_inodes is always set to 0. (Patch 1 contains historical
>> information of why this parameter was needed and when it became obsolete). Now
>> that the code has changed sufficiently it's no longer required to have it so
>> this series gradually removes it.
>>
>> Nikolay Borisov (5):
>> btrfs: Remove delayed_iput parameter of btrfs_start_delalloc_roots
>> btrfs: Remove delayed_iput parameter from btrfs_start_delalloc_inodes
>> btrfs: Remove delay_iput parameter from __start_delalloc_inodes
>> btrfs: Remove delayed_iput member from btrfs_delalloc_work
>> btrfs: Unexport btrfs_alloc_delalloc_work
>
> Solid cleanup.
>
> Reviewed-by: Qu Wenruo <wqu@suse.com>
>
> Just a little nitpick about the 3rd and 4th patch.
> It would be nicer the merge them, as in the the 3rd patch
> btrfs_alloc_delalloc_work() call still takes 0 as @delay_iput, but in
> next patch the @delay_iput just get removed.
I'm fine with that, I guess David if you deem it more reasonable you
could squash the 2 patches. I just did it for the sake of bisectability
and review purposes.
>
> Thanks,
> Qu
>
>>
>> fs/btrfs/ctree.h | 9 ++-------
>> fs/btrfs/dev-replace.c | 2 +-
>> fs/btrfs/extent-tree.c | 4 ++--
>> fs/btrfs/inode.c | 28 +++++++++-------------------
>> fs/btrfs/ioctl.c | 4 ++--
>> 5 files changed, 16 insertions(+), 31 deletions(-)
>>
>
next prev parent reply other threads:[~2018-04-23 9:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 7:54 [PATCH 0/5] Remove delay_iput parameter when running delalloc work Nikolay Borisov
2018-04-23 7:54 ` [PATCH 1/5] btrfs: Remove delayed_iput parameter of btrfs_start_delalloc_roots Nikolay Borisov
2018-04-23 7:54 ` [PATCH 2/5] btrfs: Remove delayed_iput parameter from btrfs_start_delalloc_inodes Nikolay Borisov
2018-04-23 7:54 ` [PATCH 3/5] btrfs: Remove delay_iput parameter from __start_delalloc_inodes Nikolay Borisov
2018-04-24 13:26 ` David Sterba
2018-04-23 7:54 ` [PATCH 4/5] btrfs: Remove delayed_iput member from btrfs_delalloc_work Nikolay Borisov
2018-04-23 7:54 ` [PATCH 5/5] btrfs: Unexport btrfs_alloc_delalloc_work Nikolay Borisov
2018-04-24 13:22 ` David Sterba
2018-04-24 13:27 ` Nikolay Borisov
2018-04-24 14:23 ` [PATCH v2] " Nikolay Borisov
2018-04-24 14:24 ` David Sterba
2018-04-23 9:27 ` [PATCH 0/5] Remove delay_iput parameter when running delalloc work Qu Wenruo
2018-04-23 9:31 ` Nikolay Borisov [this message]
2018-04-24 13:29 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eb93fa2-727f-8e62-2ee4-dfb59f07888c@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.