Re: [PATCH] drm/i915/guc: limit forcewake to blitter domain in guc_send

From: "Kamble, Sagar A" <sagar.a.kamble@intel.com>
To: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/guc: limit forcewake to blitter domain in guc_send
Date: Fri, 24 Mar 2017 21:12:13 +0530	[thread overview]
Message-ID: <5ecc82cb-eb03-da54-7f92-b0197522b973@intel.com> (raw)
In-Reply-To: <1490366919-34715-1-git-send-email-daniele.ceraolospurio@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1416 bytes --]

Reviewed-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>

On 3/24/2017 8:18 PM, Daniele Ceraolo Spurio wrote:
> The forcewake_get call in the guc_send_mmio function was added to
> avoid getting and releasing forcewake on each register access.
> While this makes sense, all GuC registers are in the blitter range
> so no need to wake all the wells.
>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_uc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c
> index 4a872cd..e016227 100644
> --- a/drivers/gpu/drm/i915/intel_uc.c
> +++ b/drivers/gpu/drm/i915/intel_uc.c
> @@ -245,7 +245,7 @@ int intel_guc_send_mmio(struct intel_guc *guc, const u32 *action, u32 len)
>   		return -EINVAL;
>   
>   	mutex_lock(&guc->send_mutex);
> -	intel_uncore_forcewake_get(dev_priv, FORCEWAKE_ALL);
> +	intel_uncore_forcewake_get(dev_priv, FORCEWAKE_BLITTER);
>   
>   	dev_priv->guc.action_count += 1;
>   	dev_priv->guc.action_cmd = action[0];
> @@ -283,7 +283,7 @@ int intel_guc_send_mmio(struct intel_guc *guc, const u32 *action, u32 len)
>   	}
>   	dev_priv->guc.action_status = status;
>   
> -	intel_uncore_forcewake_put(dev_priv, FORCEWAKE_ALL);
> +	intel_uncore_forcewake_put(dev_priv, FORCEWAKE_BLITTER);
>   	mutex_unlock(&guc->send_mutex);
>   
>   	return ret;


[-- Attachment #1.2: Type: text/html, Size: 1937 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx