From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F17F360 for ; Wed, 9 Nov 2022 08:35:04 +0000 (UTC) Received: by mail-lj1-f171.google.com with SMTP id z24so24660379ljn.4 for ; Wed, 09 Nov 2022 00:35:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eRe+iUOfvkcxJoHuIXXR4MLe1rQG7TVTlNUlRcP2Dec=; b=suGsbchNoQd/YUlruHGawy9LwhK15ytErdqSCujrzGeKX0Cp3GCYsv43dFbpq5F8m0 g856GrqvMawQZJ850dnqRqa1rvFF68eH5ae02Ol21a4gKgu1gqH2PWivtq+VvBulZxS4 hxIBdZyvmfLnOeMajYjAcHVQ8R7B0S+a3hi5nzM1utqytr3n1J4unHwrrrOqKohVcUxU 09OrNnRsQt36ZK6ejjQodcZJuPnoHJ2uUk+lY6NOQdjDaFONDc/TfVVe9hU0ipau5JzJ sDmfBIgZRc6QFGRpUIB4ORNEfR+vvAmmygh6MdDj3EYwhoekffKxT5IO4ZPWf3uBnR7L M/TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eRe+iUOfvkcxJoHuIXXR4MLe1rQG7TVTlNUlRcP2Dec=; b=TjUdmX0ZXs8NxqGZI/HIE/jYB06/WdhDUf8ZqOmK5hfvmBfZ2dCv5JQBM1ZjYhkw3T uqgdsaCJn37BU1LmL+pDxAeeuIO34MnJMahzVyDySx76yIPCAyp/Fxbpwmlbjnj997E1 +/vaMEpjMf9qU/vXLaha7WWh6io3CDjjX43gmu7j8H75HpWfwSUb1r+QIINwHi0lvX1j TF9yWH0mGahuvib0BQJxLtsWAxBC4CGunkiTFGuCSzy4f6Fx3MKQUmIE4hRXlvo523Ri Jyf2aE0bQztIrcTTrjpv3SjGfdseUw2MO0tai8i4tzl52lkfIRagySlgJC33TEOk6SYN i8dQ== X-Gm-Message-State: ACrzQf2DnC9gBw90PJ6PdkzUQfml286kHx5B7bVjjJ/TX5o4pC4I4q77 JoljWPqPY3KXarYeKX66mkgzVg== X-Google-Smtp-Source: AMsMyM5EvvhEo+VK7KZYK5bZiAFh/YqyA+iH9nSfpX2HhhgVJxaJmE2xnkCBjkvHqVskzDmv2WqMyA== X-Received: by 2002:a05:651c:179e:b0:26f:cba5:8ea1 with SMTP id bn30-20020a05651c179e00b0026fcba58ea1mr21850276ljb.241.1667982902089; Wed, 09 Nov 2022 00:35:02 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id w8-20020ac24428000000b00492ea54beeasm2119375lfl.306.2022.11.09.00.35.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 00:35:01 -0800 (PST) Message-ID: <5ed58fec-d929-3519-0d03-3e8061c6ca91@linaro.org> Date: Wed, 9 Nov 2022 09:35:00 +0100 Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller Content-Language: en-US To: "Russell King (Oracle)" Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Lee Jones , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter References: <531d88b8-75db-1d8f-1384-b8d05594e7b3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08/11/2022 23:22, Russell King (Oracle) wrote: > On Tue, Nov 08, 2022 at 09:55:58PM +0100, Krzysztof Kozlowski wrote: >> On 08/11/2022 17:33, Russell King (Oracle) wrote: >>> Add a DT binding for the Apple Mac System Management Controller. >> >> Drop the second, redundant "binding" from subject. It's already in prefix. > > Yet another thing that's been there from the start... how many more > things are you going to pick up in subsequent versions of the patch? > When does this stop? > > In any case, taking your comment literally, > > "dt-bindings: mfd: add for Apple Mac System Management Controller" > > makes no sense, so presumably you want something more than that. dt-bindings: mfd: add Apple Mac System Management Controller > > In any case, I see several recent cases already merged which follow > the pattern that I've used and that you've reviewed. Any many received comments to fix. I wouldn't mention it if there was no second issue - your patchset is non-bisectable. Since you must resend, please adjust the subject. > >>> Signed-off-by: Russell King (Oracle) >>> --- >>> .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ >>> 1 file changed, 67 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml >>> new file mode 100644 >>> index 000000000000..014eba5a1bbc >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml >>> @@ -0,0 +1,67 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Apple Mac System Management Controller >>> + >>> +maintainers: >>> + - Hector Martin >>> + >>> +description: >>> + Apple Mac System Management Controller implements various functions >>> + such as GPIO, RTC, power, reboot. >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - apple,t6000-smc >>> + - apple,t8103-smc >>> + - apple,t8112-smc >>> + - const: apple,smc >>> + >>> + reg: >>> + items: >>> + - description: SMC area >>> + - description: SRAM area >>> + >>> + reg-names: >>> + items: >>> + - const: smc >>> + - const: sram >>> + >>> + mboxes: >>> + maxItems: 1 >>> + >>> + gpio: >>> + $ref: /schemas/gpio/gpio-macsmc.yaml >> >> So this depends on other patch, so: >> 1. You need mention the dependency in cover letter (nothing there), >> 2. Re-order patches. >> >> The GPIO cannot go separate tree and this must be explicitly communicated. > > Sigh, getting an order that is sensible is really bloody difficult. > I'm quite sure Lee is only going to want to apply the mfd bits. Then > what do we do with the other bits? GPIO stuff via the GPIO tree, then > wait a cycle before the rest can be merged. Or what? It's nothing new... bindings headers, drivers and DTS all have it since years. Your case is actually easy to solve: 1. Re-order patches, describe dependency, get ack from one maintainer so it can go via other. 2. Squash patches and describe dependency. Only one maintainer will need to pick it up (with second's ack). I don't understand why we talk about such basics, you are far way more experienced in kernel development than many of us... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20B97C4332F for ; Wed, 9 Nov 2022 08:36:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L7OaxYST76eFa1/yvpJ2mGuARjkm8U5FrgV8Bfs8ayg=; b=RJ1X3hwDW2HNaA tXnif0FKhDPfZ6FpiDEvpYDkendYsyH7apUsmpoBHeSkCIWhVXtBGjFW0/5nLZf7JtzKlSCagSn5Z wVKXVBAVAKRsOnlpPvQWNljdRxtESzb/Kl0wNb0G0HC1zWISbF5qxdtpsrbsd0ak0fiB2POEQJV/W g0yP7XJp6prPM0KemUr9FzeYyJBuXV0rKMt6hlWswidWw+MiImHtiP1ogPPO1vNqjnVIcqA/YenXS cOU2dbfVCaCQoTP0+VCPdbqNi1E3lIYHhEtEtJpqpljoxQ+FGhttuiw6MOs3R9O+IPQrlSP570exo 63cX6Q+JPg3CEj4WA5Nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osgYC-00Bv0f-8Z; Wed, 09 Nov 2022 08:35:12 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osgY8-00Buz8-71 for linux-arm-kernel@lists.infradead.org; Wed, 09 Nov 2022 08:35:09 +0000 Received: by mail-lj1-x22a.google.com with SMTP id l8so24651741ljh.13 for ; Wed, 09 Nov 2022 00:35:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eRe+iUOfvkcxJoHuIXXR4MLe1rQG7TVTlNUlRcP2Dec=; b=suGsbchNoQd/YUlruHGawy9LwhK15ytErdqSCujrzGeKX0Cp3GCYsv43dFbpq5F8m0 g856GrqvMawQZJ850dnqRqa1rvFF68eH5ae02Ol21a4gKgu1gqH2PWivtq+VvBulZxS4 hxIBdZyvmfLnOeMajYjAcHVQ8R7B0S+a3hi5nzM1utqytr3n1J4unHwrrrOqKohVcUxU 09OrNnRsQt36ZK6ejjQodcZJuPnoHJ2uUk+lY6NOQdjDaFONDc/TfVVe9hU0ipau5JzJ sDmfBIgZRc6QFGRpUIB4ORNEfR+vvAmmygh6MdDj3EYwhoekffKxT5IO4ZPWf3uBnR7L M/TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eRe+iUOfvkcxJoHuIXXR4MLe1rQG7TVTlNUlRcP2Dec=; b=uIYtAb9c2tShJA/IY89OSUEl6oCnwJOXrefswjn0CPOdokdH3XNf7wbvZJBxhJRBGd yVGlorMHWCIuNsp24qGxVW0bi+4/QfpMseC9cM5hcMPShUpBZKZ2SVUz+W8Fpy7wDYKZ 513mAEBJRqJeWGcgOsNLJtDs8BHpSobtU9Jg2ZaD9Zm4uDUsmNJ+GhMcS9mTKSPtMoLP rbWOQ0oAXLfuW47zU9uuDydMAwKOIin3cr9qxSX30xlIUXadTa1uQShhLpn13bwYeJUd dta6xCVSsXPsoYOhrfuCyt+8bL+tPs6NfwGdEPzTJhKfHHQcoRtSI8fqGLmeIWMkDHNR vvqQ== X-Gm-Message-State: ACrzQf3Z9m73/ShrZuCnRjnM432QPdCd3o3B25qjYuq+03lMZ3WIUcGG rw99IYbVa2SMXFpoqnsQhfvYIQ== X-Google-Smtp-Source: AMsMyM5EvvhEo+VK7KZYK5bZiAFh/YqyA+iH9nSfpX2HhhgVJxaJmE2xnkCBjkvHqVskzDmv2WqMyA== X-Received: by 2002:a05:651c:179e:b0:26f:cba5:8ea1 with SMTP id bn30-20020a05651c179e00b0026fcba58ea1mr21850276ljb.241.1667982902089; Wed, 09 Nov 2022 00:35:02 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id w8-20020ac24428000000b00492ea54beeasm2119375lfl.306.2022.11.09.00.35.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 00:35:01 -0800 (PST) Message-ID: <5ed58fec-d929-3519-0d03-3e8061c6ca91@linaro.org> Date: Wed, 9 Nov 2022 09:35:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller Content-Language: en-US To: "Russell King (Oracle)" Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Lee Jones , Alyssa Rosenzweig , Andy Shevchenko , asahi@lists.linux.dev, devicetree@vger.kernel.org, Hector Martin , Jonathan Corbet , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-gpio@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Sven Peter References: <531d88b8-75db-1d8f-1384-b8d05594e7b3@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221109_003508_303006_75B6627F X-CRM114-Status: GOOD ( 24.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/11/2022 23:22, Russell King (Oracle) wrote: > On Tue, Nov 08, 2022 at 09:55:58PM +0100, Krzysztof Kozlowski wrote: >> On 08/11/2022 17:33, Russell King (Oracle) wrote: >>> Add a DT binding for the Apple Mac System Management Controller. >> >> Drop the second, redundant "binding" from subject. It's already in prefix. > > Yet another thing that's been there from the start... how many more > things are you going to pick up in subsequent versions of the patch? > When does this stop? > > In any case, taking your comment literally, > > "dt-bindings: mfd: add for Apple Mac System Management Controller" > > makes no sense, so presumably you want something more than that. dt-bindings: mfd: add Apple Mac System Management Controller > > In any case, I see several recent cases already merged which follow > the pattern that I've used and that you've reviewed. Any many received comments to fix. I wouldn't mention it if there was no second issue - your patchset is non-bisectable. Since you must resend, please adjust the subject. > >>> Signed-off-by: Russell King (Oracle) >>> --- >>> .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ >>> 1 file changed, 67 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml >>> new file mode 100644 >>> index 000000000000..014eba5a1bbc >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml >>> @@ -0,0 +1,67 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Apple Mac System Management Controller >>> + >>> +maintainers: >>> + - Hector Martin >>> + >>> +description: >>> + Apple Mac System Management Controller implements various functions >>> + such as GPIO, RTC, power, reboot. >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - apple,t6000-smc >>> + - apple,t8103-smc >>> + - apple,t8112-smc >>> + - const: apple,smc >>> + >>> + reg: >>> + items: >>> + - description: SMC area >>> + - description: SRAM area >>> + >>> + reg-names: >>> + items: >>> + - const: smc >>> + - const: sram >>> + >>> + mboxes: >>> + maxItems: 1 >>> + >>> + gpio: >>> + $ref: /schemas/gpio/gpio-macsmc.yaml >> >> So this depends on other patch, so: >> 1. You need mention the dependency in cover letter (nothing there), >> 2. Re-order patches. >> >> The GPIO cannot go separate tree and this must be explicitly communicated. > > Sigh, getting an order that is sensible is really bloody difficult. > I'm quite sure Lee is only going to want to apply the mfd bits. Then > what do we do with the other bits? GPIO stuff via the GPIO tree, then > wait a cycle before the rest can be merged. Or what? It's nothing new... bindings headers, drivers and DTS all have it since years. Your case is actually easy to solve: 1. Re-order patches, describe dependency, get ack from one maintainer so it can go via other. 2. Squash patches and describe dependency. Only one maintainer will need to pick it up (with second's ack). I don't understand why we talk about such basics, you are far way more experienced in kernel development than many of us... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel