From: Johannes Berg <johannes@sipsolutions.net>
To: Arnd Bergmann <arnd@kernel.org>,
"Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Cc: "Coelho, Luciano" <luciano.coelho@intel.com>,
Kalle Valo <kvalo@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"Beker, Ayala" <ayala.beker@intel.com>,
"Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: work around reverse dependency on MEI
Date: Tue, 07 Dec 2021 15:40:25 +0100 [thread overview]
Message-ID: <5ed6ad0f5d4fed1cb0a49ecfd7f6b35dbe0f0803.camel@sipsolutions.net> (raw)
In-Reply-To: <CAK8P3a35HHPs2sMsfQ_SrX4DTKmzidFUOczu8khzwJJTAy++yw@mail.gmail.com>
On Tue, 2021-12-07 at 14:25 +0100, Arnd Bergmann wrote:
> > > config IWLMEI
> > > - tristate "Intel Management Engine communication over WLAN"
> > > - depends on INTEL_MEI
> > > + bool "Intel Management Engine communication over WLAN"
> > > + depends on INTEL_MEI=y || INTEL_MEI=IWLMVM
> > > + depends on IWLMVM=y || IWLWIFI=m
> > > depends on PM
> > > - depends on IWLMVM
> > > help
> > > Enables the iwlmei kernel module.
> >
> > Johannes suggested to make IWLMVM depend on IWLMEI || !IWLMEI
> > That worked as well, I just had issues with this in our internal backport based tree.
> > I need to spend a bit more time on this, but I admit my total ignorance in Kconfig's dialect.
>
> It's still not enough, the dependency is in iwlwifi, not in iwlmvm, so it
> would remain broken for IWLWIFI=y IWLMVM=m IWLMEI=m.
>
I missed the pcie/trans.c dependency, and the others are (I think) in
mvm...
but then we can do
config IWLWIFI
...
depends on IWLMEI || !IWLMEI
...
no? That way, we exclude IWLWIFI=y && IWLMEI=m, which I believe causes
the issue? And IWLMVM already depends on IWLWIFI (via the if clause), so
that
johannes
next prev parent reply other threads:[~2021-12-07 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 12:54 [PATCH] iwlwifi: work around reverse dependency on MEI Arnd Bergmann
2021-12-07 13:19 ` Grumbach, Emmanuel
2021-12-07 13:25 ` Arnd Bergmann
2021-12-07 14:40 ` Johannes Berg [this message]
2021-12-07 14:56 ` Arnd Bergmann
2021-12-07 14:10 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ed6ad0f5d4fed1cb0a49ecfd7f6b35dbe0f0803.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ayala.beker@intel.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
--cc=miriam.rachel.korenblit@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.