From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [alsa-devel] [PATCH 5/9] ASoC: tegra: add Tegra210 based AHUB driver Date: Fri, 24 Jan 2020 04:18:36 +0300 Message-ID: <5ed7482e-e874-9e11-c84e-7418e4b5162e@gmail.com> References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-6-git-send-email-spujar@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1579530198-13431-6-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sameer Pujar , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org 20.01.2020 17:23, Sameer Pujar пишет: [snip] > +static int tegra_ahub_get_value_enum(struct snd_kcontrol *kctl, > + struct snd_ctl_elem_value *uctl) > +{ > + struct snd_soc_component *cmpnt = snd_soc_dapm_kcontrol_component(kctl); > + struct tegra_ahub *ahub = snd_soc_component_get_drvdata(cmpnt); > + struct soc_enum *e = (struct soc_enum *)kctl->private_value; > + unsigned int reg, i, bit_pos = 0; > + > + /* > + * Find the bit position of current MUX input. > + * If nothing is set, position would be 0 and it corresponds to 'None'. > + */ > + for (i = 0; i < ahub->soc_data->reg_count; i++) { > + unsigned int reg_val; > + > + reg = e->reg + (TEGRA210_XBAR_PART1_RX * i); > + snd_soc_component_read(cmpnt, reg, ®_val); > + reg_val &= ahub->soc_data->mask[i]; > + > + if (reg_val) { > + bit_pos = ffs(reg_val) + > + (8 * cmpnt->val_bytes * i); Multiplication takes precedence, braces are not needed. Same for all other occurrences in the code. [snip] > + break; > + } > + } > + > + /* Find index related to the item in array *_ahub_mux_texts[] */ > + for (i = 0; i < e->items; i++) { > + if (bit_pos == e->values[i]) { > + uctl->value.enumerated.item[0] = i; > + break; > + } > + } > + > + return 0; > +} > + > +static int tegra_ahub_put_value_enum(struct snd_kcontrol *kctl, > + struct snd_ctl_elem_value *uctl) > +{ > + struct snd_soc_component *cmpnt = snd_soc_dapm_kcontrol_component(kctl); > + struct tegra_ahub *ahub = snd_soc_component_get_drvdata(cmpnt); > + struct snd_soc_dapm_context *dapm = snd_soc_dapm_kcontrol_dapm(kctl); > + struct soc_enum *e = (struct soc_enum *)kctl->private_value; > + struct snd_soc_dapm_update update[TEGRA_XBAR_UPDATE_MAX_REG] = { }; Shouldn't this be {0} to make array zero'ed? [snip] > +static int tegra_ahub_probe(struct platform_device *pdev) > +{ > + const struct of_device_id *match; > + struct tegra_ahub *ahub; > + struct tegra_ahub_soc_data *soc_data; > + void __iomem *regs; > + struct resource *res; > + int ret; > + > + match = of_match_device(tegra_ahub_of_match, &pdev->dev); > + if (!match) { > + dev_err(&pdev->dev, "error: no device match found\n"); > + return -ENODEV; > + } > + > + soc_data = (struct tegra_ahub_soc_data *)match->data; soc_data = device_get_match_data(&pdev->dev); > + ahub = devm_kcalloc(&pdev->dev, 1, sizeof(*ahub), GFP_KERNEL); > + if (!ahub) > + return -ENOMEM; > + > + ahub->soc_data = soc_data; > + > + platform_set_drvdata(pdev, ahub); > + > + ahub->clk = devm_clk_get(&pdev->dev, "ahub"); > + if (IS_ERR(ahub->clk)) { > + dev_err(&pdev->dev, "can't retrieve AHUB clock\n"); > + return PTR_ERR(ahub->clk); > + } > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + > + regs = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(regs)) > + return PTR_ERR(regs); regs = devm_platform_ioremap_resource(pdev, 0); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D66C35240 for ; Fri, 24 Jan 2020 01:18:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30C34206A2 for ; Fri, 24 Jan 2020 01:18:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gQvil3S7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731074AbgAXBSo (ORCPT ); Thu, 23 Jan 2020 20:18:44 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:32938 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730926AbgAXBSm (ORCPT ); Thu, 23 Jan 2020 20:18:42 -0500 Received: by mail-lf1-f66.google.com with SMTP id n25so130320lfl.0; Thu, 23 Jan 2020 17:18:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Qa1ZeKIxwMxhhVXWx6jah5pzEB39RZ2UXKKeVBvARPU=; b=gQvil3S7iFbcn3Zs8yz7OmBRM/dDoATirdGEZo2VCbmL8OTLPt7/ozLpiNQZdpg+WT 7fNM9+G1SywrHuqMmvNR4XL1FL0+A0/Qt0t1CPFRe8FBJHZu42bClhUubNNvVZgtH2GP kM3eg7TYMuQyPL4o0asf3vO55XaTS0yJb6XO5spInitlXvOGtydV1rc6ebnTH6BprioC 8H98izxEKeAdjG8oPxARdM8rk88hJ+J36UE3ZH99G3M+CtF7v9zW7a9YGacuHPRgUwfE uR7owsNEdBpOk91HfdXy5LmGWQdnFO+QnYALvsQz0P6QbRKCJwkmZSvX80FkdPwGGSzb 6ocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Qa1ZeKIxwMxhhVXWx6jah5pzEB39RZ2UXKKeVBvARPU=; b=huX1pbGXt+9aXBqosDL88+S8IXue165QQsJRGDgcOPzcpKpQoLxj7/z4xqoA0ridPr c9pcRZ4BAmiNUIdDJ0vHnCrxhH6r8t1FCt4ZkY4Oc1iu3wIEoBFxSvmPsZJI1nZFsAd/ +00L+0+j8AkXXAaOwD1c/m0SZOen/Q3o8oZ6ZnrJtYn5tJqschTLUBYYv3hLuJFub6ZB yC6oOQc9XQphQBBQrsMd95/gzfTztDV2il5aZoG4lHm32W3pwtCZncvgkYXL7gqty5XF z/19RwsUQRhoC9pHZGeevuJhiFHgWzywxxFBPjMoRtdLsd/KDUp9pt6nXD+cJVtZWEvx x12A== X-Gm-Message-State: APjAAAXziToYs4m1gwq1P6dblGNAVyIQFAF9kN9YsNqhr6RYkp5/qD++ tKHW/6LZEIsB0q9iY3kJ2gQ= X-Google-Smtp-Source: APXvYqxECFw30QnabkPguwcGpQ2JKwDUyv9e9T2Ryy+nL3W+5b0VqO7G9uYOHFCPG8/lASm/uehVZw== X-Received: by 2002:a19:4ad0:: with SMTP id x199mr241966lfa.13.1579828719604; Thu, 23 Jan 2020 17:18:39 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id k24sm2503908ljj.27.2020.01.23.17.18.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2020 17:18:38 -0800 (PST) Subject: Re: [alsa-devel] [PATCH 5/9] ASoC: tegra: add Tegra210 based AHUB driver To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, atalambedu@nvidia.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-6-git-send-email-spujar@nvidia.com> From: Dmitry Osipenko Message-ID: <5ed7482e-e874-9e11-c84e-7418e4b5162e@gmail.com> Date: Fri, 24 Jan 2020 04:18:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1579530198-13431-6-git-send-email-spujar@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 20.01.2020 17:23, Sameer Pujar пишет: [snip] > +static int tegra_ahub_get_value_enum(struct snd_kcontrol *kctl, > + struct snd_ctl_elem_value *uctl) > +{ > + struct snd_soc_component *cmpnt = snd_soc_dapm_kcontrol_component(kctl); > + struct tegra_ahub *ahub = snd_soc_component_get_drvdata(cmpnt); > + struct soc_enum *e = (struct soc_enum *)kctl->private_value; > + unsigned int reg, i, bit_pos = 0; > + > + /* > + * Find the bit position of current MUX input. > + * If nothing is set, position would be 0 and it corresponds to 'None'. > + */ > + for (i = 0; i < ahub->soc_data->reg_count; i++) { > + unsigned int reg_val; > + > + reg = e->reg + (TEGRA210_XBAR_PART1_RX * i); > + snd_soc_component_read(cmpnt, reg, ®_val); > + reg_val &= ahub->soc_data->mask[i]; > + > + if (reg_val) { > + bit_pos = ffs(reg_val) + > + (8 * cmpnt->val_bytes * i); Multiplication takes precedence, braces are not needed. Same for all other occurrences in the code. [snip] > + break; > + } > + } > + > + /* Find index related to the item in array *_ahub_mux_texts[] */ > + for (i = 0; i < e->items; i++) { > + if (bit_pos == e->values[i]) { > + uctl->value.enumerated.item[0] = i; > + break; > + } > + } > + > + return 0; > +} > + > +static int tegra_ahub_put_value_enum(struct snd_kcontrol *kctl, > + struct snd_ctl_elem_value *uctl) > +{ > + struct snd_soc_component *cmpnt = snd_soc_dapm_kcontrol_component(kctl); > + struct tegra_ahub *ahub = snd_soc_component_get_drvdata(cmpnt); > + struct snd_soc_dapm_context *dapm = snd_soc_dapm_kcontrol_dapm(kctl); > + struct soc_enum *e = (struct soc_enum *)kctl->private_value; > + struct snd_soc_dapm_update update[TEGRA_XBAR_UPDATE_MAX_REG] = { }; Shouldn't this be {0} to make array zero'ed? [snip] > +static int tegra_ahub_probe(struct platform_device *pdev) > +{ > + const struct of_device_id *match; > + struct tegra_ahub *ahub; > + struct tegra_ahub_soc_data *soc_data; > + void __iomem *regs; > + struct resource *res; > + int ret; > + > + match = of_match_device(tegra_ahub_of_match, &pdev->dev); > + if (!match) { > + dev_err(&pdev->dev, "error: no device match found\n"); > + return -ENODEV; > + } > + > + soc_data = (struct tegra_ahub_soc_data *)match->data; soc_data = device_get_match_data(&pdev->dev); > + ahub = devm_kcalloc(&pdev->dev, 1, sizeof(*ahub), GFP_KERNEL); > + if (!ahub) > + return -ENOMEM; > + > + ahub->soc_data = soc_data; > + > + platform_set_drvdata(pdev, ahub); > + > + ahub->clk = devm_clk_get(&pdev->dev, "ahub"); > + if (IS_ERR(ahub->clk)) { > + dev_err(&pdev->dev, "can't retrieve AHUB clock\n"); > + return PTR_ERR(ahub->clk); > + } > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + > + regs = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(regs)) > + return PTR_ERR(regs); regs = devm_platform_ioremap_resource(pdev, 0); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04EACC35242 for ; Fri, 24 Jan 2020 01:19:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72E5A2087E for ; Fri, 24 Jan 2020 01:19:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="DQp/A2ej"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gQvil3S7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72E5A2087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B335E169B; Fri, 24 Jan 2020 02:19:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B335E169B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579828792; bh=ojtyzsXzzk03fxw8GbLMOnRrxke1vShuRy/7iLklBr0=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DQp/A2ej7aojZswIwg4+/4kjlJlBIDvT8bA7I5O25veIggq5UGhSUAJAz+kPc07K9 nf3Txm016kusXlOLVznQuuGPVziVeM2OM9eGxH6lDIJpA2t86P8QytyCYKvfeoLZjW CUr5ZNDSB6/a1rGZ8rwE2hRcrdOznc2ej4J/I9rA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B278CF8015B; Fri, 24 Jan 2020 02:18:44 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3772BF80233; Fri, 24 Jan 2020 02:18:43 +0100 (CET) Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B2831F8015B for ; Fri, 24 Jan 2020 02:18:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B2831F8015B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gQvil3S7" Received: by mail-lf1-x141.google.com with SMTP id l18so126071lfc.1 for ; Thu, 23 Jan 2020 17:18:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Qa1ZeKIxwMxhhVXWx6jah5pzEB39RZ2UXKKeVBvARPU=; b=gQvil3S7iFbcn3Zs8yz7OmBRM/dDoATirdGEZo2VCbmL8OTLPt7/ozLpiNQZdpg+WT 7fNM9+G1SywrHuqMmvNR4XL1FL0+A0/Qt0t1CPFRe8FBJHZu42bClhUubNNvVZgtH2GP kM3eg7TYMuQyPL4o0asf3vO55XaTS0yJb6XO5spInitlXvOGtydV1rc6ebnTH6BprioC 8H98izxEKeAdjG8oPxARdM8rk88hJ+J36UE3ZH99G3M+CtF7v9zW7a9YGacuHPRgUwfE uR7owsNEdBpOk91HfdXy5LmGWQdnFO+QnYALvsQz0P6QbRKCJwkmZSvX80FkdPwGGSzb 6ocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Qa1ZeKIxwMxhhVXWx6jah5pzEB39RZ2UXKKeVBvARPU=; b=U+811GzGkoG84Ufz4LqPdE2m5Ajxcq6JxKG4FDZ6BwcsQV53mKH+oFKHPXOqc962aK pqEp1dt5F+w4VrA/VzdO055NcTqFAi995DXFfLITfSz5fgOlbC+s+Zo3BPstR6czgJCq GBMUCgvfzxhTVteiE2zrUOq6Ne9CLF687SBMkA+ir9IvOPAHFGt1f7HbBmJ3NcmAj/aY UuZYCuR77M4W3v78nmhXpUxUpcuJVzYyjWbQVsYsMqYbpz2RvVIiyIym/6CwMuBGirTz BE1Sscs/WGvrI5+4szglt+rboIUO9Gp3+ZRr1MQp6wpL09dqzlDFyYMZZxkAJPEbkSkz 8Piw== X-Gm-Message-State: APjAAAUy66WbRQ6BtTgKT44iSMUuurk1lz3QLHFdYmqV9GX/GrTPoxkM Oho4RBCd4jTlFq2zQ7PAMZbg5Xoz X-Google-Smtp-Source: APXvYqxECFw30QnabkPguwcGpQ2JKwDUyv9e9T2Ryy+nL3W+5b0VqO7G9uYOHFCPG8/lASm/uehVZw== X-Received: by 2002:a19:4ad0:: with SMTP id x199mr241966lfa.13.1579828719604; Thu, 23 Jan 2020 17:18:39 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id k24sm2503908ljj.27.2020.01.23.17.18.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2020 17:18:38 -0800 (PST) To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-6-git-send-email-spujar@nvidia.com> From: Dmitry Osipenko Message-ID: <5ed7482e-e874-9e11-c84e-7418e4b5162e@gmail.com> Date: Fri, 24 Jan 2020 04:18:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <1579530198-13431-6-git-send-email-spujar@nvidia.com> Content-Language: en-US Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, linux-tegra@vger.kernel.org, broonie@kernel.org, atalambedu@nvidia.com, sharadg@nvidia.com, thierry.reding@gmail.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH 5/9] ASoC: tegra: add Tegra210 based AHUB driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" MjAuMDEuMjAyMCAxNzoyMywgU2FtZWVyIFB1amFyINC/0LjRiNC10YI6CltzbmlwXQo+ICtzdGF0 aWMgaW50IHRlZ3JhX2FodWJfZ2V0X3ZhbHVlX2VudW0oc3RydWN0IHNuZF9rY29udHJvbCAqa2N0 bCwKPiArCQkJCSAgICAgc3RydWN0IHNuZF9jdGxfZWxlbV92YWx1ZSAqdWN0bCkKPiArewo+ICsJ c3RydWN0IHNuZF9zb2NfY29tcG9uZW50ICpjbXBudCA9IHNuZF9zb2NfZGFwbV9rY29udHJvbF9j b21wb25lbnQoa2N0bCk7Cj4gKwlzdHJ1Y3QgdGVncmFfYWh1YiAqYWh1YiA9IHNuZF9zb2NfY29t cG9uZW50X2dldF9kcnZkYXRhKGNtcG50KTsKPiArCXN0cnVjdCBzb2NfZW51bSAqZSA9IChzdHJ1 Y3Qgc29jX2VudW0gKilrY3RsLT5wcml2YXRlX3ZhbHVlOwo+ICsJdW5zaWduZWQgaW50IHJlZywg aSwgYml0X3BvcyA9IDA7Cj4gKwo+ICsJLyoKPiArCSAqIEZpbmQgdGhlIGJpdCBwb3NpdGlvbiBv ZiBjdXJyZW50IE1VWCBpbnB1dC4KPiArCSAqIElmIG5vdGhpbmcgaXMgc2V0LCBwb3NpdGlvbiB3 b3VsZCBiZSAwIGFuZCBpdCBjb3JyZXNwb25kcyB0byAnTm9uZScuCj4gKwkgKi8KPiArCWZvciAo aSA9IDA7IGkgPCBhaHViLT5zb2NfZGF0YS0+cmVnX2NvdW50OyBpKyspIHsKPiArCQl1bnNpZ25l ZCBpbnQgcmVnX3ZhbDsKPiArCj4gKwkJcmVnID0gZS0+cmVnICsgKFRFR1JBMjEwX1hCQVJfUEFS VDFfUlggKiBpKTsKPiArCQlzbmRfc29jX2NvbXBvbmVudF9yZWFkKGNtcG50LCByZWcsICZyZWdf dmFsKTsKPiArCQlyZWdfdmFsICY9IGFodWItPnNvY19kYXRhLT5tYXNrW2ldOwo+ICsKPiArCQlp ZiAocmVnX3ZhbCkgewo+ICsJCQliaXRfcG9zID0gZmZzKHJlZ192YWwpICsKPiArCQkJCSAgKDgg KiBjbXBudC0+dmFsX2J5dGVzICogaSk7CgpNdWx0aXBsaWNhdGlvbiB0YWtlcyBwcmVjZWRlbmNl LCBicmFjZXMgYXJlIG5vdCBuZWVkZWQuIFNhbWUgZm9yIGFsbApvdGhlciBvY2N1cnJlbmNlcyBp biB0aGUgY29kZS4KCltzbmlwXQo+ICsJCQlicmVhazsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJLyog RmluZCBpbmRleCByZWxhdGVkIHRvIHRoZSBpdGVtIGluIGFycmF5ICpfYWh1Yl9tdXhfdGV4dHNb XSAqLwo+ICsJZm9yIChpID0gMDsgaSA8IGUtPml0ZW1zOyBpKyspIHsKPiArCQlpZiAoYml0X3Bv cyA9PSBlLT52YWx1ZXNbaV0pIHsKPiArCQkJdWN0bC0+dmFsdWUuZW51bWVyYXRlZC5pdGVtWzBd ID0gaTsKPiArCQkJYnJlYWs7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4g Kwo+ICtzdGF0aWMgaW50IHRlZ3JhX2FodWJfcHV0X3ZhbHVlX2VudW0oc3RydWN0IHNuZF9rY29u dHJvbCAqa2N0bCwKPiArCQkJCSAgICAgc3RydWN0IHNuZF9jdGxfZWxlbV92YWx1ZSAqdWN0bCkK PiArewo+ICsJc3RydWN0IHNuZF9zb2NfY29tcG9uZW50ICpjbXBudCA9IHNuZF9zb2NfZGFwbV9r Y29udHJvbF9jb21wb25lbnQoa2N0bCk7Cj4gKwlzdHJ1Y3QgdGVncmFfYWh1YiAqYWh1YiA9IHNu ZF9zb2NfY29tcG9uZW50X2dldF9kcnZkYXRhKGNtcG50KTsKPiArCXN0cnVjdCBzbmRfc29jX2Rh cG1fY29udGV4dCAqZGFwbSA9IHNuZF9zb2NfZGFwbV9rY29udHJvbF9kYXBtKGtjdGwpOwo+ICsJ c3RydWN0IHNvY19lbnVtICplID0gKHN0cnVjdCBzb2NfZW51bSAqKWtjdGwtPnByaXZhdGVfdmFs dWU7Cj4gKwlzdHJ1Y3Qgc25kX3NvY19kYXBtX3VwZGF0ZSB1cGRhdGVbVEVHUkFfWEJBUl9VUERB VEVfTUFYX1JFR10gPSB7IH07CgpTaG91bGRuJ3QgdGhpcyBiZSB7MH0gdG8gbWFrZSBhcnJheSB6 ZXJvJ2VkPwoKW3NuaXBdCj4gK3N0YXRpYyBpbnQgdGVncmFfYWh1Yl9wcm9iZShzdHJ1Y3QgcGxh dGZvcm1fZGV2aWNlICpwZGV2KQo+ICt7Cj4gKwljb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkICpt YXRjaDsKPiArCXN0cnVjdCB0ZWdyYV9haHViICphaHViOwo+ICsJc3RydWN0IHRlZ3JhX2FodWJf c29jX2RhdGEgKnNvY19kYXRhOwo+ICsJdm9pZCBfX2lvbWVtICpyZWdzOwo+ICsJc3RydWN0IHJl c291cmNlICpyZXM7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCW1hdGNoID0gb2ZfbWF0Y2hfZGV2aWNl KHRlZ3JhX2FodWJfb2ZfbWF0Y2gsICZwZGV2LT5kZXYpOwo+ICsJaWYgKCFtYXRjaCkgewo+ICsJ CWRldl9lcnIoJnBkZXYtPmRldiwgImVycm9yOiBubyBkZXZpY2UgbWF0Y2ggZm91bmRcbiIpOwo+ ICsJCXJldHVybiAtRU5PREVWOwo+ICsJfQo+ICsKPiArCXNvY19kYXRhID0gKHN0cnVjdCB0ZWdy YV9haHViX3NvY19kYXRhICopbWF0Y2gtPmRhdGE7Cgpzb2NfZGF0YSA9IGRldmljZV9nZXRfbWF0 Y2hfZGF0YSgmcGRldi0+ZGV2KTsKCj4gKwlhaHViID0gZGV2bV9rY2FsbG9jKCZwZGV2LT5kZXYs IDEsIHNpemVvZigqYWh1YiksIEdGUF9LRVJORUwpOwo+ICsJaWYgKCFhaHViKQo+ICsJCXJldHVy biAtRU5PTUVNOwo+ICsKPiArCWFodWItPnNvY19kYXRhID0gc29jX2RhdGE7Cj4gKwo+ICsJcGxh dGZvcm1fc2V0X2RydmRhdGEocGRldiwgYWh1Yik7Cj4gKwo+ICsJYWh1Yi0+Y2xrID0gZGV2bV9j bGtfZ2V0KCZwZGV2LT5kZXYsICJhaHViIik7Cj4gKwlpZiAoSVNfRVJSKGFodWItPmNsaykpIHsK PiArCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJjYW4ndCByZXRyaWV2ZSBBSFVCIGNsb2NrXG4iKTsK PiArCQlyZXR1cm4gUFRSX0VSUihhaHViLT5jbGspOwo+ICsJfQo+ICsKPiArCXJlcyA9IHBsYXRm b3JtX2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX01FTSwgMCk7Cj4gKwo+ICsJcmVncyA9 IGRldm1faW9yZW1hcF9yZXNvdXJjZSgmcGRldi0+ZGV2LCByZXMpOwo+ICsJaWYgKElTX0VSUihy ZWdzKSkKPiArCQlyZXR1cm4gUFRSX0VSUihyZWdzKTsKCnJlZ3MgPSBkZXZtX3BsYXRmb3JtX2lv cmVtYXBfcmVzb3VyY2UocGRldiwgMCk7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1w cm9qZWN0Lm9yZwpodHRwczovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2Fsc2EtZGV2ZWwK