From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9757C433EF for ; Tue, 26 Apr 2022 17:51:20 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KnqF26Zfkz3bnZ for ; Wed, 27 Apr 2022 03:51:18 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=molgen.mpg.de (client-ip=141.14.17.11; helo=mx1.molgen.mpg.de; envelope-from=pmenzel@molgen.mpg.de; receiver=) Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KnqDb239Fz2xvW for ; Wed, 27 Apr 2022 03:50:52 +1000 (AEST) Received: from [172.18.211.123] (unknown [46.183.103.8]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 4756461E6478B; Tue, 26 Apr 2022 19:50:45 +0200 (CEST) Message-ID: <5ee55a29-85de-b84c-abbe-7100aa297a26@molgen.mpg.de> Date: Tue, 26 Apr 2022 19:50:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture Content-Language: en-US To: "Hawkins, Nick" References: <20220421192132.109954-1-nick.hawkins@hpe.com> <44c145a8-cbfd-c8e4-8391-76abb9562f97@molgen.mpg.de> From: Paul Menzel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "arnd@arndb.de" , Jean-Marie Verdun , Russell King , linux-kernel@vger.kernel.org, joel@jms.id.au, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Dear Nick, Am 26.04.22 um 19:28 schrieb Hawkins, Nick: > > > -----Original Message----- > From: Paul Menzel [mailto:pmenzel@molgen.mpg.de] > Sent: Tuesday, April 26, 2022 3:26 AM > To: Hawkins, Nick > Cc: Verdun, Jean-Marie ; joel@jms.id.au; arnd@arndb.de; openbmc@lists.ozlabs.org; Russell King ; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture [OT: Maybe use an email program, that does not add an unnecessary header.] […] >>> The GXP is the HPE BMC SoC that is used in the majority of HPE >>> Generation 10 servers. Traditionally the asic will last multiple >>> generations of server before being replaced. > >> Please mention what kind of documentation (datasheets, …) are available. > > Currently there are none available. The only reference I can provide > will be arm documentation. Too bad. >>> In gxp.c we reset the EHCI controller early to boot the asic. > >> Why does the EHCI controller need to be reset? > This functionality was moved into the boot loader. This message is > stale and needs to be removed. It was necessary for the chip to > boot. Understood. Please mention somewhere, what bootloader is used. >>> Info about SoC: >>> >>> HPE GXP is the name of the HPE Soc. This SoC is used to implement many >>> BMC features at HPE. It supports ARMv7 architecture based on the >>> Cortex A9 core. It is capable of using an AXI bus to which a memory >>> controller is attached. It has multiple SPI interfaces to connect boot >>> flash and BIOS flash. It uses a 10/100/1000 MAC for network >>> connectivity. It has multiple i2c engines to drive connectivity with a >>> host infrastructure. The initial patches enable the watchdog and timer >>> enabling the host to be able to boot. > >> Maybe doe that in separate commits? > Are you asking for me to have this paragraph in the other commits? > Or perhaps not mention the other patches in this paragraph? Yes, please move: > The initial patches enable the watchdog and timer enabling the host > to be able to boot. in a cover letter for example. >> Please reflow the commit message for 75 characters per line. > I will verify all the lines are under 75 characters. Please make sure the lines are as long as possible, while being at most 75 characters long. Kind regards, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 154ACC433F5 for ; Tue, 26 Apr 2022 17:52:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241756AbiDZRzF (ORCPT ); Tue, 26 Apr 2022 13:55:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353664AbiDZRyA (ORCPT ); Tue, 26 Apr 2022 13:54:00 -0400 Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D3D9E0FB for ; Tue, 26 Apr 2022 10:50:49 -0700 (PDT) Received: from [172.18.211.123] (unknown [46.183.103.8]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 4756461E6478B; Tue, 26 Apr 2022 19:50:45 +0200 (CEST) Message-ID: <5ee55a29-85de-b84c-abbe-7100aa297a26@molgen.mpg.de> Date: Tue, 26 Apr 2022 19:50:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture Content-Language: en-US To: "Hawkins, Nick" Cc: Jean-Marie Verdun , joel@jms.id.au, "arnd@arndb.de" , openbmc@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220421192132.109954-1-nick.hawkins@hpe.com> <44c145a8-cbfd-c8e4-8391-76abb9562f97@molgen.mpg.de> From: Paul Menzel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Nick, Am 26.04.22 um 19:28 schrieb Hawkins, Nick: > > > -----Original Message----- > From: Paul Menzel [mailto:pmenzel@molgen.mpg.de] > Sent: Tuesday, April 26, 2022 3:26 AM > To: Hawkins, Nick > Cc: Verdun, Jean-Marie ; joel@jms.id.au; arnd@arndb.de; openbmc@lists.ozlabs.org; Russell King ; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture [OT: Maybe use an email program, that does not add an unnecessary header.] […] >>> The GXP is the HPE BMC SoC that is used in the majority of HPE >>> Generation 10 servers. Traditionally the asic will last multiple >>> generations of server before being replaced. > >> Please mention what kind of documentation (datasheets, …) are available. > > Currently there are none available. The only reference I can provide > will be arm documentation. Too bad. >>> In gxp.c we reset the EHCI controller early to boot the asic. > >> Why does the EHCI controller need to be reset? > This functionality was moved into the boot loader. This message is > stale and needs to be removed. It was necessary for the chip to > boot. Understood. Please mention somewhere, what bootloader is used. >>> Info about SoC: >>> >>> HPE GXP is the name of the HPE Soc. This SoC is used to implement many >>> BMC features at HPE. It supports ARMv7 architecture based on the >>> Cortex A9 core. It is capable of using an AXI bus to which a memory >>> controller is attached. It has multiple SPI interfaces to connect boot >>> flash and BIOS flash. It uses a 10/100/1000 MAC for network >>> connectivity. It has multiple i2c engines to drive connectivity with a >>> host infrastructure. The initial patches enable the watchdog and timer >>> enabling the host to be able to boot. > >> Maybe doe that in separate commits? > Are you asking for me to have this paragraph in the other commits? > Or perhaps not mention the other patches in this paragraph? Yes, please move: > The initial patches enable the watchdog and timer enabling the host > to be able to boot. in a cover letter for example. >> Please reflow the commit message for 75 characters per line. > I will verify all the lines are under 75 characters. Please make sure the lines are as long as possible, while being at most 75 characters long. Kind regards, Paul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1B63C433F5 for ; Tue, 26 Apr 2022 17:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kDC93M6jhJ0vRrYvs9hUnQLYbX0cQl/NCkLHDXUqqX4=; b=rJI9LRPkgcN90H dsOC5wUcWRKTlrURwhxCtIru0SC9WRtbbk6GH7dFs/JZRt1SDuPvpEPNNHr9JBg3pn0KS3fb7hc0w 6IMdMeOK5Y7qDvLon29CkQ/K1rs0ahCpgH8Knp7So1qe9OZCNAI41qaF5Ema+u0btTjqCZWZNd5fl hp90SqfHGUDIEgsjiGbaIkj84TYlaRwMI5swOP5qj4tnWexchXZqcSDnLSDGHV1Dl3wNK/sUWeRo1 P1U6QAabh2wzhdHCoe13zYKtqIhRN/ZBKuXeBFfl/8XNnOvfDQpbsQhYhQqb86YxwBqJ8jcplDUc3 2zloaj3cJndA4bO0pOTQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njPL0-00FYxv-Ac; Tue, 26 Apr 2022 17:50:58 +0000 Received: from mx3.molgen.mpg.de ([141.14.17.11] helo=mx1.molgen.mpg.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njPKw-00FYwq-KP for linux-arm-kernel@lists.infradead.org; Tue, 26 Apr 2022 17:50:57 +0000 Received: from [172.18.211.123] (unknown [46.183.103.8]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 4756461E6478B; Tue, 26 Apr 2022 19:50:45 +0200 (CEST) Message-ID: <5ee55a29-85de-b84c-abbe-7100aa297a26@molgen.mpg.de> Date: Tue, 26 Apr 2022 19:50:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 01/11] aach: arm: mach-hpe: Introduce the HPE GXP architecture Content-Language: en-US To: "Hawkins, Nick" Cc: Jean-Marie Verdun , joel@jms.id.au, "arnd@arndb.de" , openbmc@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220421192132.109954-1-nick.hawkins@hpe.com> <44c145a8-cbfd-c8e4-8391-76abb9562f97@molgen.mpg.de> From: Paul Menzel In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_105054_859941_8450F27A X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CkRlYXIgTmljaywKCgpBbSAyNi4wNC4yMiB1bSAxOToyOCBzY2hyaWViIEhhd2tpbnMsIE5pY2s6 Cj4gCj4gCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiBGcm9tOiBQYXVsIE1lbnplbCBb bWFpbHRvOnBtZW56ZWxAbW9sZ2VuLm1wZy5kZV0KPiBTZW50OiBUdWVzZGF5LCBBcHJpbCAyNiwg MjAyMiAzOjI2IEFNCj4gVG86IEhhd2tpbnMsIE5pY2sgPG5pY2suaGF3a2luc0BocGUuY29tPgo+ IENjOiBWZXJkdW4sIEplYW4tTWFyaWUgPHZlcmR1bkBocGUuY29tPjsgam9lbEBqbXMuaWQuYXU7 IGFybmRAYXJuZGIuZGU7IG9wZW5ibWNAbGlzdHMub3psYWJzLm9yZzsgUnVzc2VsbCBLaW5nIDxs aW51eEBhcm1saW51eC5vcmcudWs+OyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5v cmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKPiBTdWJqZWN0OiBSZTogW1BBVENIIHY1 IDAxLzExXSBhYWNoOiBhcm06IG1hY2gtaHBlOiBJbnRyb2R1Y2UgdGhlIEhQRSBHWFAgYXJjaGl0 ZWN0dXJlCgpbT1Q6IE1heWJlIHVzZSBhbiBlbWFpbCBwcm9ncmFtLCB0aGF0IGRvZXMgbm90IGFk ZCBhbiB1bm5lY2Vzc2FyeSBoZWFkZXIuXQoKW+KApl0KCj4+PiBUaGUgR1hQIGlzIHRoZSBIUEUg Qk1DIFNvQyB0aGF0IGlzIHVzZWQgaW4gdGhlIG1ham9yaXR5IG9mIEhQRQo+Pj4gR2VuZXJhdGlv biAxMCBzZXJ2ZXJzLiBUcmFkaXRpb25hbGx5IHRoZSBhc2ljIHdpbGwgbGFzdCBtdWx0aXBsZQo+ Pj4gZ2VuZXJhdGlvbnMgb2Ygc2VydmVyIGJlZm9yZSBiZWluZyByZXBsYWNlZC4KPiAKPj4gUGxl YXNlIG1lbnRpb24gd2hhdCBraW5kIG9mIGRvY3VtZW50YXRpb24gKGRhdGFzaGVldHMsIOKApikg YXJlIGF2YWlsYWJsZS4KPiAKPiBDdXJyZW50bHkgdGhlcmUgYXJlIG5vbmUgYXZhaWxhYmxlLiBU aGUgb25seSByZWZlcmVuY2UgSSBjYW4gcHJvdmlkZQo+IHdpbGwgYmUgYXJtIGRvY3VtZW50YXRp b24uCgpUb28gYmFkLgoKPj4+IEluIGd4cC5jIHdlIHJlc2V0IHRoZSBFSENJIGNvbnRyb2xsZXIg ZWFybHkgdG8gYm9vdCB0aGUgYXNpYy4KPiAKPj4gV2h5IGRvZXMgdGhlIEVIQ0kgY29udHJvbGxl ciBuZWVkIHRvIGJlIHJlc2V0Pwo+IFRoaXMgZnVuY3Rpb25hbGl0eSB3YXMgbW92ZWQgaW50byB0 aGUgYm9vdCBsb2FkZXIuIFRoaXMgbWVzc2FnZSBpcwo+IHN0YWxlIGFuZCBuZWVkcyB0byBiZSBy ZW1vdmVkLiBJdCB3YXMgbmVjZXNzYXJ5IGZvciB0aGUgY2hpcCB0bwo+IGJvb3QuCgpVbmRlcnN0 b29kLiBQbGVhc2UgbWVudGlvbiBzb21ld2hlcmUsIHdoYXQgYm9vdGxvYWRlciBpcyB1c2VkLgoK Pj4+IEluZm8gYWJvdXQgU29DOgo+Pj4KPj4+IEhQRSBHWFAgaXMgdGhlIG5hbWUgb2YgdGhlIEhQ RSBTb2MuIFRoaXMgU29DIGlzIHVzZWQgdG8gaW1wbGVtZW50IG1hbnkKPj4+IEJNQyBmZWF0dXJl cyBhdCBIUEUuIEl0IHN1cHBvcnRzIEFSTXY3IGFyY2hpdGVjdHVyZSBiYXNlZCBvbiB0aGUKPj4+ IENvcnRleCBBOSBjb3JlLiBJdCBpcyBjYXBhYmxlIG9mIHVzaW5nIGFuIEFYSSBidXMgdG8gd2hp Y2ggYSBtZW1vcnkKPj4+IGNvbnRyb2xsZXIgaXMgYXR0YWNoZWQuIEl0IGhhcyBtdWx0aXBsZSBT UEkgaW50ZXJmYWNlcyB0byBjb25uZWN0IGJvb3QKPj4+IGZsYXNoIGFuZCBCSU9TIGZsYXNoLiBJ dCB1c2VzIGEgMTAvMTAwLzEwMDAgTUFDIGZvciBuZXR3b3JrCj4+PiBjb25uZWN0aXZpdHkuIEl0 IGhhcyBtdWx0aXBsZSBpMmMgZW5naW5lcyB0byBkcml2ZSBjb25uZWN0aXZpdHkgd2l0aCBhCj4+ PiBob3N0IGluZnJhc3RydWN0dXJlLiBUaGUgaW5pdGlhbCBwYXRjaGVzIGVuYWJsZSB0aGUgd2F0 Y2hkb2cgYW5kIHRpbWVyCj4+PiBlbmFibGluZyB0aGUgaG9zdCB0byBiZSBhYmxlIHRvIGJvb3Qu Cj4gCj4+IE1heWJlIGRvZSB0aGF0IGluIHNlcGFyYXRlIGNvbW1pdHM/Cj4gQXJlIHlvdSBhc2tp bmcgZm9yIG1lIHRvIGhhdmUgdGhpcyBwYXJhZ3JhcGggaW4gdGhlIG90aGVyIGNvbW1pdHM/Cj4g T3IgcGVyaGFwcyBub3QgbWVudGlvbiB0aGUgb3RoZXIgcGF0Y2hlcyBpbiB0aGlzIHBhcmFncmFw aD8KClllcywgcGxlYXNlIG1vdmU6Cgo+IFRoZSBpbml0aWFsIHBhdGNoZXMgZW5hYmxlIHRoZSB3 YXRjaGRvZyBhbmQgdGltZXIgZW5hYmxpbmcgdGhlIGhvc3QKPiB0byBiZSBhYmxlIHRvIGJvb3Qu CgppbiBhIGNvdmVyIGxldHRlciBmb3IgZXhhbXBsZS4KCj4+IFBsZWFzZSByZWZsb3cgdGhlIGNv bW1pdCBtZXNzYWdlIGZvciA3NSBjaGFyYWN0ZXJzIHBlciBsaW5lLgo+IEkgd2lsbCB2ZXJpZnkg YWxsIHRoZSBsaW5lcyBhcmUgdW5kZXIgNzUgY2hhcmFjdGVycy4KClBsZWFzZSBtYWtlIHN1cmUg dGhlIGxpbmVzIGFyZSBhcyBsb25nIGFzIHBvc3NpYmxlLCB3aGlsZSBiZWluZyBhdCBtb3N0IAo3 NSBjaGFyYWN0ZXJzIGxvbmcuCgoKS2luZCByZWdhcmRzLAoKUGF1bAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=