All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libxl: don't enable synthetic timer by default
@ 2019-05-07 13:36 ` Wei Liu
  0 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2019-05-07 13:36 UTC (permalink / raw)
  To: xen-devel; +Cc: Juergen Gross, Ian Jackson, Paul Durrant, Wei Liu

It broke Windows installation. More investigation is needed. Don't
enable it by default.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Paul Durrant <paul.durrant@citrix.com>
Cc: Juergen Gross <jgross@suse.com>
---
 tools/libxl/libxl_dom.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index 879c806139..c5685b061c 100644
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -269,7 +269,6 @@ static int hvm_set_viridian_features(libxl__gc *gc, uint32_t domid,
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_TIME_REF_COUNT);
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_APIC_ASSIST);
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_CRASH_CTL);
-        libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_STIMER);
     }
 
     libxl_for_each_set_bit(v, info->u.hvm.viridian_enable) {
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Xen-devel] [PATCH] libxl: don't enable synthetic timer by default
@ 2019-05-07 13:36 ` Wei Liu
  0 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2019-05-07 13:36 UTC (permalink / raw)
  To: xen-devel; +Cc: Juergen Gross, Ian Jackson, Paul Durrant, Wei Liu

It broke Windows installation. More investigation is needed. Don't
enable it by default.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Paul Durrant <paul.durrant@citrix.com>
Cc: Juergen Gross <jgross@suse.com>
---
 tools/libxl/libxl_dom.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
index 879c806139..c5685b061c 100644
--- a/tools/libxl/libxl_dom.c
+++ b/tools/libxl/libxl_dom.c
@@ -269,7 +269,6 @@ static int hvm_set_viridian_features(libxl__gc *gc, uint32_t domid,
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_TIME_REF_COUNT);
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_APIC_ASSIST);
         libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_CRASH_CTL);
-        libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_STIMER);
     }
 
     libxl_for_each_set_bit(v, info->u.hvm.viridian_enable) {
-- 
2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] libxl: don't enable synthetic timer by default
@ 2019-05-07 13:37   ` Paul Durrant
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Durrant @ 2019-05-07 13:37 UTC (permalink / raw)
  To: xen-devel; +Cc: Juergen Gross, Ian Jackson, Wei Liu

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@citrix.com]
> Sent: 07 May 2019 14:36
> To: xen-devel@lists.xenproject.org
> Cc: Wei Liu <wei.liu2@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>; Paul Durrant
> <Paul.Durrant@citrix.com>; Juergen Gross <jgross@suse.com>
> Subject: [PATCH] libxl: don't enable synthetic timer by default
> 
> It broke Windows installation. More investigation is needed. Don't
> enable it by default.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Reviewed-by: Paul Durrant <paul.durrant@citrix.com>

> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Paul Durrant <paul.durrant@citrix.com>
> Cc: Juergen Gross <jgross@suse.com>
> ---
>  tools/libxl/libxl_dom.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index 879c806139..c5685b061c 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -269,7 +269,6 @@ static int hvm_set_viridian_features(libxl__gc *gc, uint32_t domid,
>          libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_TIME_REF_COUNT);
>          libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_APIC_ASSIST);
>          libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_CRASH_CTL);
> -        libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_STIMER);
>      }
> 
>      libxl_for_each_set_bit(v, info->u.hvm.viridian_enable) {
> --
> 2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] libxl: don't enable synthetic timer by default
@ 2019-05-07 13:37   ` Paul Durrant
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Durrant @ 2019-05-07 13:37 UTC (permalink / raw)
  To: Wei Liu, xen-devel; +Cc: Juergen Gross, Ian Jackson, Wei Liu

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@citrix.com]
> Sent: 07 May 2019 14:36
> To: xen-devel@lists.xenproject.org
> Cc: Wei Liu <wei.liu2@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>; Paul Durrant
> <Paul.Durrant@citrix.com>; Juergen Gross <jgross@suse.com>
> Subject: [PATCH] libxl: don't enable synthetic timer by default
> 
> It broke Windows installation. More investigation is needed. Don't
> enable it by default.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Reviewed-by: Paul Durrant <paul.durrant@citrix.com>

> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Paul Durrant <paul.durrant@citrix.com>
> Cc: Juergen Gross <jgross@suse.com>
> ---
>  tools/libxl/libxl_dom.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c
> index 879c806139..c5685b061c 100644
> --- a/tools/libxl/libxl_dom.c
> +++ b/tools/libxl/libxl_dom.c
> @@ -269,7 +269,6 @@ static int hvm_set_viridian_features(libxl__gc *gc, uint32_t domid,
>          libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_TIME_REF_COUNT);
>          libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_APIC_ASSIST);
>          libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_CRASH_CTL);
> -        libxl_bitmap_set(&enlightenments, LIBXL_VIRIDIAN_ENLIGHTENMENT_STIMER);
>      }
> 
>      libxl_for_each_set_bit(v, info->u.hvm.viridian_enable) {
> --
> 2.20.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] libxl: don't enable synthetic timer by default
@ 2019-05-07 14:38   ` Juergen Gross
  0 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2019-05-07 14:38 UTC (permalink / raw)
  To: Wei Liu, xen-devel; +Cc: Paul Durrant, Ian Jackson

On 07/05/2019 15:36, Wei Liu wrote:
> It broke Windows installation. More investigation is needed. Don't
> enable it by default.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Thanks!


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [Xen-devel] [PATCH] libxl: don't enable synthetic timer by default
@ 2019-05-07 14:38   ` Juergen Gross
  0 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2019-05-07 14:38 UTC (permalink / raw)
  To: Wei Liu, xen-devel; +Cc: Paul Durrant, Ian Jackson

On 07/05/2019 15:36, Wei Liu wrote:
> It broke Windows installation. More investigation is needed. Don't
> enable it by default.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

Thanks!


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-07 14:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-07 13:36 [PATCH] libxl: don't enable synthetic timer by default Wei Liu
2019-05-07 13:36 ` [Xen-devel] " Wei Liu
2019-05-07 13:37 ` Paul Durrant
2019-05-07 13:37   ` [Xen-devel] " Paul Durrant
2019-05-07 14:38 ` Juergen Gross
2019-05-07 14:38   ` [Xen-devel] " Juergen Gross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.