From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8251BC433DF for ; Mon, 1 Jun 2020 23:03:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F0FE2073B for ; Mon, 1 Jun 2020 23:03:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="I62oPMhO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F0FE2073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:39836 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jftSg-0004Dc-H2 for qemu-devel@archiver.kernel.org; Mon, 01 Jun 2020 19:03:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jftRN-0003eo-DP for qemu-devel@nongnu.org; Mon, 01 Jun 2020 19:01:57 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:43273) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jftRL-0006Wk-HA for qemu-devel@nongnu.org; Mon, 01 Jun 2020 19:01:56 -0400 Received: by mail-pf1-x441.google.com with SMTP id g5so4133093pfm.10 for ; Mon, 01 Jun 2020 16:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MBwhioOTO5IwQ4eAH5O+LHoa1q/Fp8wPnF66132BV6w=; b=I62oPMhOzcriXPS+ul3GZ3PSdaR6gFw/VI6rYaWsgLSZ8o87jK+qiDYX1EXoNw31kS scLDgckCgcxRHkEg2fjgKy8bxunKvxEbslJjfLH2fy6LaM5eNGEKJXSuqKC6HIfcu6G5 1sjdhL18favA4hRG5Svk//8VYxkYwBXOdsyzPGIGequ1KZD8lvxcSTYDWVUjPWFsYFo7 tEsmo+bc63VDHcpSunMCcQE0u6kp0t20Ilhr9e1rBr3RtNQD6zpxOYs4m1eGNc+1my7L fBc0NJ7WzwnfwqzlafdSBOIIPoXNMPtcJ/S/aoEuXd069UT9ifyzQRCxjdFCXMxtOv9I tT+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MBwhioOTO5IwQ4eAH5O+LHoa1q/Fp8wPnF66132BV6w=; b=CFktWa73dHj+JuCfiqYpRXLAH/TuRDLJo6bjfU4i/bsRdv/lylOZ/YMFx1Jq7Sgtut zJ4H8xNLO2rio0MZ5EEddrcdJZY3Iy9oCkISvtY3Q5GQTGM2xEivJwZzcVzCDrn/IK8+ CLIrN1XrQJmGIqbn9pOGBLtwhEWYB8nLtEon2fwKUrKXIDAjiUeqhHykyWVIizklsyfA Fy5POwqp3GJatxpcsn5c4Ad3pFc/oPcbKsRlGR9/DBTfCFxPsFfgG+73gZ6Hy6iXLAiX BgQ/kMdStt6Qtwv2MJosHVOCu2Lmf6dGvZM59BL/RFis3RVA6pzrcNDnl6kA7wqJWURu CrMA== X-Gm-Message-State: AOAM530k+o3uLU61eSG/XIxSmlzAciSfpgBq1mFf0o/JSkGhxCw1AiYa wfjrNScc3Zfqrv7vVIFinUONEw== X-Google-Smtp-Source: ABdhPJzPvt0OpTdpG2XOZd3WyGBlDV5YaW9zwKW7qD/jD4rhJEvrl+u/NspFOTeBnPF68PmgpH6SyA== X-Received: by 2002:a63:4182:: with SMTP id o124mr20869141pga.195.1591052509510; Mon, 01 Jun 2020 16:01:49 -0700 (PDT) Received: from [192.168.1.11] (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id u21sm385591pfn.123.2020.06.01.16.01.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 16:01:48 -0700 (PDT) Subject: Re: [PATCH v4 13/13] stubs: Restrict ui/win32-kbd-hook to system-mode To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20200522172510.25784-1-philmd@redhat.com> <20200522172510.25784-14-philmd@redhat.com> From: Richard Henderson Message-ID: <5ef88218-960e-0779-e40e-13ec300c3dad@linaro.org> Date: Mon, 1 Jun 2020 16:01:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200522172510.25784-14-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::441; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x441.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , qemu-riscv@nongnu.org, Eduardo Habkost , Sagar Karandikar , David Hildenbrand , Bastian Koppelmann , =?UTF-8?Q?Volker_R=c3=bcmelin?= , qemu-s390x@nongnu.org, Alistair Francis , Gerd Hoffmann , Paolo Bonzini , Palmer Dabbelt , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/22/20 10:25 AM, Philippe Mathieu-Daudé wrote: > In Makefile.objs, the ui/ directory is restricted to system-mode: > > 43 ifeq ($(CONFIG_SOFTMMU),y) > ... > 65 common-obj-y += ui/ > 66 common-obj-m += ui/ > ... > 82 endif # CONFIG_SOFTMMU > > Restrict the ui/ stub added in commit 2df9f5718df to only build > it for system-mode emulation. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Richard Henderson r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jftRP-0003fs-NW for mharc-qemu-riscv@gnu.org; Mon, 01 Jun 2020 19:01:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jftRN-0003eu-PC for qemu-riscv@nongnu.org; Mon, 01 Jun 2020 19:01:57 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:34021) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jftRL-0006Wl-Gi for qemu-riscv@nongnu.org; Mon, 01 Jun 2020 19:01:56 -0400 Received: by mail-pf1-x442.google.com with SMTP id z64so4147283pfb.1 for ; Mon, 01 Jun 2020 16:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MBwhioOTO5IwQ4eAH5O+LHoa1q/Fp8wPnF66132BV6w=; b=I62oPMhOzcriXPS+ul3GZ3PSdaR6gFw/VI6rYaWsgLSZ8o87jK+qiDYX1EXoNw31kS scLDgckCgcxRHkEg2fjgKy8bxunKvxEbslJjfLH2fy6LaM5eNGEKJXSuqKC6HIfcu6G5 1sjdhL18favA4hRG5Svk//8VYxkYwBXOdsyzPGIGequ1KZD8lvxcSTYDWVUjPWFsYFo7 tEsmo+bc63VDHcpSunMCcQE0u6kp0t20Ilhr9e1rBr3RtNQD6zpxOYs4m1eGNc+1my7L fBc0NJ7WzwnfwqzlafdSBOIIPoXNMPtcJ/S/aoEuXd069UT9ifyzQRCxjdFCXMxtOv9I tT+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MBwhioOTO5IwQ4eAH5O+LHoa1q/Fp8wPnF66132BV6w=; b=Dd8hN+NrQ9yh2q6c9np6qfG9P+/3RIrNZj8KvJiVjpfbFPW+J6YbV0kex7GLJNVmo6 rc6KVBfkrLRL+4nf3MnYMsSgGFV1sCly+ZfaCW4TNdChzCy/Ic83/X5H+ICro0IZH2P9 Hq6UfT5JFbTqH5Sb3ZByIhzEMNxLw5gDMSXlzfwlzRK2SHeXGgpyPmcXF/KuUNGD52+9 Qo9eVghJ8lvPy4dwrQQT+R4T7Vr2kTw4swOAzoBkp1DgIo9xM1jmgRJmpF3Q/EFwCFWk 2sRSu4K84eaXk0ktj9AA8crlf6tu2u+rVApewlWCMespwEzOUEnz1Zg7pZuRxNyrzXrv GTug== X-Gm-Message-State: AOAM531B1SgkqTW0RLV8zOt4jTFBeWbOPwk4gV9AnZVdhm9bAA4v/g3H jKnYVAcuzLcC5fkud1n4FX4B5g== X-Google-Smtp-Source: ABdhPJzPvt0OpTdpG2XOZd3WyGBlDV5YaW9zwKW7qD/jD4rhJEvrl+u/NspFOTeBnPF68PmgpH6SyA== X-Received: by 2002:a63:4182:: with SMTP id o124mr20869141pga.195.1591052509510; Mon, 01 Jun 2020 16:01:49 -0700 (PDT) Received: from [192.168.1.11] (174-21-143-238.tukw.qwest.net. [174.21.143.238]) by smtp.gmail.com with ESMTPSA id u21sm385591pfn.123.2020.06.01.16.01.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Jun 2020 16:01:48 -0700 (PDT) Subject: Re: [PATCH v4 13/13] stubs: Restrict ui/win32-kbd-hook to system-mode To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Volker_R=c3=bcmelin?= , qemu-riscv@nongnu.org, Eduardo Habkost , Sagar Karandikar , David Hildenbrand , Bastian Koppelmann , Cornelia Huck , qemu-s390x@nongnu.org, Alistair Francis , Gerd Hoffmann , Paolo Bonzini , Palmer Dabbelt , Richard Henderson References: <20200522172510.25784-1-philmd@redhat.com> <20200522172510.25784-14-philmd@redhat.com> From: Richard Henderson Message-ID: <5ef88218-960e-0779-e40e-13ec300c3dad@linaro.org> Date: Mon, 1 Jun 2020 16:01:46 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200522172510.25784-14-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2020 23:01:58 -0000 On 5/22/20 10:25 AM, Philippe Mathieu-Daudé wrote: > In Makefile.objs, the ui/ directory is restricted to system-mode: > > 43 ifeq ($(CONFIG_SOFTMMU),y) > ... > 65 common-obj-y += ui/ > 66 common-obj-m += ui/ > ... > 82 endif # CONFIG_SOFTMMU > > Restrict the ui/ stub added in commit 2df9f5718df to only build > it for system-mode emulation. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Richard Henderson r~